Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package irqbalance for openSUSE:Factory checked in at 2022-10-27 13:52:14 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/irqbalance (Old) and /work/SRC/openSUSE:Factory/.irqbalance.new.2275 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "irqbalance" Thu Oct 27 13:52:14 2022 rev:67 rq:1031212 version:1.9.1 Changes: -------- --- /work/SRC/openSUSE:Factory/irqbalance/irqbalance.changes 2022-10-20 11:09:44.831780893 +0200 +++ /work/SRC/openSUSE:Factory/.irqbalance.new.2275/irqbalance.changes 2022-10-27 13:52:17.383994797 +0200 @@ -1,0 +2,6 @@ +Tue Oct 25 21:09:07 UTC 2022 - Dirk M��ller <dmueller@suse.com> + +- run tests +- add Avoid-double-free-on-deinit_thermal.patch (bsc#1204607) + +------------------------------------------------------------------- @@ -5 +11 @@ -- build with thermald support on x86_64 (jsc#PED-754) +- build with thermald support on x86_64 (jsc#PED-1039) @@ -20,3 +25,0 @@ -- Includes the patches for feature: - jsc#PED-754 - Enable IRQ Balancer to support SoC die during low power state New: ---- Avoid-double-free-on-deinit_thermal.patch ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ irqbalance.spec ++++++ --- /var/tmp/diff_new_pack.n6h3hP/_old 2022-10-27 13:52:17.939997582 +0200 +++ /var/tmp/diff_new_pack.n6h3hP/_new 2022-10-27 13:52:17.943997602 +0200 @@ -31,6 +31,8 @@ Source3: sysconfig.irqbalance Patch1: Set-fd-limit.patch Patch2: uninitialized.patch +# https://github.com/Irqbalance/irqbalance/pull/243 +Patch3: Avoid-double-free-on-deinit_thermal.patch BuildRequires: libcap-ng-devel BuildRequires: libtool BuildRequires: ncurses-devel @@ -84,6 +86,9 @@ install -D -m 0644 misc/irqbalance.service %{buildroot}%{_unitdir}/irqbalance.service ln -s %{_sbindir}/service %{buildroot}%{_sbindir}/rcirqbalance +%check +%make_build check + %pre %service_add_pre irqbalance.service ++++++ Avoid-double-free-on-deinit_thermal.patch ++++++ From b25b1f92ca88aa9f268c93d0d7f66efc0ebf840b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dirk=20M=C3=BCller?= <dirk@dmllr.de> Date: Tue, 25 Oct 2022 23:33:14 +0200 Subject: [PATCH] Avoid double free on deinit_thermal() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit init_thermal() calls deinit_thermal() on error condition, as well as main() calls deinit_thermal() again, causing a double-free. Signed-off-by: Dirk M��ller <dirk@dmllr.de> --- thermal.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/thermal.c b/thermal.c index 64a9cdf..1d44104 100644 --- a/thermal.c +++ b/thermal.c @@ -506,8 +506,14 @@ static gboolean set_netlink_nonblocking(void) void deinit_thermal(void) { - nl_cb_put(callback); - nl_socket_free(sock); + if (callback) { + nl_cb_put(callback); + callback = NULL; + } + if (sock) { + nl_socket_free(sock); + sock = NULL; + } } /* -- 2.38.0