Hello community, here is the log from the commit of package eog-plugins for openSUSE:Factory checked in at 2015-11-11 10:31:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/eog-plugins (Old) and /work/SRC/openSUSE:Factory/.eog-plugins.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "eog-plugins" Changes: -------- --- /work/SRC/openSUSE:Factory/eog-plugins/eog-plugins.changes 2015-10-06 16:37:06.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.eog-plugins.new/eog-plugins.changes 2015-11-11 10:35:41.000000000 +0100 @@ -1,0 +2,8 @@ +Mon Nov 9 21:37:29 UTC 2015 - zaitor@opensuse.org + +- Update to version 3.16.3: + + Some entries of the popovermenu entry should be grayed when no + image opened (bgo#755244). + + Updated translations. + +------------------------------------------------------------------- Old: ---- eog-plugins-3.16.2.tar.xz New: ---- eog-plugins-3.16.3.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ eog-plugins.spec ++++++ --- /var/tmp/diff_new_pack.rBhzpw/_old 2015-11-11 10:35:41.000000000 +0100 +++ /var/tmp/diff_new_pack.rBhzpw/_new 2015-11-11 10:35:41.000000000 +0100 @@ -17,7 +17,7 @@ Name: eog-plugins -Version: 3.16.2 +Version: 3.16.3 Release: 0 #FIXME: add postr BuildRequires when we have a package Summary: A collection of plugins for Eye of GNOME ++++++ eog-plugins-3.16.2.tar.xz -> eog-plugins-3.16.3.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/ChangeLog new/eog-plugins-3.16.3/ChangeLog --- old/eog-plugins-3.16.2/ChangeLog 2015-09-28 15:41:03.000000000 +0200 +++ new/eog-plugins-3.16.3/ChangeLog 2015-11-09 21:14:16.000000000 +0100 @@ -1,5 +1,90 @@ # Generated by Makefile. Do not edit. +commit db26b56e992497d0d40866e4a6622e5f0b133fea +Author: Felix Riemann <friemann@gnome.org> +Date: Mon Nov 9 21:13:46 2015 +0100 + + Prepare for release 3.16.3 + + NEWS | 8 ++++++++ + 1 file changed, 8 insertions(+) + +commit dbd6247cafcab3c81c0f554067d1e2a91276a7b8 +Author: Felix Riemann <friemann@gnome.org> +Date: Tue Sep 29 16:09:34 2015 +0200 + + export-to-folder: Only enable action if there's something to export + + Nothing would happen in that case anyway. + + https://bugzilla.gnome.org/show_bug.cgi?id=755244 + + plugins/export-to-folder/export-to-folder.py | 24 +++++++++++++++++++++++- + 1 file changed, 23 insertions(+), 1 deletion(-) + +commit de573cf3e960daec249733be71c696b63174a075 +Author: Felix Riemann <friemann@gnome.org> +Date: Tue Sep 29 15:36:22 2015 +0200 + + postasa: Disable upload action if no images are selected + + Nothing would happen, so don't offer it. + + https://bugzilla.gnome.org/show_bug.cgi?id=755244 + + plugins/postasa/eog-postasa-plugin.c | 38 ++++++++++++++++++++++++++++++++++++ + 1 file changed, 38 insertions(+) + +commit 39e8d056aa2ebfabf353cf607e517338fcb5c57e +Author: Felix Riemann <friemann@gnome.org> +Date: Tue Sep 29 15:14:31 2015 +0200 + + postr: Disable action if no images are selected + + https://bugzilla.gnome.org/show_bug.cgi?id=755244 + + plugins/postr/eog-postr-plugin.c | 37 +++++++++++++++++++++++++++++++++++++ + 1 file changed, 37 insertions(+) + +commit f0310c403fbf5d69087ec2b08ebf444894def23a +Author: Felix Riemann <friemann@gnome.org> +Date: Tue Sep 29 14:51:34 2015 +0200 + + send-by-mail: Only enable action if an image is selected + + The result is not really nice if used without selection. Evolution for + example will open with an error message. Will also avoid offering + the action if no image is loaded. + + https://bugzilla.gnome.org/show_bug.cgi?id=755244 + + plugins/send-by-mail/eog-send-by-mail-plugin.c | 37 ++++++++++++++++++++++++++ + 1 file changed, 37 insertions(+) + +commit bb2f47cb8f8e41e566c349a1fd896f663541c50f +Author: Felix Riemann <friemann@gnome.org> +Date: Tue Sep 29 13:42:47 2015 +0200 + + fit-to-width: Only enable plugin action if zoom is enabled + + If the default zoom actions are not enabled it is unlikely + the fit-to-width zoom should be enabled as well. + Also fixes a critical warning if eog is started without an image. + + https://bugzilla.gnome.org/show_bug.cgi?id=755244 + + plugins/fit-to-width/eog-fit-to-width-plugin.c | 10 ++++++++++ + 1 file changed, 10 insertions(+) + +commit dc56214c2c12c80b01efb4e2a055c63e8a5295ec +Author: Felix Riemann <friemann@gnome.org> +Date: Mon Sep 28 15:46:44 2015 +0200 + + Post-release version bump + + configure.ac | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + commit 855294926cf2b37ed0c9af0daf1b3e9cc146567d Author: Felix Riemann <friemann@gnome.org> Date: Mon Sep 28 15:37:53 2015 +0200 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/NEWS new/eog-plugins-3.16.3/NEWS --- old/eog-plugins-3.16.2/NEWS 2015-09-28 15:37:38.000000000 +0200 +++ new/eog-plugins-3.16.3/NEWS 2015-11-09 21:13:30.000000000 +0100 @@ -1,3 +1,11 @@ +Version 3.16.3 +-------------- + +General changes: + +- #755244, Some entries of the popovermenu entry should be grayed + when no image opened (Felix Riemann) + Version 3.16.2 -------------- diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/configure new/eog-plugins-3.16.3/configure --- old/eog-plugins-3.16.2/configure 2015-08-24 18:46:36.000000000 +0200 +++ new/eog-plugins-3.16.3/configure 2015-09-29 12:54:57.000000000 +0200 @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for eog-plugins 3.16.2. +# Generated by GNU Autoconf 2.69 for eog-plugins 3.16.3. # # Report bugs to <http://bugzilla.gnome.org/enter_bug.cgi?product=eog&component=plugins>. # @@ -591,8 +591,8 @@ # Identity of this package. PACKAGE_NAME='eog-plugins' PACKAGE_TARNAME='eog-plugins' -PACKAGE_VERSION='3.16.2' -PACKAGE_STRING='eog-plugins 3.16.2' +PACKAGE_VERSION='3.16.3' +PACKAGE_STRING='eog-plugins 3.16.3' PACKAGE_BUGREPORT='http://bugzilla.gnome.org/enter_bug.cgi?product=eog&component=plugins' PACKAGE_URL='' @@ -1415,7 +1415,7 @@ # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures eog-plugins 3.16.2 to adapt to many kinds of systems. +\`configure' configures eog-plugins 3.16.3 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1485,7 +1485,7 @@ if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of eog-plugins 3.16.2:";; + short | recursive ) echo "Configuration of eog-plugins 3.16.3:";; esac cat <<\_ACEOF @@ -1622,7 +1622,7 @@ test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -eog-plugins configure 3.16.2 +eog-plugins configure 3.16.3 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1991,7 +1991,7 @@ This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by eog-plugins $as_me 3.16.2, which was +It was created by eog-plugins $as_me 3.16.3, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2953,7 +2953,7 @@ # Define the identity of the package. PACKAGE='eog-plugins' - VERSION='3.16.2' + VERSION='3.16.3' cat >>confdefs.h <<_ACEOF @@ -15852,7 +15852,7 @@ # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by eog-plugins $as_me 3.16.2, which was +This file was extended by eog-plugins $as_me 3.16.3, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -15918,7 +15918,7 @@ cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -eog-plugins config.status 3.16.2 +eog-plugins config.status 3.16.3 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/configure.ac new/eog-plugins-3.16.3/configure.ac --- old/eog-plugins-3.16.2/configure.ac 2015-08-17 21:26:36.000000000 +0200 +++ new/eog-plugins-3.16.3/configure.ac 2015-09-28 15:46:39.000000000 +0200 @@ -3,7 +3,7 @@ EOG_MAJOR=3.0.0 EOG_PLUGINS_MAJOR=3.0.0 -AC_INIT([eog-plugins], [3.16.2], [http://bugzilla.gnome.org/enter_bug.cgi?product=eog&component=plugins]) +AC_INIT([eog-plugins], [3.16.3], [http://bugzilla.gnome.org/enter_bug.cgi?product=eog&component=plugins]) AC_CONFIG_SRCDIR([plugins]) AC_PREFIX_PROGRAM([eog]) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/plugins/export-to-folder/export-to-folder.py new/eog-plugins-3.16.3/plugins/export-to-folder/export-to-folder.py --- old/eog-plugins-3.16.2/plugins/export-to-folder/export-to-folder.py 2015-03-23 23:21:26.000000000 +0100 +++ new/eog-plugins-3.16.3/plugins/export-to-folder/export-to-folder.py 2015-09-29 16:08:09.000000000 +0200 @@ -36,6 +36,7 @@ def __init__(self): GObject.Object.__init__(self) self.settings = Gio.Settings.new(BASE_KEY) + self.selection_changed_handler_id = None @property def export_dir(self): @@ -52,11 +53,16 @@ self.window.add_action(action) menu = Gio.Menu() - menu.append(_('_Export'), 'win.export-to-folder') + menu.append(_('_Export'), 'win.' + _ACTION_NAME) item = Gio.MenuItem.new_section(None, menu) item.set_attribute([('id', 's', _MENU_ID)]) model.append_item(item) + thumbview = self.window.get_thumb_view() + self.selection_changed_handler_id = \ + thumbview.connect('selection-changed', self.update_action_state) + self.update_action_state(thumbview) + # Add accelerator key app = Eog.Application.get_instance() app.set_accels_for_action('win.' + _ACTION_NAME, ['E', None]) @@ -75,6 +81,11 @@ app = Eog.Application.get_instance() app.set_accels_for_action('win.' + _ACTION_NAME, ['E', None]) + if self.selection_changed_handler_id is not None: + thumbview = self.window.get_thumb_view() + thumbview.disconnect(self.selection_changed_handler_id) + self.selection_changed_handler_id = None + self.window.remove_action(_ACTION_NAME) def export_cb(self, action, parameter, window): @@ -94,6 +105,17 @@ shutil.copy2(src, dest) print('Copied %s into %s' % (name, self.export_dir)) + def update_action_state(self, thumbview=None): + action = self.window.lookup_action(_ACTION_NAME) + enable = False + if thumbview is None: + thumbview = self.window.get_thumb_view() + + if thumbview is not None: + enable = (thumbview.get_n_selected() > 0) + + action.set_enabled(enable) + class ExportConfigurable(GObject.Object, PeasGtk.Configurable): diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/plugins/fit-to-width/eog-fit-to-width-plugin.c new/eog-plugins-3.16.3/plugins/fit-to-width/eog-fit-to-width-plugin.c --- old/eog-plugins-3.16.2/plugins/fit-to-width/eog-fit-to-width-plugin.c 2015-03-23 23:21:26.000000000 +0100 +++ new/eog-plugins-3.16.3/plugins/fit-to-width/eog-fit-to-width-plugin.c 2015-09-29 13:36:05.000000000 +0200 @@ -100,6 +100,7 @@ GMenu *model, *menu; GMenuItem *item; GSimpleAction *action; + GAction *ref_action; model= eog_window_get_gear_menu_section (plugin->window, "plugins-section"); @@ -112,6 +113,15 @@ G_CALLBACK (fit_to_width_cb), plugin->window); g_action_map_add_action (G_ACTION_MAP (plugin->window), G_ACTION (action)); + + /* Bind to the zoom-normal action's enabled property to only enable + * fit-to-width zooming if zooming is generally enabled */ + ref_action = g_action_map_lookup_action (G_ACTION_MAP (plugin->window), + "zoom-normal"); + if (ref_action) + g_object_bind_property (ref_action, "enabled", + action, "enabled", + G_BINDING_DEFAULT | G_BINDING_SYNC_CREATE); g_object_unref (action); /* Append entry to the window's gear menu */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/plugins/postasa/eog-postasa-plugin.c new/eog-plugins-3.16.3/plugins/postasa/eog-postasa-plugin.c --- old/eog-plugins-3.16.2/plugins/postasa/eog-postasa-plugin.c 2015-03-23 23:21:26.000000000 +0100 +++ new/eog-plugins-3.16.3/plugins/postasa/eog-postasa-plugin.c 2015-09-29 15:35:06.000000000 +0200 @@ -774,6 +774,35 @@ /*** EogPlugin Functions ***/ +static void +eog_postasa_plugin_update_action_state (EogPostasaPlugin *plugin) +{ + EogPostasaPluginPrivate *priv = plugin->priv; + GAction *action; + EogThumbView *thumbview; + gboolean enable = FALSE; + + thumbview = EOG_THUMB_VIEW (eog_window_get_thumb_view (priv->eog_window)); + + if (G_LIKELY (thumbview)) + { + enable = (eog_thumb_view_get_n_selected (thumbview) != 0); + } + + action = g_action_map_lookup_action (G_ACTION_MAP (priv->eog_window), + EOG_POSTASA_PLUGIN_ACTION); + g_simple_action_set_enabled (G_SIMPLE_ACTION (action), enable); +} + +static void +_selection_changed_cb (EogThumbView *thumbview, gpointer user_data) +{ + EogPostasaPlugin *plugin = EOG_POSTASA_PLUGIN (user_data); + + if (G_LIKELY (plugin)) + eog_postasa_plugin_update_action_state (plugin); +} + /** * impl_activate: * @@ -802,6 +831,12 @@ G_ACTION (action)); g_object_unref (action); + g_signal_connect (G_OBJECT (eog_window_get_thumb_view (plugin->priv->eog_window)), + "selection-changed", + G_CALLBACK (_selection_changed_cb), + plugin); + eog_postasa_plugin_update_action_state (plugin); + /* Append entry to the window's gear menu */ menu = g_menu_new (); g_menu_append (menu, _("Upload to PicasaWeb"), @@ -850,6 +885,9 @@ } } + g_signal_handlers_disconnect_by_func (eog_window_get_thumb_view (plugin->priv->eog_window), + _selection_changed_cb, plugin); + /* Finally remove action */ g_action_map_remove_action (G_ACTION_MAP (plugin->priv->eog_window), EOG_POSTASA_PLUGIN_ACTION); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/plugins/postr/eog-postr-plugin.c new/eog-plugins-3.16.3/plugins/postr/eog-postr-plugin.c --- old/eog-plugins-3.16.2/plugins/postr/eog-postr-plugin.c 2015-03-23 23:21:26.000000000 +0100 +++ new/eog-plugins-3.16.3/plugins/postr/eog-postr-plugin.c 2015-09-29 15:13:40.000000000 +0200 @@ -70,6 +70,33 @@ g_free (cmd); } +static void +eog_postr_plugin_update_action_state (EogPostrPlugin *plugin) +{ + GAction *action; + EogThumbView *thumbview; + gboolean enable = FALSE; + + thumbview = EOG_THUMB_VIEW (eog_window_get_thumb_view (plugin->window)); + + if (G_LIKELY (thumbview)) + { + enable = (eog_thumb_view_get_n_selected (thumbview) != 0); + } + + action = g_action_map_lookup_action (G_ACTION_MAP (plugin->window), + EOG_POSTR_PLUGIN_ACTION); + g_simple_action_set_enabled (G_SIMPLE_ACTION (action), enable); +} + +static void +_selection_changed_cb (EogThumbView *thumbview, gpointer user_data) +{ + EogPostrPlugin *plugin = EOG_POSTR_PLUGIN (user_data); + + if (G_LIKELY (plugin)) + eog_postr_plugin_update_action_state (plugin); +} static void eog_postr_plugin_init (EogPostrPlugin *plugin) @@ -118,6 +145,12 @@ G_ACTION (action)); g_object_unref (action); + g_signal_connect (G_OBJECT (eog_window_get_thumb_view (plugin->window)), + "selection-changed", + G_CALLBACK (_selection_changed_cb), + plugin); + eog_postr_plugin_update_action_state (plugin); + /* Append entry to the window's gear menu */ menu = g_menu_new (); g_menu_append (menu, _("Upload to Flickr"), @@ -166,6 +199,10 @@ } } + g_signal_handlers_disconnect_by_func (eog_window_get_thumb_view (plugin->window), + _selection_changed_cb, plugin); + + /* Finally remove action */ g_action_map_remove_action (G_ACTION_MAP (plugin->window), EOG_POSTR_PLUGIN_ACTION); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/eog-plugins-3.16.2/plugins/send-by-mail/eog-send-by-mail-plugin.c new/eog-plugins-3.16.3/plugins/send-by-mail/eog-send-by-mail-plugin.c --- old/eog-plugins-3.16.2/plugins/send-by-mail/eog-send-by-mail-plugin.c 2015-03-23 23:21:26.000000000 +0100 +++ new/eog-plugins-3.16.3/plugins/send-by-mail/eog-send-by-mail-plugin.c 2015-09-29 14:49:13.000000000 +0200 @@ -59,6 +59,34 @@ } static void +eog_send_by_mail_plugin_update_action_state (EogSendByMailPlugin *plugin) +{ + GAction *action; + EogThumbView *thumbview; + gboolean enable = FALSE; + + thumbview = EOG_THUMB_VIEW (eog_window_get_thumb_view (plugin->window)); + + if (G_LIKELY (thumbview)) + { + enable = (eog_thumb_view_get_n_selected (thumbview) != 0); + } + + action = g_action_map_lookup_action (G_ACTION_MAP (plugin->window), + EOG_SEND_BY_MAIL_PLUGIN_ACTION); + g_simple_action_set_enabled (G_SIMPLE_ACTION (action), enable); +} + +static void +_selection_changed_cb (EogThumbView *thumbview, gpointer user_data) +{ + EogSendByMailPlugin *plugin = EOG_SEND_BY_MAIL_PLUGIN (user_data); + + if (G_LIKELY (plugin)) + eog_send_by_mail_plugin_update_action_state (plugin); +} + +static void impl_activate (EogWindowActivatable *activatable) { EogSendByMailPlugin *plugin = EOG_SEND_BY_MAIL_PLUGIN (activatable); @@ -79,6 +107,12 @@ G_ACTION (action)); g_object_unref (action); + g_signal_connect (G_OBJECT (eog_window_get_thumb_view (plugin->window)), + "selection-changed", + G_CALLBACK (_selection_changed_cb), + plugin); + eog_send_by_mail_plugin_update_action_state (plugin); + /* Append entry to the window's gear menu */ menu = g_menu_new (); g_menu_append (menu, _("Send by Mail"), @@ -124,6 +158,9 @@ } } + g_signal_handlers_disconnect_by_func (eog_window_get_thumb_view (plugin->window), + _selection_changed_cb, plugin); + /* Finally remove action */ g_action_map_remove_action (G_ACTION_MAP (plugin->window), EOG_SEND_BY_MAIL_PLUGIN_ACTION);