Hello community, here is the log from the commit of package ipmitool checked in at Mon May 29 18:02:48 CEST 2006. -------- --- ipmitool/ipmitool.changes 2006-05-28 13:04:52.000000000 +0200 +++ ipmitool/ipmitool.changes 2006-05-29 13:15:14.000000000 +0200 @@ -1,0 +2,5 @@ +Mon May 29 13:14:22 CEST 2006 - kukuk@suse.de + +- Fix type conversion bug in ipmi_pef.c [#173658] + +------------------------------------------------------------------- New: ---- ipmi_pef.diff ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ ipmitool.spec ++++++ --- /var/tmp/diff_new_pack.3GYXua/_old 2006-05-29 18:02:17.000000000 +0200 +++ /var/tmp/diff_new_pack.3GYXua/_new 2006-05-29 18:02:17.000000000 +0200 @@ -15,11 +15,12 @@ URL: http://ipmitool.sourceforge.net/ Summary: Utility for IPMI Control Version: 1.8.6 -Release: 13 +Release: 14 License: BSD Group: System/Management Source: ipmitool-%{version}.tar.bz2 Patch: ipmitool-%{version}.dif +Patch1: ipmi_pef.diff BuildRoot: %{_tmppath}/%{name}-%{version}-build %description @@ -43,6 +44,7 @@ %prep %setup %patch +%patch1 %build CFLAGS="$RPM_OPT_FLAGS" ./configure \ @@ -74,6 +76,8 @@ %doc %{_mandir}/man8/* %changelog -n ipmitool +* Mon May 29 2006 - kukuk@suse.de +- Fix type conversion bug in ipmi_pef.c [#173658] * Fri May 26 2006 - schwab@suse.de - Add readline-devel to BuildRequires to enable shell command. - Fix use of channel_info bitfield. ++++++ ipmi_pef.diff ++++++ --- lib/ipmi_pef.c.orig Mon May 8 13:59:55 2006 +++ lib/ipmi_pef.c Mon May 8 14:03:02 2006 @@ -731,6 +731,7 @@ ipmi_pef_get_status(struct ipmi_intf * i struct pef_cfgparm_selector psel; char tbuf[40]; time_t ts; + uint32_t timei; memset(&req, 0, sizeof(req)); req.msg.netfn = IPMI_NETFN_SE; @@ -741,11 +742,11 @@ ipmi_pef_get_status(struct ipmi_intf * i "Last S/W processed ID"); return; } + memcpy(&timei, rsp->data, 4); #if WORDS_BIGENDIAN - ts = (time_t)(rsp->data[0]<<24 + rsp->data[1]<<16 + rsp->data[2]<<8 + rsp->data[3]); -#else - ts = (time_t)(*(long *)rsp->data); + timei = BSWAP_32(timei); #endif + ts = (time_t)timei; strftime(tbuf, sizeof(tbuf), "%m/%d/%Y %H:%M:%S", localtime(&ts)); ipmi_pef_print_str("Last SEL addition", tbuf); ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun...