Hello community, here is the log from the commit of package yast2-storage checked in at Wed May 3 17:27:55 CEST 2006. -------- --- yast2-storage/yast2-storage.changes 2006-04-27 18:06:37.000000000 +0200 +++ STABLE/yast2-storage/yast2-storage.changes 2006-05-03 15:05:50.000000000 +0200 @@ -1,0 +2,8 @@ +Wed May 3 08:48:24 CEST 2006 - fehr@suse.de + +- disable check for boot size on macs (#170638) +- fix off-by-one max cylinder check (#171872) +- improve handling of unformatted DASD devices (#164930) +- version 2.13.58 + +------------------------------------------------------------------- Old: ---- yast2-storage-2.13.57.tar.bz2 New: ---- yast2-storage-2.13.58.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-storage.spec ++++++ --- /var/tmp/diff_new_pack.53cbvg/_old 2006-05-03 17:27:02.000000000 +0200 +++ /var/tmp/diff_new_pack.53cbvg/_new 2006-05-03 17:27:02.000000000 +0200 @@ -1,5 +1,5 @@ # -# spec file for package yast2-storage (Version 2.13.57) +# spec file for package yast2-storage (Version 2.13.58) # # Copyright (c) 2006 SUSE LINUX Products GmbH, Nuernberg, Germany. # This file and all modifications and additions to the pristine @@ -11,12 +11,12 @@ # norootforbuild Name: yast2-storage -Version: 2.13.57 -Release: 2 +Version: 2.13.58 +Release: 1 License: GPL Group: System/YaST BuildRoot: %{_tmppath}/%{name}-%{version}-build -Source0: yast2-storage-2.13.57.tar.bz2 +Source0: yast2-storage-2.13.58.tar.bz2 prefix: /usr BuildRequires: blocxx-devel docbook-xsl-stylesheets doxygen evms gcc-c++ libxcrypt-devel libxslt openssl-devel perl-XML-Writer sablot sgml-skel swig update-desktop-files yast2 yast2-devtools yast2-installation yast2-perl-bindings yast2-testsuite Requires: yast2 parted yast2-installation yast2-storage-lib yast2-perl-bindings @@ -40,7 +40,7 @@ %prep -%setup -n yast2-storage-2.13.57 +%setup -n yast2-storage-2.13.58 %build %{prefix}/bin/y2tool y2autoconf @@ -164,6 +164,11 @@ %doc %{prefix}/share/doc/packages/yast2-storage/libstorage %changelog -n yast2-storage +* Wed May 03 2006 - fehr@suse.de +- disable check for boot size on macs (#170638) +- fix off-by-one max cylinder check (#171872) +- improve handling of unformatted DASD devices (#164930) +- version 2.13.58 * Thu Apr 27 2006 - fehr@suse.de - call udevsettle instead of udev.count_events - remove sole /dev/evms/md/ entries (#170075) ++++++ yast2-storage-2.13.57.tar.bz2 -> yast2-storage-2.13.58.tar.bz2 ++++++ diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/yast2-storage-2.13.57/VERSION new/yast2-storage-2.13.58/VERSION --- old/yast2-storage-2.13.57/VERSION 2006-04-27 11:45:55.000000000 +0200 +++ new/yast2-storage-2.13.58/VERSION 2006-05-03 08:49:01.000000000 +0200 @@ -1 +1 @@ -2.13.57 +2.13.58 diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/yast2-storage-2.13.57/libstorage/src/Dasd.cc new/yast2-storage-2.13.58/libstorage/src/Dasd.cc --- old/yast2-storage-2.13.57/libstorage/src/Dasd.cc 2006-04-24 15:09:08.000000000 +0200 +++ new/yast2-storage-2.13.58/libstorage/src/Dasd.cc 2006-05-03 11:44:34.000000000 +0200 @@ -22,6 +22,7 @@ unsigned long long SizeK ) : Disk(s,Name,SizeK) { + fmt = DASDF_NONE; y2debug( "constructed dasd %s", dev.c_str() ); } @@ -235,11 +236,8 @@ tmp = tmp.erase( 0, tmp.find( ':' ) + 1 ); tmp = extractNthWord( 3, tmp ); tmp >> val; - if( val>0 ) - { - y2mil( "val:" << val ); - c=val; - } + y2mil( "val:" << val ); + c=val; } if( cmd.select( "tracks per" )>0 ) { @@ -249,11 +247,8 @@ tmp = tmp.erase( 0, tmp.find( ':' ) + 1 ); tmp = extractNthWord( 3, tmp ); tmp >> val; - if( val>0 ) - { - y2mil( "val:" << val ); - h=val; - } + y2mil( "val:" << val ); + h=val; } if( cmd.select( "blocks per" )>0 ) { @@ -263,11 +258,8 @@ tmp = tmp.erase( 0, tmp.find( ':' ) + 1 ); tmp = extractNthWord( 3, tmp ); tmp >> val; - if( val>0 ) - { - y2mil( "val:" << val ); - s=val; - } + y2mil( "val:" << val ); + s=val; } if( cmd.select( "blocksize" )>0 ) { @@ -277,11 +269,8 @@ tmp = tmp.erase( 0, tmp.find( ':' ) + 1 ); tmp = extractNthWord( 3, tmp ); tmp >> val; - if( val>0 ) - { - y2mil( "val:" << val ); - s*=val/512; - } + y2mil( "val:" << val ); + s*=val/512; } y2milestone( "c:%lu h:%u s:%u", c, h, s ); } @@ -595,6 +584,13 @@ init_disk = value; if( init_disk ) { + new_sector = sector = 96; + new_head = head = 15; + y2milestone( "new sector:%u head:%u", sector, head ); + size_k = (head*sector*cyl)/2; + y2milestone( "new SizeK:%llu", size_k ); + byte_cyl = head * sector * 512; + y2milestone( "new byte_cyl:%lu", byte_cyl ); ret = destroyPartitionTable( "dasd" ); } else diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/yast2-storage-2.13.57/libstorage/src/Disk.cc new/yast2-storage-2.13.58/libstorage/src/Disk.cc --- old/yast2-storage-2.13.57/libstorage/src/Disk.cc 2006-04-25 11:34:40.000000000 +0200 +++ new/yast2-storage-2.13.58/libstorage/src/Disk.cc 2006-05-03 12:28:12.000000000 +0200 @@ -1974,7 +1974,7 @@ } } y2milestone( "max %lu", maxc ); - if( end>maxc && maxc<cylinders()-1 ) + if( end>maxc && maxc<=cylinders()-1 ) { y2milestone( "corrected end from %lu to max %lu", end, maxc ); end = maxc; diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/yast2-storage-2.13.57/libstorage/src/Dm.cc new/yast2-storage-2.13.58/libstorage/src/Dm.cc --- old/yast2-storage-2.13.57/libstorage/src/Dm.cc 2006-04-27 16:21:54.000000000 +0200 +++ new/yast2-storage-2.13.58/libstorage/src/Dm.cc 2006-05-02 19:14:53.000000000 +0200 @@ -259,7 +259,7 @@ void Dm::updateMajorMinor() { getMajorMinor( dev, mjr, mnr ); - if( majorNr()>0 ) + if( majorNr()==Dm::dmMajor() ) { string d = "/dev/dm-" + decString(minorNr()); if( d!=dev ) diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/yast2-storage-2.13.57/storage/src/include/custom_part_check_generated.ycp new/yast2-storage-2.13.58/storage/src/include/custom_part_check_generated.ycp --- old/yast2-storage-2.13.57/storage/src/include/custom_part_check_generated.ycp 2006-04-11 15:20:53.000000000 +0200 +++ new/yast2-storage-2.13.58/storage/src/include/custom_part_check_generated.ycp 2006-05-03 08:49:49.000000000 +0200 @@ -24,7 +24,7 @@ * ************************************************************* - $Id: custom_part_check_generated.ycp 29984 2006-04-11 13:20:49Z fehr $ + $Id: custom_part_check_generated.ycp 30634 2006-05-03 06:49:44Z fehr $ */ { @@ -117,7 +117,7 @@ symbol root_fs = `unknown; symbol boot_fs = `unknown; integer boot_size = 0; - boolean boot_size_check = !(Arch::board_chrp () || Arch::board_prep () || Arch::board_iseries ()); + boolean boot_size_check = !(Arch::board_chrp() || Arch::board_prep() || Arch::board_iseries() || Arch::board_mac()); integer root_cyl_for_gb = 0; integer boot_cyl_for_gb = 0; string axp_start_dev = ""; diff -urN --exclude=CVS --exclude=.cvsignore --exclude=.svn --exclude=.svnignore old/yast2-storage-2.13.57/storage/src/inst_custom_part.ycp new/yast2-storage-2.13.58/storage/src/inst_custom_part.ycp --- old/yast2-storage-2.13.57/storage/src/inst_custom_part.ycp 2006-04-24 17:46:31.000000000 +0200 +++ new/yast2-storage-2.13.58/storage/src/inst_custom_part.ycp 2006-05-03 15:05:59.000000000 +0200 @@ -26,7 +26,7 @@ * ************************************************************* - $Id: inst_custom_part.ycp 30423 2006-04-24 15:46:27Z fehr $ + $Id: inst_custom_part.ycp 30649 2006-05-03 13:05:55Z fehr $ */ { @@ -2128,7 +2128,8 @@ foreach( string dev, map disk, targetMap, ``{ - if( Storage::IsRealDisk( disk ) ) + y2milestone( "dev:%1 isReal:%2", dev, Storage::IsRealDisk( disk ) ); + if( !disk["readonly"]:false && Storage::IsRealDisk( disk ) ) { txt = sformat( "&%1: %2", n+1, dev ); diskgroup = add( diskgroup, `Left( `RadioButton( `id(dev), txt, @@ -2137,6 +2138,7 @@ disks = add ( disks, dev ); } }); + y2milestone( "disks:%1", disks ); if( size(disks)>10 ) { diskgroup = `VBox( `SelectionBox( `id(`disklist), _("Available &Disks"), @@ -2147,7 +2149,7 @@ diskgroup = `RadioButtonGroup( `id(`choosedisk), diskgroup ); } - if( size(disks) != 1 ) + if( size(disks) > 1 ) { UI::OpenDialog( `opt(`decorated), `VBox(`Heading( heading ), `VSpacing(0.5), @@ -2207,11 +2209,21 @@ return(r); } } - else + else if( size(disks) == 1 ) { // if there is only one disk: no return( disks[0]:"" ); } + else if( size(disks) == 0 ) + { + string txt = _("There are no partitionable Disks available."); + if( Arch::s390() ) + { + txt = txt + "\n" + _("You may use dasdfmt in Expert-Button to low level format disks."); + } + Popup::Error( txt ); + return( "" ); + } }; define term RaidButton( integer num ) @@ -2611,7 +2623,7 @@ _("Disk to Partition"), `create ); - if( ddev == nil ) + if( ddev == nil || size(ddev)==0 ) { ret = `again; continue; ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Remember to have fun...