Hello community,
here is the log from the commit of package WoeUSB for openSUSE:Factory checked in at 2018-12-28 12:34:58
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/WoeUSB (Old)
and /work/SRC/openSUSE:Factory/.WoeUSB.new.28833 (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "WoeUSB"
Fri Dec 28 12:34:58 2018 rev:10 rq:661436 version:3.2.12
Changes:
--------
--- /work/SRC/openSUSE:Factory/WoeUSB/WoeUSB.changes 2018-09-20 11:42:17.824827069 +0200
+++ /work/SRC/openSUSE:Factory/.WoeUSB.new.28833/WoeUSB.changes 2018-12-28 12:35:14.299966984 +0100
@@ -1,0 +2,15 @@
+Tue Dec 25 09:34:06 UTC 2018 - Yunhe Guo
+
+- Version 3.2.12
+ * This release features some minor improvements to the code.
+- Version 3.2.11
+ * This release fixes a big regression causing source image with
+ >4GiB file can't be installed on disks with NTFS target filesystem
+ using --partition USB preparation mode, refer Issue #226 for more
+ info.
+ * We would like to thank Luke Anderson(@spble) that brought up the
+ issue, @0xC1A551C for confirming it and providing mitigation,
+ and everyone in the discussion thread that helped to escalate
+ the issue.
+
+-------------------------------------------------------------------
Old:
----
WoeUSB-3.2.10.tar.gz
New:
----
WoeUSB-3.2.12.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ WoeUSB.spec ++++++
--- /var/tmp/diff_new_pack.x9z36s/_old 2018-12-28 12:35:14.695966708 +0100
+++ /var/tmp/diff_new_pack.x9z36s/_new 2018-12-28 12:35:14.699966705 +0100
@@ -17,7 +17,7 @@
Name: WoeUSB
-Version: 3.2.10
+Version: 3.2.12
Release: 0
Summary: Windows USB installation media creator
License: GPL-3.0-or-later
++++++ WoeUSB-3.2.10.tar.gz -> WoeUSB-3.2.12.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WoeUSB-3.2.10/.github/issue_template.md new/WoeUSB-3.2.12/.github/issue_template.md
--- old/WoeUSB-3.2.10/.github/issue_template.md 2018-09-18 17:36:41.000000000 +0200
+++ new/WoeUSB-3.2.12/.github/issue_template.md 2018-12-24 09:28:06.000000000 +0100
@@ -1,5 +1,5 @@
## Good Habit Checklist for Issue Reporting
-Checkout [Mastering Markdown · GitHub Guides](https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markd...) if you needs help on the GitHub-flavored Markdown syntax. You may remove sections and contents that don't apply.
+Checkout [Mastering Markdown · GitHub Guides](https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markd...) if you need help on the GitHub-flavored Markdown syntax. You may remove sections and contents that don't apply.
* [ ] I've searched the issue tracker and is pretty sure that there's no duplicate issue already filed
* [ ] I've built the latest development snapshot using the instructions in README and verified that the issue can still be reproduced (for bug reports)
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WoeUSB-3.2.10/README.md new/WoeUSB-3.2.12/README.md
--- old/WoeUSB-3.2.10/README.md 2018-09-18 17:36:41.000000000 +0200
+++ new/WoeUSB-3.2.12/README.md 2018-12-24 09:28:06.000000000 +0100
@@ -29,6 +29,8 @@
#### Official Distribution Packages
* [Fedora](https://src.fedoraproject.org/rpms/WoeUSB) packages maintained by mprahl
+* [openSUSE](https://software.opensuse.org/package/WoeUSB) packages maintained by [guoyunhe](https://guoyunhe.me/)
+* [Gentoo](https://packages.gentoo.org/packages/sys-boot/woeusb) packages maintained by pacho
#### Third-party Distribution Packages
* [Arch Linux](https://aur.archlinux.org/packages/woeusb-git/) packages maintained by darkfm
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/WoeUSB-3.2.10/src/woeusb new/WoeUSB-3.2.12/src/woeusb
--- old/WoeUSB-3.2.10/src/woeusb 2018-09-18 17:36:41.000000000 +0200
+++ new/WoeUSB-3.2.12/src/woeusb 2018-12-24 09:28:06.000000000 +0100
@@ -236,7 +236,8 @@
"${install_mode}" \
"${target_media}" \
target_device \
- target_partition
+ target_partition \
+ target_filesystem_type
check_source_and_target_not_busy \
"${install_mode}" \
@@ -831,16 +832,46 @@
}; declare -fr check_runtime_parameters
determine_target_parameters(){
- util_check_function_parameters_quantity 4 $#
+ util_check_function_parameters_quantity 5 $#
local install_mode="${1}"; shift
local target_media="${1}"; shift
local -n target_device_ref="${1}"; shift
local -n target_partition_ref="${1}"; shift
+ local -n target_filesystem_type_ref="${1}"; shift
if [ "${install_mode}" = partition ]; then
+ local target_filesystem_type_libblkid
+
target_partition_ref="${target_media}"
# BASHDOC: Basic Shell Features » Shell Expansions » Shell Parameter Expansion(`${PARAMETER/PATTERN/STRING}')
target_device_ref="${target_media/%[0-9]/}"
+
+ # Detect target filesystem
+ target_filesystem_type_libblkid="$(
+ lsblk \
+ --noheadings \
+ --output FSTYPE \
+ "${target_partition_ref}"
+ )"
+
+ case "${target_filesystem_type_libblkid}" in
+ vfat)
+ target_filesystem_type_ref=FS_FAT
+ ;;
+ ntfs)
+ target_filesystem_type_ref=FS_NTFS
+ ;;
+ *)
+ printf -- \
+ '%s: Error: Unsupported target filesystem "%s", currently supported target filesystems: %s, %s' \
+ "${FUNCNAME[0]}" \
+ "${target_filesystem_type_libblkid}" \
+ "${ENUM_SUPPORTED_FILESYSTEMS[FS_FAT]}" \
+ "${ENUM_SUPPORTED_FILESYSTEMS[FS_NTFS]}"
+ return 1
+ ;;
+ esac
+ unset target_filesystem_type_libblkid
else # install_mode = device
target_device_ref="${target_media}"
target_partition_ref="${target_device}1"
@@ -849,6 +880,9 @@
if [ "${verbose}" = true ]; then
echo "${FUNCNAME[0]}: Info: Target device is '${target_device_ref}'."
echo "${FUNCNAME[0]}: Info: Target partition is '${target_partition_ref}'."
+ if [ "${install_mode}" = partition ]; then
+ echo "${FUNCNAME[0]}: Info: Target filesystem is '${ENUM_SUPPORTED_FILESYSTEMS[$target_filesystem_type]}'."
+ fi
fi
return 0
}; declare -fr determine_target_parameters
@@ -928,15 +962,16 @@
'Ensure that %s is really wiped...\n' \
"${target_device}"
- if [ \
- "$(lsblk \
- --pairs \
- --output NAME,TYPE \
- "${target_device}" \
- | grep \
- --count \
- --fixed-strings \
- ' TYPE="part"'
+ if [ "$(
+ env LANG=C \
+ lsblk \
+ --noheadings \
+ --output TYPE \
+ "${target_device}" \
+ | grep \
+ --count \
+ --fixed-strings \
+ part
)" -ne 0 ]; then
printf_with_color \
red \
