Hello community, here is the log from the commit of package perl-Test-TCP for openSUSE:Factory checked in at 2016-05-03 09:37:34 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-Test-TCP (Old) and /work/SRC/openSUSE:Factory/.perl-Test-TCP.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "perl-Test-TCP" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-Test-TCP/perl-Test-TCP.changes 2016-04-22 16:23:13.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-Test-TCP.new/perl-Test-TCP.changes 2016-05-03 10:16:56.000000000 +0200 @@ -1,0 +2,27 @@ +Sun May 1 10:15:17 UTC 2016 - coolo@suse.com + +- updated to 2.16 + see /usr/share/doc/packages/perl-Test-TCP/Changes + + 2.16 2016-04-13T02:27:43Z + + commit 3ae73a349f70f06c60de3f635916929bc8643429 + Author: Alex Vandiver <alex@chmrr.net> + Date: Tue Apr 12 00:33:21 2016 -0700 + + Ensure that IO::Socket::IP is DESTROY'd before can_bind returns + + be316f1f worked around a core perl bug[1] which causes Perl < 5.24.0 + to DESTROY the IO::Socket::IP object too late, causing the empty port + to not actually be empty if it was used immediately. + + Unfortunately, this change was lost in ba745fd1, which again put the + return of `can_bind` on the stack along with the actual return value, + re-instating the bug. + + Split the statement across two statements again, and add a comment on + the importance of preserving it. + + [1] https://rt.perl.org/Public/Bug/Display.html?id=124248 + +------------------------------------------------------------------- Old: ---- Test-TCP-2.15.tar.gz New: ---- Test-TCP-2.16.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-Test-TCP.spec ++++++ --- /var/tmp/diff_new_pack.ZhgssA/_old 2016-05-03 10:16:56.000000000 +0200 +++ /var/tmp/diff_new_pack.ZhgssA/_new 2016-05-03 10:16:56.000000000 +0200 @@ -17,7 +17,7 @@ Name: perl-Test-TCP -Version: 2.15 +Version: 2.16 Release: 0 %define cpan_name Test-TCP Summary: Testing Tcp Program ++++++ Test-TCP-2.15.tar.gz -> Test-TCP-2.16.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/Changes new/Test-TCP-2.16/Changes --- old/Test-TCP-2.15/Changes 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/Changes 2016-04-13 04:28:55.000000000 +0200 @@ -1,5 +1,26 @@ Revision history for Perl module Test::TCP +2.16 2016-04-13T02:27:43Z + + commit 3ae73a349f70f06c60de3f635916929bc8643429 + Author: Alex Vandiver <alex@chmrr.net> + Date: Tue Apr 12 00:33:21 2016 -0700 + + Ensure that IO::Socket::IP is DESTROY'd before can_bind returns + + be316f1f worked around a core perl bug[1] which causes Perl < 5.24.0 + to DESTROY the IO::Socket::IP object too late, causing the empty port + to not actually be empty if it was used immediately. + + Unfortunately, this change was lost in ba745fd1, which again put the + return of `can_bind` on the stack along with the actual return value, + re-instating the bug. + + Split the statement across two statements again, and add a comment on + the importance of preserving it. + + [1] https://rt.perl.org/Public/Bug/Display.html?id=124248 + 2.15 2016-03-15T00:25:52Z - Add listen_socket function and listen option for race-free operation diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/META.json new/Test-TCP-2.16/META.json --- old/Test-TCP-2.15/META.json 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/META.json 2016-04-13 04:28:55.000000000 +0200 @@ -4,7 +4,7 @@ "Tokuhiro Matsuno <tokuhirom@gmail.com>" ], "dynamic_config" : 0, - "generated_by" : "Minilla/v2.5.0", + "generated_by" : "Minilla/v3.0.1", "license" : [ "perl_5" ], @@ -28,7 +28,7 @@ "prereqs" : { "configure" : { "requires" : { - "ExtUtils::MakeMaker" : "0" + "ExtUtils::MakeMaker" : "6.64" } }, "develop" : { @@ -67,7 +67,7 @@ }, "Test::TCP" : { "file" : "lib/Test/TCP.pm", - "version" : "2.15" + "version" : "2.16" }, "Test::TCP::CheckPort" : { "file" : "lib/Test/TCP/CheckPort.pm" @@ -84,7 +84,7 @@ "web" : "https://github.com/tokuhirom/Test-TCP" } }, - "version" : "2.15", + "version" : "2.16", "x_contributors" : [ "tokuhirom <tokuhirom@d0d07461-0603-4401-acd4-de1884942a52>", "mattn <mattn@d0d07461-0603-4401-acd4-de1884942a52>", @@ -106,7 +106,7 @@ "Tatsuhiko Miyagawa <miyagawa@gmail.com>", "Tatsuhiko Miyagawa <miyagawa@bulknews.net>", "Chad Granum <exodist7@gmail.com>", - "Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>" - ], - "x_serialization_backend" : "JSON::PP version 2.27300" + "Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>", + "Alex Vandiver <alex@chmrr.net>" + ] } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/META.yml new/Test-TCP-2.16/META.yml --- old/Test-TCP-2.15/META.yml 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/META.yml 2016-04-13 04:28:55.000000000 +0200 @@ -7,9 +7,9 @@ Socket: '0' Test::More: '0.98' configure_requires: - ExtUtils::MakeMaker: '0' + ExtUtils::MakeMaker: '6.64' dynamic_config: 0 -generated_by: 'Minilla/v2.5.0, CPAN::Meta::Converter version 2.150005' +generated_by: 'Minilla/v3.0.1, CPAN::Meta::Converter version 2.150001' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -30,7 +30,7 @@ file: lib/Net/EmptyPort.pm Test::TCP: file: lib/Test/TCP.pm - version: '2.15' + version: '2.16' Test::TCP::CheckPort: file: lib/Test/TCP/CheckPort.pm requires: @@ -44,7 +44,7 @@ bugtracker: https://github.com/tokuhirom/Test-TCP/issues homepage: https://github.com/tokuhirom/Test-TCP repository: git://github.com/tokuhirom/Test-TCP.git -version: '2.15' +version: '2.16' x_contributors: - 'tokuhirom <tokuhirom@d0d07461-0603-4401-acd4-de1884942a52>' - 'mattn <mattn@d0d07461-0603-4401-acd4-de1884942a52>' @@ -67,4 +67,4 @@ - 'Tatsuhiko Miyagawa <miyagawa@bulknews.net>' - 'Chad Granum <exodist7@gmail.com>' - 'Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>' -x_serialization_backend: 'CPAN::Meta::YAML version 0.017' + - 'Alex Vandiver <alex@chmrr.net>' diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/Makefile.PL new/Test-TCP-2.16/Makefile.PL --- old/Test-TCP-2.15/Makefile.PL 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/Makefile.PL 2016-04-13 04:28:55.000000000 +0200 @@ -3,19 +3,19 @@ # DO NOT EDIT DIRECTLY. # ========================================================================= -use 5.008_001; +use 5.006; use strict; -use ExtUtils::MakeMaker; +use ExtUtils::MakeMaker 6.64; my %WriteMakefileArgs = ( NAME => 'Test::TCP', DISTNAME => 'Test-TCP', - VERSION => '2.15', + VERSION => '2.16', EXE_FILES => [glob('script/*'), glob('bin/*')], CONFIGURE_REQUIRES => { - "ExtUtils::MakeMaker" => 0 + "ExtUtils::MakeMaker" => "6.64" } , BUILD_REQUIRES => {} @@ -37,33 +37,4 @@ , ); -my $full_prereqs = { - "ExtUtils::MakeMaker" => 0, - "File::Temp" => 0, - "IO::Socket::INET" => 0, - "IO::Socket::IP" => 0, - "Socket" => 0, - "Test::More" => "0.98", - "Test::SharedFork" => "0.29", - "Time::HiRes" => 0, - "perl" => "5.008001" -} -; - -unless (eval { ExtUtils::MakeMaker->VERSION(6.63_03) }) { - delete $WriteMakefileArgs{TEST_REQUIRES}; - delete $WriteMakefileArgs{BUILD_REQUIRES}; - $WriteMakefileArgs{PREREQ_PM} = $full_prereqs; -} - -unless (eval { ExtUtils::MakeMaker->VERSION(6.52) }) { - delete $WriteMakefileArgs{CONFIGURE_REQUIRES}; -} - -unless (eval { ExtUtils::MakeMaker->VERSION(6.57_01) }) { - use File::Copy; - copy('META.yml', 'MYMETA.yml') or warn "META.yml: $!"; - copy('META.json', 'MYMETA.json') or warn "META.json: $!"; -} - WriteMakefile(%WriteMakefileArgs); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/README.md new/Test-TCP-2.16/README.md --- old/Test-TCP-2.15/README.md 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/README.md 2016-04-13 04:28:55.000000000 +0200 @@ -252,7 +252,7 @@ # AUTHOR -Tokuhiro Matsuno <tokuhirom@gmail.com> +Tokuhiro Matsuno <tokuhirom@gmail.com> # THANKS TO diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/lib/Net/EmptyPort.pm new/Test-TCP-2.16/lib/Net/EmptyPort.pm --- old/Test-TCP-2.15/lib/Net/EmptyPort.pm 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/lib/Net/EmptyPort.pm 2016-04-13 04:28:55.000000000 +0200 @@ -10,7 +10,10 @@ sub can_bind { my ($host, $port, $proto) = @_; - defined _listen_socket($host, $port, $proto); + # The following must be split across two statements, due to + # https://rt.perl.org/Public/Bug/Display.html?id=124248 + my $s = _listen_socket($host, $port, $proto); + return defined $s; } sub _listen_socket { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/lib/Test/TCP.pm new/Test-TCP-2.16/lib/Test/TCP.pm --- old/Test-TCP-2.15/lib/Test/TCP.pm 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/lib/Test/TCP.pm 2016-04-13 04:28:55.000000000 +0200 @@ -2,7 +2,7 @@ use strict; use warnings; use 5.00800; -our $VERSION = '2.15'; +our $VERSION = '2.16'; use base qw/Exporter/; use Test::SharedFork 0.12; use Test::More (); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/Test-TCP-2.15/t/11_net_empty_port.t new/Test-TCP-2.16/t/11_net_empty_port.t --- old/Test-TCP-2.15/t/11_net_empty_port.t 2016-03-15 01:26:52.000000000 +0100 +++ new/Test-TCP-2.16/t/11_net_empty_port.t 2016-04-13 04:28:55.000000000 +0200 @@ -36,4 +36,13 @@ doit('::1'); }; +subtest 'return value' => sub { + my $sock = IO::Socket::IP->new( + LocalAddr => '127.0.0.1', + LocalPort => empty_port(), + Listen => 1, + ); + ok $sock; +}; + done_testing;