commit mgetty

24 May 2006

Hello community,

here is the log from the commit of package mgetty
checked in at Thu May 25 00:47:16 CEST 2006.

--------

--- mgetty/mgetty.changes	2006-02-27 16:41:00.000000000 +0100
+++ mgetty/mgetty.changes	2006-05-24 17:37:37.000000000 +0200
@@ -1,0 +2,6 @@
+Wed May 24 17:37:26 CEST 2006 - schwab@suse.de
+
+- Don't build as root.
+- Don't strip binaries.
+
+-------------------------------------------------------------------

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Other differences:
------------------
++++++ mgetty.spec ++++++
--- /var/tmp/diff_new_pack.mvSUhi/_old	2006-05-25 00:46:59.000000000 +0200
+++ /var/tmp/diff_new_pack.mvSUhi/_new	2006-05-25 00:46:59.000000000 +0200
@@ -8,11 +8,12 @@
 # Please submit bugfixes or comments via http://bugs.opensuse.org/
 #
 
+# norootforbuild
 
 Name:           mgetty
 BuildRequires:  netpbm te_ams te_latex
 Version:        1.1.33
-Release:        6
+Release:        16
 PreReq:         %install_info_prereq filesystem
 Requires:       g3utils
 Autoreqprov:    on
@@ -139,6 +140,7 @@
 %install_info_delete --info-dir=%{_infodir} %{_infodir}/%{name}.info.gz
 
 %files
+%defattr(-, root, root)
 %dir /etc/mgetty+sendfax
 %doc %{_docdir}/mgetty
 %dir /var/spool/voice
@@ -215,6 +217,7 @@
 %config /usr/lib/mgetty+sendfax/new_fax
 
 %files -n g3utils
+%defattr(-, root, root)
 /usr/bin/g32pbm
 /usr/bin/g3cat
 /usr/bin/g3topbm
@@ -224,12 +227,12 @@
 %doc %{_mandir}/man1/pbm2g3.1.gz
 
 %files -n sendfax
+%defattr(-, root, root)
 %dir /etc/mgetty+sendfax
 %dir /usr/lib/mgetty+sendfax
-%dir /var/spool/fax
+%attr(755,fax,root) %dir /var/spool/fax
 %dir /var/spool/fax/incoming
-#%attr(0755,fax,root)
-%verify(not mode) %dir /var/spool/fax/outgoing
+%attr(755,fax,root) %verify(not mode) %dir /var/spool/fax/outgoing
 #%dir /var/spool/fax/outgoing/locks
 %config(noreplace) /etc/mgetty+sendfax/faxheader
 %config(noreplace) /etc/mgetty+sendfax/faxrunq.config
@@ -243,8 +246,7 @@
 /usr/sbin/faxrunqd
 /usr/sbin/sendfax
 /usr/lib/mgetty+sendfax/new_fax
-#%attr(-,fax,root) 
-/usr/lib/mgetty+sendfax/faxq-helper
+%attr(4711,fax,root) /usr/lib/mgetty+sendfax/faxq-helper
 /usr/lib/mgetty+sendfax/cour25.pbm
 /usr/lib/mgetty+sendfax/cour25n.pbm
 %doc %{_mandir}/man1/fax.1.gz
@@ -258,6 +260,9 @@
 %doc %{_mandir}/man8/sendfax.8.gz
 
 %changelog -n mgetty
+* Wed May 24 2006 - schwab@suse.de
+- Don't build as root.
+- Don't strip binaries.
 * Mon Feb 27 2006 - anicka@suse.cz
 - fix #151487 (printf problem)
 * Wed Jan 25 2006 - mls@suse.de



++++++ mgetty-1.1.33.diff ++++++
--- /var/tmp/diff_new_pack.mvSUhi/_old	2006-05-25 00:46:59.000000000 +0200
+++ /var/tmp/diff_new_pack.mvSUhi/_new	2006-05-25 00:46:59.000000000 +0200
@@ -97,8 +97,8 @@
 +	-test -d $(DESTDIR)$(SBINDIR) || ( ./mkidirs $(DESTDIR)$(SBINDIR) ; chmod 755 $(DESTDIR)$(SBINDIR) )
 +	-mv -f $(DESTDIR)$(SBINDIR)/mgetty $(DESTDIR)$(SBINDIR)/mgetty.old
 +	-mv -f $(DESTDIR)$(SBINDIR)/sendfax $(DESTDIR)$(SBINDIR)/sendfax.old
-+	$(INSTALL) -s -m 700 mgetty $(DESTDIR)$(SBINDIR)
-+	$(INSTALL) -s -m 755 sendfax $(DESTDIR)$(SBINDIR)
++	$(INSTALL) -m 700 mgetty $(DESTDIR)$(SBINDIR)
++	$(INSTALL) -m 755 sendfax $(DESTDIR)$(SBINDIR)
  #
  # data files + directories
  #
@@ -121,15 +121,15 @@
 +	test -d $(DESTDIR)$(CONFDIR) || \
 +		( ./mkidirs $(DESTDIR)$(CONFDIR) && chmod 755 $(DESTDIR)$(CONFDIR))
 +	test -f $(DESTDIR)$(CONFDIR)/login.config || \
-+		$(INSTALL) -o root -m 600 login.config $(DESTDIR)$(CONFDIR)/
++		$(INSTALL) -m 600 login.config $(DESTDIR)$(CONFDIR)/
 +	test -f $(DESTDIR)$(CONFDIR)/mgetty.config || \
-+		$(INSTALL) -o root -m 600 mgetty.config $(DESTDIR)$(CONFDIR)/
++		$(INSTALL) -m 600 mgetty.config $(DESTDIR)$(CONFDIR)/
 +	test -f $(DESTDIR)$(CONFDIR)/sendfax.config || \
-+		$(INSTALL) -o root -m 644 sendfax.config $(DESTDIR)$(CONFDIR)/
++		$(INSTALL) -m 644 sendfax.config $(DESTDIR)$(CONFDIR)/
 +	test -f $(DESTDIR)$(CONFDIR)/dialin.config || \
-+		$(INSTALL) -o root -m 600 dialin.config $(DESTDIR)$(CONFDIR)/
++		$(INSTALL) -m 600 dialin.config $(DESTDIR)$(CONFDIR)/
 +	test -f $(DESTDIR)$(CONFDIR)/faxrunq.config || \
-+		$(INSTALL) -o root -m 644 faxrunq.config $(DESTDIR)$(CONFDIR)/
++		$(INSTALL) -m 644 faxrunq.config $(DESTDIR)$(CONFDIR)/
  #
  # test for outdated stuff
  #
@@ -138,7 +138,7 @@
  	then \
  	    echo "WARNING: the format of $(LIBDIR)/mgetty.login has " ;\
  	    echo "been changed. Because of this, to avoid confusions, it's called " ;\
-@@ -628,29 +630,29 @@
+@@ -628,29 +630,27 @@
  #
  # fax spool directories
  #
@@ -158,13 +158,11 @@
 +		( ./mkidirs $(DESTDIR)$(spool) && chmod 755 $(DESTDIR)$(spool) )
 +	test -d $(DESTDIR)$(FAX_SPOOL) || \
 +		( ./mkidirs $(DESTDIR)$(FAX_SPOOL) && \
-+		  chown $(FAX_OUT_USER) $(DESTDIR)$(FAX_SPOOL) && \
 +		  chmod 755 $(DESTDIR)$(FAX_SPOOL) )
 +	test -d $(DESTDIR)$(FAX_SPOOL_IN) || \
 +		( ./mkidirs $(DESTDIR)$(FAX_SPOOL_IN) && chmod 755 $(DESTDIR)$(FAX_SPOOL_IN) )
 +	test -d $(DESTDIR)$(FAX_SPOOL_OUT) || \
 +		  ./mkidirs $(DESTDIR)$(FAX_SPOOL_OUT)
-+	chown $(FAX_OUT_USER) $(DESTDIR)$(FAX_SPOOL_OUT)
 +	chmod 755 $(DESTDIR)$(FAX_SPOOL_OUT)
  #
  # g3 tool programs
@@ -182,16 +180,16 @@
  				BINDIR=$(BINDIR) SBINDIR=$(SBINDIR) \
  				LIBDIR=$(LIBDIR) CONFDIR=$(CONFDIR)
  #
-@@ -659,7 +661,7 @@
+@@ -659,7 +659,7 @@
  	if [ ! -z "$(INSTALL_MECHO)" ] ; then \
  	    cd compat ; \
  	    $(CC) $(CFLAGS) -o mg.echo mg.echo.c && \
 -	    $(INSTALL) -s -m 755 mg.echo $(BINDIR) ; \
-+	    $(INSTALL) -s -m 755 mg.echo $(DESTDIR)$(BINDIR) ; \
++	    $(INSTALL) -m 755 mg.echo $(DESTDIR)$(BINDIR) ; \
  	fi
  
  #
-@@ -667,19 +669,19 @@
+@@ -667,19 +667,19 @@
  #
  install.doc:
  	cd doc ; $(MAKE) install INSTALL="$(INSTALL)" \
@@ -218,7 +216,7 @@
  #
  # voice extensions, consult the `voice' chapter in the documentation
  #
-@@ -688,7 +690,7 @@
+@@ -688,7 +688,7 @@
  	@$(MAKE) mgetty
  	cd voice; $(MAKE) CFLAGS="$(CFLAGS)" CC="$(CC)" LDFLAGS="$(LDFLAGS)" \
  	LN="$(LN)" MV="$(MV)" RM="$(RM)" \
@@ -235,8 +233,8 @@
  install: all
 -	$(INSTALL) -s -m 700 -o root callback $(SBINDIR)
 -	$(INSTALL) -s -m 4711 -o root ct $(BINDIR)
-+	$(INSTALL) -s -m 755 -o root callback $(SBINDIR)
-+	$(INSTALL) -s -m 4755 -o root ct $(BINDIR)
++	$(INSTALL) -m 755 callback $(SBINDIR)
++	$(INSTALL) -m 4755 ct $(BINDIR)
  
  # source modules
 --- doc/Makefile
@@ -261,7 +259,7 @@
  	    done ; \
 --- fax/Makefile
 +++ fax/Makefile
-@@ -55,26 +55,30 @@
+@@ -55,26 +55,29 @@
  #
  # programs / scripts
  #
@@ -278,7 +276,6 @@
 -	chmod 4711 $(LIBDIR)/faxq-helper
 +	$(INSTALL) -m 755 faxrunqd $(DESTDIR)$(SBINDIR)
 +	$(INSTALL) faxq-helper $(DESTDIR)$(LIBDIR)
-+	chown $(FAX_OUT_USER) $(DESTDIR)$(LIBDIR)/faxq-helper
 +	chmod 4711 $(DESTDIR)$(LIBDIR)/faxq-helper
  #
  # data files
@@ -304,7 +301,7 @@
  	    else \
  		echo "WARNING: no PBM magic (string P1) found in /etc/magic" ; \
  		echo "         maybe you should append the definitions in \`\`fax/etc-magic''." ; \
-@@ -82,4 +86,4 @@
+@@ -82,4 +85,4 @@
  #
  # faxspool.rules sample file
  #
@@ -317,7 +314,7 @@
  #
  	for f in $(G3_PROGRAMS) ; do \
 -		$(INSTALL) -s -m 755 $$f $(BINDIR) ; \
-+		$(INSTALL) -s -m 755 $$f $(DESTDIR)$(BINDIR) ; \
++		$(INSTALL) -m 755 $$f $(DESTDIR)$(BINDIR) ; \
  	done
  #
  # make symlink for "g3topbm" (so third-party fax viewers won't fail)
@@ -449,12 +446,12 @@
  	@echo ""
 -	$(INSTALL) -m 700 vgetty/vgetty $(SBINDIR)
 -	$(INSTALL) -m 755 vm/vm $(BINDIR)
-+	$(INSTALL) -s -m 755 vgetty/vgetty $(DESTDIR)$(SBINDIR)
-+	$(INSTALL) -s -m 755 vm/vm $(DESTDIR)$(BINDIR)
++	$(INSTALL) -m 755 vgetty/vgetty $(DESTDIR)$(SBINDIR)
++	$(INSTALL) -m 755 vm/vm $(DESTDIR)$(BINDIR)
  	for i in $(PVFTOOLS); \
  	do \
 -	     $(INSTALL) -m 755 pvftools/$$i $(BINDIR); \
-+	     $(INSTALL) -s -m 755 pvftools/$$i $(DESTDIR)$(BINDIR); \
++	     $(INSTALL) -m 755 pvftools/$$i $(DESTDIR)$(BINDIR); \
  	done
 -	$(INSTALL) -m 644 man/man1/zplay.1 $(MAN1DIR)
 -	$(INSTALL) -m 644 man/man1/pvf.1 $(MAN1DIR)



++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++



Remember to have fun...

    

commit mgetty

root＠suse.de