Hello community, here is the log from the commit of package perl-XML-Writer for openSUSE:Factory checked in at 2014-02-28 17:46:26 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-XML-Writer (Old) and /work/SRC/openSUSE:Factory/.perl-XML-Writer.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "perl-XML-Writer" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-XML-Writer/perl-XML-Writer.changes 2013-07-30 19:11:27.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-XML-Writer.new/perl-XML-Writer.changes 2014-02-28 17:46:27.000000000 +0100 @@ -1,0 +2,6 @@ +Mon Feb 24 06:18:50 UTC 2014 - coolo@suse.com + +- updated to 0.624 + - Allow an empty system ID in a doctype declaration. + +------------------------------------------------------------------- Old: ---- XML-Writer-0.623.tar.gz New: ---- XML-Writer-0.624.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-XML-Writer.spec ++++++ --- /var/tmp/diff_new_pack.cV8fYE/_old 2014-02-28 17:46:28.000000000 +0100 +++ /var/tmp/diff_new_pack.cV8fYE/_new 2014-02-28 17:46:28.000000000 +0100 @@ -1,7 +1,7 @@ # # spec file for package perl-XML-Writer # -# Copyright (c) 2013 SUSE LINUX Products GmbH, Nuernberg, Germany. +# Copyright (c) 2014 SUSE LINUX Products GmbH, Nuernberg, Germany. # # All modifications and additions to the file contributed by third parties # remain the property of their copyright owners, unless otherwise agreed @@ -17,7 +17,7 @@ Name: perl-XML-Writer -Version: 0.623 +Version: 0.624 Release: 0 %define cpan_name XML-Writer Summary: Perl extension for writing XML documents. @@ -29,11 +29,6 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-build BuildRequires: perl BuildRequires: perl-macros -#BuildRequires: perl(Algorithm::Diff) -#BuildRequires: perl(DateTime) -#BuildRequires: perl(IO::Scalar) -#BuildRequires: perl(URI::URL) -#BuildRequires: perl(XML::Writer) %{perl_requires} %description ++++++ XML-Writer-0.623.tar.gz -> XML-Writer-0.624.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/XML-Writer-0.623/Changes new/XML-Writer-0.624/Changes --- old/XML-Writer-0.623/Changes 2013-06-13 15:32:44.000000000 +0200 +++ new/XML-Writer-0.624/Changes 2014-02-12 13:29:32.000000000 +0100 @@ -1,5 +1,8 @@ Revision history for Perl extension XML::Writer. +0.624 Wed Feb 12 23:28:39 2014 +1100 <joe@kafsemo.org> + - Allow an empty system ID in a doctype declaration. + 0.623 Thu Jun 13 23:29:52 2013 +1000 <joe@kafsemo.org> - Fix a memory leak introduced in 0.620. - Avoid issue with implicit stringification. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/XML-Writer-0.623/META.yml new/XML-Writer-0.624/META.yml --- old/XML-Writer-0.623/META.yml 2013-06-13 15:32:44.000000000 +0200 +++ new/XML-Writer-0.624/META.yml 2014-02-12 13:29:32.000000000 +0100 @@ -3,7 +3,7 @@ version: 1.4 url: http://module-build.sourceforge.net/META-spec-v1.4.html name: XML-Writer -version: 0.623 +version: 0.624 abstract: Easily generate well-formed, namespace-aware XML. author: - David Megginson <david@megginson.com> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/XML-Writer-0.623/Makefile.PL new/XML-Writer-0.624/Makefile.PL --- old/XML-Writer-0.623/Makefile.PL 2013-06-13 15:32:44.000000000 +0200 +++ new/XML-Writer-0.624/Makefile.PL 2014-02-12 13:29:32.000000000 +0100 @@ -7,7 +7,7 @@ # the contents of the Makefile that is written. WriteMakefile( 'NAME' => 'XML::Writer', - 'VERSION' => '0.623', + 'VERSION' => '0.624', # A manually-created META.yml has all the other metadata; # we don't want it overwritten diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/XML-Writer-0.623/Writer.pm new/XML-Writer-0.624/Writer.pm --- old/XML-Writer-0.623/Writer.pm 2013-06-13 15:32:44.000000000 +0200 +++ new/XML-Writer-0.624/Writer.pm 2014-02-12 13:29:32.000000000 +0100 @@ -15,7 +15,7 @@ use vars qw($VERSION); use Carp; use IO::Handle; -$VERSION = "0.623"; +$VERSION = "0.624"; use overload '""' => \&_overload_string; @@ -219,11 +219,11 @@ my ($name, $publicId, $systemId) = (@_); $output->print("<!DOCTYPE $name"); if ($publicId) { - unless ($systemId) { + unless ( defined $systemId) { croak("A DOCTYPE declaration with a public ID must also have a system ID"); } $output->print(" PUBLIC \"$publicId\" \"$systemId\""); - } elsif ($systemId) { + } elsif ( defined $systemId ) { $output->print(" SYSTEM \"$systemId\""); } $output->print(">\n"); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/XML-Writer-0.623/t/01_main.t new/XML-Writer-0.624/t/01_main.t --- old/XML-Writer-0.623/t/01_main.t 2013-06-13 15:32:44.000000000 +0200 +++ new/XML-Writer-0.624/t/01_main.t 2014-02-12 13:29:32.000000000 +0100 @@ -15,7 +15,7 @@ use Errno; -use Test::More(tests => 239); +use Test::More(tests => 242); # Catch warnings @@ -201,6 +201,27 @@ }); }; +# A document with a public identifier and an undefined system identifier +TEST: { + initEnv(); + expectError("A DOCTYPE declaration with a public ID must also have a system ID", eval { + $w->doctype('html', "-//W3C//DTD XHTML 1.1//EN", undef); + }); +}; + +# A document with a public identifier and an empty system identifier +TEST: { + initEnv(); + $w->doctype('html', "-//W3C//DTD XHTML 1.1//EN", + ""); + $w->emptyTag('html'); + $w->end(); + checkResult(<<"EOS", 'A document with a public and an empty system identifier'); +<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" ""> +<html /> +EOS +}; + # A document with only a system identifier set TEST: { initEnv(); -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org