Hello community, here is the log from the commit of package yast2-adcommon-python for openSUSE:Factory checked in at 2019-04-30 13:06:12 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-adcommon-python (Old) and /work/SRC/openSUSE:Factory/.yast2-adcommon-python.new.5536 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-adcommon-python" Tue Apr 30 13:06:12 2019 rev:2 rq:699397 version:0.3 Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-adcommon-python/yast2-adcommon-python.changes 2019-04-17 10:08:21.938779788 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-adcommon-python.new.5536/yast2-adcommon-python.changes 2019-04-30 13:06:15.829736557 +0200 @@ -1,0 +2,7 @@ +Fri Apr 26 21:23:38 UTC 2019 - dmulder@suse.com + +- yast2-adcommon-python ldap doesn't correctly parse ldap urls for + ldap.initialize(); (bsc#1133568); +- 0.3 + +------------------------------------------------------------------- Old: ---- yast2-adcommon-python-0.2.tar.bz2 New: ---- yast2-adcommon-python-0.3.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-adcommon-python.spec ++++++ --- /var/tmp/diff_new_pack.52DKzN/_old 2019-04-30 13:06:16.725722151 +0200 +++ /var/tmp/diff_new_pack.52DKzN/_new 2019-04-30 13:06:16.725722151 +0200 @@ -12,12 +12,12 @@ # license that conforms to the Open Source Definition (Version 1.9) # published by the Open Source Initiative. -# Please submit bugfixes or comments via https://bugs.opensuse.org/ +# Please submit bugfixes or comments via http://bugs.opensuse.org/ # Name: yast2-adcommon-python -Version: 0.2 +Version: 0.3 Release: 0 Summary: Common code for the yast python ad modules License: GPL-3.0-or-later ++++++ yast2-adcommon-python-0.2.tar.bz2 -> yast2-adcommon-python-0.3.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-adcommon-python-0.2/adcommon/yldap.py new/yast2-adcommon-python-0.3/adcommon/yldap.py --- old/yast2-adcommon-python-0.2/adcommon/yldap.py 2019-04-05 18:35:38.000000000 +0200 +++ new/yast2-adcommon-python-0.3/adcommon/yldap.py 2019-04-29 12:48:53.000000000 +0200 @@ -11,6 +11,7 @@ from adcommon.strings import strcmp import os import six +import ldapurl def y2error_dialog(msg): from yast import UI, Opt, HBox, HSpacing, VBox, VSpacing, Label, Right, PushButton, Id @@ -65,10 +66,11 @@ return data class Ldap: - def __init__(self, lp, creds): + def __init__(self, lp, creds, ldap_url=None): self.lp = lp self.creds = creds self.realm = lp.get('realm') + self.ldap_url = ldapurl.LDAPUrl(ldap_url) if ldap_url else None self.__ldap_connect() def __ldap_exc_msg(self, e): @@ -90,7 +92,9 @@ def __ldap_connect(self): self.dc_hostname = pdc_dns_name(self.realm) os.environ['KRB5_CONFIG'] = krb5_temp_conf(self.realm) - self.l = ldap.initialize('ldap://%s' % self.dc_hostname) + if not self.ldap_url: + self.ldap_url = ldapurl.LDAPUrl('ldap://%s' % self.dc_hostname) + self.l = ldap.initialize(self.ldap_url.initializeUrl()) if self.creds.get_kerberos_state() == MUST_USE_KERBEROS or kinit_for_gssapi(self.creds, self.realm): auth_tokens = ldap.sasl.gssapi('') self.l.sasl_interactive_bind_s('', auth_tokens) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-adcommon-python-0.2/package/yast2-adcommon-python.changes new/yast2-adcommon-python-0.3/package/yast2-adcommon-python.changes --- old/yast2-adcommon-python-0.2/package/yast2-adcommon-python.changes 2019-04-05 18:35:38.000000000 +0200 +++ new/yast2-adcommon-python-0.3/package/yast2-adcommon-python.changes 2019-04-29 12:48:53.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Fri Apr 26 21:23:38 UTC 2019 - dmulder@suse.com + +- yast2-adcommon-python ldap doesn't correctly parse ldap urls for + ldap.initialize(); (bsc#1133568); +- 0.3 + +------------------------------------------------------------------- Wed Mar 13 20:40:06 UTC 2019 - dmulder@suse.com - Update to 1.0: diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-adcommon-python-0.2/package/yast2-adcommon-python.spec new/yast2-adcommon-python-0.3/package/yast2-adcommon-python.spec --- old/yast2-adcommon-python-0.2/package/yast2-adcommon-python.spec 2019-04-05 18:35:38.000000000 +0200 +++ new/yast2-adcommon-python-0.3/package/yast2-adcommon-python.spec 2019-04-29 12:48:53.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-adcommon-python -Version: 0.2 +Version: 0.3 Release: 0 Summary: Common code for the yast python ad modules License: GPL-3.0+