Hello community, here is the log from the commit of package libyui-ncurses for openSUSE:Factory checked in at 2020-11-02 09:39:45 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libyui-ncurses (Old) and /work/SRC/openSUSE:Factory/.libyui-ncurses.new.3463 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "libyui-ncurses" Mon Nov 2 09:39:45 2020 rev:60 rq:844661 version:2.57.2 Changes: -------- --- /work/SRC/openSUSE:Factory/libyui-ncurses/libyui-ncurses.changes 2020-10-18 16:25:10.692591152 +0200 +++ /work/SRC/openSUSE:Factory/.libyui-ncurses.new.3463/libyui-ncurses.changes 2020-11-02 09:39:49.677577371 +0100 @@ -1,0 +2,7 @@ +Wed Oct 28 16:23:14 UTC 2020 - Stefan Hundhammer <shundhammer@suse.com> + +- Explicitly set item and line index in NCMultiSelectionBox and + NCSelectionBox (bsc#1177982, bsc#1177985) +- 2.57.2 + +------------------------------------------------------------------- Old: ---- libyui-ncurses-2.57.1.tar.bz2 New: ---- libyui-ncurses-2.57.2.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libyui-ncurses-doc.spec ++++++ --- /var/tmp/diff_new_pack.UQk4i8/_old 2020-11-02 09:39:50.169577843 +0100 +++ /var/tmp/diff_new_pack.UQk4i8/_new 2020-11-02 09:39:50.173577847 +0100 @@ -20,7 +20,7 @@ %define so_version 14 Name: %{parent}-doc -Version: 2.57.1 +Version: 2.57.2 Release: 0 Source: %{parent}-%{version}.tar.bz2 ++++++ libyui-ncurses.spec ++++++ --- /var/tmp/diff_new_pack.UQk4i8/_old 2020-11-02 09:39:50.193577866 +0100 +++ /var/tmp/diff_new_pack.UQk4i8/_new 2020-11-02 09:39:50.197577870 +0100 @@ -17,7 +17,7 @@ Name: libyui-ncurses -Version: 2.57.1 +Version: 2.57.2 Release: 0 Source: %{name}-%{version}.tar.bz2 ++++++ libyui-ncurses-2.57.1.tar.bz2 -> libyui-ncurses-2.57.2.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/VERSION.cmake new/libyui-ncurses-2.57.2/VERSION.cmake --- old/libyui-ncurses-2.57.1/VERSION.cmake 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/VERSION.cmake 2020-10-28 19:29:41.000000000 +0100 @@ -1,6 +1,6 @@ SET( VERSION_MAJOR "2" ) SET( VERSION_MINOR "57" ) -SET( VERSION_PATCH "1" ) +SET( VERSION_PATCH "2" ) SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}${GIT_SHA1_VERSION}" ) ##### This is needed for the libyui core ONLY. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/package/libyui-ncurses-doc.spec new/libyui-ncurses-2.57.2/package/libyui-ncurses-doc.spec --- old/libyui-ncurses-2.57.1/package/libyui-ncurses-doc.spec 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/package/libyui-ncurses-doc.spec 2020-10-28 19:29:41.000000000 +0100 @@ -19,7 +19,7 @@ %define so_version 14 Name: %{parent}-doc -Version: 2.57.1 +Version: 2.57.2 Release: 0 Source: %{parent}-%{version}.tar.bz2 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/package/libyui-ncurses.changes new/libyui-ncurses-2.57.2/package/libyui-ncurses.changes --- old/libyui-ncurses-2.57.1/package/libyui-ncurses.changes 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/package/libyui-ncurses.changes 2020-10-28 19:29:41.000000000 +0100 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Wed Oct 28 16:23:14 UTC 2020 - Stefan Hundhammer <shundhammer@suse.com> + +- Explicitly set item and line index in NCMultiSelectionBox and + NCSelectionBox (bsc#1177982, bsc#1177985) +- 2.57.2 + +------------------------------------------------------------------- Thu Oct 15 18:26:45 UTC 2020 - Stefan Hundhammer <shundhammer@suse.com> - Fixed menu hotkeys (bsc#1177760) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/package/libyui-ncurses.spec new/libyui-ncurses-2.57.2/package/libyui-ncurses.spec --- old/libyui-ncurses-2.57.1/package/libyui-ncurses.spec 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/package/libyui-ncurses.spec 2020-10-28 19:29:41.000000000 +0100 @@ -17,7 +17,7 @@ Name: libyui-ncurses -Version: 2.57.1 +Version: 2.57.2 Release: 0 Source: %{name}-%{version}.tar.bz2 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/src/NCMultiSelectionBox.cc new/libyui-ncurses-2.57.2/src/NCMultiSelectionBox.cc --- old/libyui-ncurses-2.57.1/src/NCMultiSelectionBox.cc 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/src/NCMultiSelectionBox.cc 2020-10-28 19:29:41.000000000 +0100 @@ -81,27 +81,28 @@ } - void NCMultiSelectionBox::setCurrentItem( YItem * item ) { if ( item ) myPad()->ScrlLine( item->index() ); } + void NCMultiSelectionBox::addItem( YItem * item ) { - std::vector<NCTableCol*> Items( 2U, 0 ); + std::vector<NCTableCol*> cells( 2U, 0 ); if ( item ) { + item->setIndex( itemsCount() ); YMultiSelectionBox::addItem( item ); - Items[0] = new NCTableTag( item, item->selected() ); + cells[0] = new NCTableTag( item, item->selected() ); // Do not set style to NCTableCol::PLAIN here, otherwise the current - //item will not be highlighted if the cursor is not over the widget + // item will not be highlighted if the cursor is not over the widget - Items[1] = new NCTableCol( item->label() ); - myPad()->Append( Items ); + cells[1] = new NCTableCol( item->label() ); + myPad()->Append( cells, item->index() ); DrawPad(); } } @@ -133,7 +134,6 @@ } - void NCMultiSelectionBox::deleteAllItems() { YMultiSelectionBox::deleteAllItems(); @@ -157,11 +157,11 @@ { YMultiSelectionBox::selectItem( yitem, selected ); - //retrieve pointer to the line tag associated with this item - NCTableTag * tag = ( NCTableTag * )yitem->data(); + // retrieve pointer to the line tag associated with this item + NCTableTag * tag = (NCTableTag *) yitem->data(); YUI_CHECK_PTR( tag ); - tag->SetSelected( selected ); + tag->SetSelected( selected ); DrawPad(); } @@ -177,7 +177,7 @@ NCTableTag *t = tagCell( i ); YUI_CHECK_PTR( t ); - t->SetSelected( false ); + t->SetSelected( false ); } DrawPad(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/src/NCSelectionBox.cc new/libyui-ncurses-2.57.2/src/NCSelectionBox.cc --- old/libyui-ncurses-2.57.1/src/NCSelectionBox.cc 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/src/NCSelectionBox.cc 2020-10-28 19:29:41.000000000 +0100 @@ -142,13 +142,14 @@ void NCSelectionBox::addItem( YItem * item ) { - std::vector<NCTableCol*> Items( 1U, 0 ); + std::vector<NCTableCol*> cells( 1U, 0 ); if ( item ) { + item->setIndex( itemsCount() ); YSelectionBox::addItem( item ); - Items[0] = new NCTableCol( item->label() ); - myPad()->Append( Items ); + cells[0] = new NCTableCol( item->label() ); + myPad()->Append( cells, item->index() ); DrawPad(); if ( item->selected() ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.57.1/src/NCTablePadBase.h new/libyui-ncurses-2.57.2/src/NCTablePadBase.h --- old/libyui-ncurses-2.57.1/src/NCTablePadBase.h 2020-10-16 16:09:16.000000000 +0200 +++ new/libyui-ncurses-2.57.2/src/NCTablePadBase.h 2020-10-28 19:29:41.000000000 +0100 @@ -149,7 +149,7 @@ /** * Create a new item from 'cells' and add it to the end of _items. **/ - void Append( std::vector<NCTableCol*> & cells, int index = -1 ) + void Append( std::vector<NCTableCol*> & cells, int index ) { AddLine( Lines(), new NCTableLine( cells, index ) ); } /**