Hello community, here is the log from the commit of package kitemmodels for openSUSE:Factory checked in at 2018-12-19 13:42:01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/kitemmodels (Old) and /work/SRC/openSUSE:Factory/.kitemmodels.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "kitemmodels" Wed Dec 19 13:42:01 2018 rev:60 rq:658574 version:5.53.0 Changes: -------- --- /work/SRC/openSUSE:Factory/kitemmodels/kitemmodels.changes 2018-11-14 14:35:41.791191205 +0100 +++ /work/SRC/openSUSE:Factory/.kitemmodels.new.28833/kitemmodels.changes 2018-12-19 13:42:02.739903410 +0100 @@ -1,0 +2,13 @@ +Sun Dec 09 19:43:44 UTC 2018 - lbeltrame@kde.org + +- Update to 5.53.0 + * New feature release + * For more details please see: + * https://www.kde.org/announcements/kde-frameworks-5.53.0.php +- Changes since 5.52.0: + * autotests: remove testmodelqueuedconnections.cpp which asserts in Qt 5.11 + * Use isEmpty() + * Remove unused virtual keyword + * Normalize signal/slot + +------------------------------------------------------------------- Old: ---- kitemmodels-5.52.0.tar.xz New: ---- kitemmodels-5.53.0.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ kitemmodels.spec ++++++ --- /var/tmp/diff_new_pack.Gd3wpQ/_old 2018-12-19 13:42:03.359902537 +0100 +++ /var/tmp/diff_new_pack.Gd3wpQ/_new 2018-12-19 13:42:03.363902531 +0100 @@ -18,14 +18,14 @@ %define clang_sonum 3.8 %define lname libKF5ItemModels5 -%define _tar_path 5.52 +%define _tar_path 5.53 # Full KF5 version (e.g. 5.33.0) %{!?_kf5_version: %global _kf5_version %{version}} # Last major and minor KF5 version (e.g. 5.33) %{!?_kf5_bugfix_version: %define _kf5_bugfix_version %(echo %{_kf5_version} | awk -F. '{print $1"."$2}')} %bcond_with python Name: kitemmodels -Version: 5.52.0 +Version: 5.53.0 Release: 0 Summary: Set of item models extending the Qt model-view framework License: LGPL-2.1-or-later ++++++ kitemmodels-5.52.0.tar.xz -> kitemmodels-5.53.0.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/CMakeLists.txt new/kitemmodels-5.53.0/CMakeLists.txt --- old/kitemmodels-5.52.0/CMakeLists.txt 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/CMakeLists.txt 2018-12-01 15:40:33.000000000 +0100 @@ -1,10 +1,10 @@ cmake_minimum_required(VERSION 3.0) -set(KF5_VERSION "5.52.0") # handled by release scripts +set(KF5_VERSION "5.53.0") # handled by release scripts project(KItemModels VERSION ${KF5_VERSION}) include(FeatureSummary) -find_package(ECM 5.52.0 NO_MODULE) +find_package(ECM 5.53.0 NO_MODULE) set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL "https://projects.kde.org/projects/kdesupport/extra-cmake-modules") feature_summary(WHAT REQUIRED_PACKAGES_NOT_FOUND FATAL_ON_MISSING_REQUIRED_PACKAGES) @@ -16,7 +16,7 @@ include(KDECMakeSettings) include(ECMQtDeclareLoggingCategory) -set(REQUIRED_QT_VERSION 5.8.0) +set(REQUIRED_QT_VERSION 5.9.0) find_package(Qt5Core ${REQUIRED_QT_VERSION} REQUIRED NO_MODULE) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/autotests/CMakeLists.txt new/kitemmodels-5.53.0/autotests/CMakeLists.txt --- old/kitemmodels-5.52.0/autotests/CMakeLists.txt 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/autotests/CMakeLists.txt 2018-12-01 15:40:33.000000000 +0100 @@ -20,7 +20,6 @@ kdescendantsproxymodeltest.cpp kextracolumnsproxymodeltest.cpp klinkitemselectionmodeltest.cpp - testmodelqueuedconnections.cpp kselectionproxymodeltest.cpp kmodelindexproxymappertest.cpp krecursivefilterproxymodeltest.cpp diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/autotests/krecursivefilterproxymodeltest.cpp new/kitemmodels-5.53.0/autotests/krecursivefilterproxymodeltest.cpp --- old/kitemmodels-5.52.0/autotests/krecursivefilterproxymodeltest.cpp 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/autotests/krecursivefilterproxymodeltest.cpp 2018-12-01 15:40:33.000000000 +0100 @@ -30,11 +30,11 @@ Q_OBJECT public: explicit ModelSignalSpy(QAbstractItemModel &model) { - connect(&model, SIGNAL(rowsInserted(QModelIndex, int, int)), this, SLOT(onRowsInserted(QModelIndex,int,int))); - connect(&model, SIGNAL(rowsRemoved(QModelIndex, int, int)), this, SLOT(onRowsRemoved(QModelIndex,int,int))); - connect(&model, SIGNAL(rowsAboutToBeInserted(QModelIndex, int, int)), this, SLOT(onRowsAboutToBeInserted(QModelIndex,int,int))); - connect(&model, SIGNAL(rowsAboutToBeRemoved(QModelIndex, int, int)), this, SLOT(onRowsAboutToBeRemoved(QModelIndex,int,int))); - connect(&model, SIGNAL(rowsMoved(QModelIndex, int, int, QModelIndex, int)), this, SLOT(onRowsMoved(QModelIndex,int,int, QModelIndex, int))); + connect(&model, SIGNAL(rowsInserted(QModelIndex,int,int)), this, SLOT(onRowsInserted(QModelIndex,int,int))); + connect(&model, SIGNAL(rowsRemoved(QModelIndex,int,int)), this, SLOT(onRowsRemoved(QModelIndex,int,int))); + connect(&model, SIGNAL(rowsAboutToBeInserted(QModelIndex,int,int)), this, SLOT(onRowsAboutToBeInserted(QModelIndex,int,int))); + connect(&model, SIGNAL(rowsAboutToBeRemoved(QModelIndex,int,int)), this, SLOT(onRowsAboutToBeRemoved(QModelIndex,int,int))); + connect(&model, SIGNAL(rowsMoved(QModelIndex,int,int,QModelIndex,int)), this, SLOT(onRowsMoved(QModelIndex,int,int,QModelIndex,int))); connect(&model, SIGNAL(dataChanged(QModelIndex,QModelIndex)), this, SLOT(onDataChanged(QModelIndex,QModelIndex))); connect(&model, SIGNAL(layoutChanged()), this, SLOT(onLayoutChanged())); connect(&model, SIGNAL(modelReset()), this, SLOT(onModelReset())); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/autotests/kselectionproxymodeltestsuite.h new/kitemmodels-5.53.0/autotests/kselectionproxymodeltestsuite.h --- old/kitemmodels-5.52.0/autotests/kselectionproxymodeltestsuite.h 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/autotests/kselectionproxymodeltestsuite.h 2018-12-01 15:40:33.000000000 +0100 @@ -44,7 +44,7 @@ } protected: - /* reimp */ QAbstractProxyModel *getProxy() override + QAbstractProxyModel *getProxy() override { Q_ASSERT(sourceModel()); m_selectionModel = new QItemSelectionModel(sourceModel()); @@ -94,58 +94,58 @@ SelectorStrategy::setProperty("filterBehaviour", QVariant(int(_filterBehaviour))); } - /* reimp */ void testInsertWhenEmptyData() override + void testInsertWhenEmptyData() override { SelectorStrategy::testInsertWhenEmptyData(); } - /* reimp */ void testInsertInRootData() override + void testInsertInRootData() override { SelectorStrategy::testInsertInRootData(); } - /* reimp */ void testInsertInTopLevelData() override + void testInsertInTopLevelData() override { SelectorStrategy::testInsertInTopLevelData(); } - /* reimp */ void testInsertInSecondLevelData() override + void testInsertInSecondLevelData() override { SelectorStrategy::testInsertInSecondLevelData(); } - /* reimp */ void testRemoveFromRootData() override + void testRemoveFromRootData() override { SelectorStrategy::testRemoveFromRootData(); } - /* reimp */ void testRemoveFromTopLevelData() override + void testRemoveFromTopLevelData() override { SelectorStrategy::testRemoveFromTopLevelData(); } - /* reimp */ void testRemoveFromSecondLevelData() override + void testRemoveFromSecondLevelData() override { SelectorStrategy::testRemoveFromSecondLevelData(); } - /* reimp */ void testMoveFromRootData() override + void testMoveFromRootData() override { SelectorStrategy::testMoveFromRootData(); } - /* reimp */ void testMoveFromTopLevelData() override + void testMoveFromTopLevelData() override { SelectorStrategy::testMoveFromTopLevelData(); } - /* reimp */ void testMoveFromSecondLevelData() override + void testMoveFromSecondLevelData() override { SelectorStrategy::testMoveFromSecondLevelData(); } - /* reimp */ void testModifyInRootData() override + void testModifyInRootData() override { SelectorStrategy::testModifyInRootData(); } - /* reimp */ void testModifyInTopLevelData() override + void testModifyInTopLevelData() override { SelectorStrategy::testModifyInTopLevelData(); } - /* reimp */ void testModifyInSecondLevelData() override + void testModifyInSecondLevelData() override { SelectorStrategy::testModifyInSecondLevelData(); } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/autotests/proxymodeltestsuite/dynamictreemodel.cpp new/kitemmodels-5.53.0/autotests/proxymodeltestsuite/dynamictreemodel.cpp --- old/kitemmodels-5.52.0/autotests/proxymodeltestsuite/dynamictreemodel.cpp 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/autotests/proxymodeltestsuite/dynamictreemodel.cpp 2018-12-01 15:40:33.000000000 +0100 @@ -599,7 +599,7 @@ { QList<QList<qint64> > childItemRows = m_model->m_childItems.value(parent); - if (childItemRows.size() > 0) { + if (!childItemRows.isEmpty()) { for (int col = 0; col < m_numCols; col++) { QList<qint64> childItems = childItemRows[col]; Q_FOREACH (qint64 item, childItems) { @@ -681,7 +681,7 @@ { QList<QList<qint64> > childItemRows = m_model->m_childItems.value(parent); - if (childItemRows.size() > 0) { + if (!childItemRows.isEmpty()) { for (int col = 0; col < m_numCols; col++) { QList<qint64> childItems = childItemRows[col]; Q_FOREACH (qint64 item, childItems) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/autotests/testmodelqueuedconnections.cpp new/kitemmodels-5.53.0/autotests/testmodelqueuedconnections.cpp --- old/kitemmodels-5.52.0/autotests/testmodelqueuedconnections.cpp 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/autotests/testmodelqueuedconnections.cpp 1970-01-01 01:00:00.000000000 +0100 @@ -1,79 +0,0 @@ -/* - Copyright (c) 2009 Stephen Kelly <steveire@gmail.com> - - This library is free software; you can redistribute it and/or modify it - under the terms of the GNU Library General Public License as published by - the Free Software Foundation; either version 2 of the License, or (at your - option) any later version. - - This library is distributed in the hope that it will be useful, but WITHOUT - ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or - FITNESS FOR A PARTICULAR PURPOSE. See the GNU Library General Public - License for more details. - - You should have received a copy of the GNU Library General Public License - along with this library; see the file COPYING.LIB. If not, write to the - Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA - 02110-1301, USA. -*/ - -#include <QObject> -#include <QtTest> -#include <QtCore> -#include <qtestevent.h> - -#include <QEventLoop> - -#include "dynamictreemodel.h" - -class ModelQueuedConnectionsTest : public QObject -{ - Q_OBJECT -public Q_SLOTS: - void rowsInserted(const QModelIndex &parent, int start, int end) - { - QModelIndex idx; - const int column = 0; - for (int row = start; row <= end; ++row) { - idx = m_rootModel->index(row, column, parent); - qDebug() << idx << idx.data(); - QEXPECT_FAIL("", "Can't use Queued connections with models", Continue); - QVERIFY(idx.isValid()); - } - - m_eventLoop->exit(); - - } - -private Q_SLOTS: - - void initTestCase() - { - m_rootModel = new DynamicTreeModel(this); - m_eventLoop = new QEventLoop(this); - } - - void testInsertAndRemove() - { - ModelInsertAndRemoveQueuedCommand *insAndRem = new ModelInsertAndRemoveQueuedCommand(m_rootModel, this); - - connect(m_rootModel, SIGNAL(rowsInserted(QModelIndex,int,int)), - SLOT(rowsInserted(QModelIndex,int,int))); - - insAndRem->setStartRow(0); - insAndRem->setEndRow(9); - insAndRem->doCommand(); - - m_eventLoop->exec(); - - } - -private: - DynamicTreeModel *m_rootModel; - QEventLoop *m_eventLoop; - -}; - -QTEST_MAIN(ModelQueuedConnectionsTest) -#include "testmodelqueuedconnections.moc" - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/src/kbreadcrumbselectionmodel.h new/kitemmodels-5.53.0/src/kbreadcrumbselectionmodel.h --- old/kitemmodels-5.52.0/src/kbreadcrumbselectionmodel.h 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/src/kbreadcrumbselectionmodel.h 2018-12-01 15:40:33.000000000 +0100 @@ -144,9 +144,9 @@ */ void setBreadcrumbLength(int breadcrumbLength); - /* reimp */ void select(const QModelIndex &index, QItemSelectionModel::SelectionFlags command) override; + void select(const QModelIndex &index, QItemSelectionModel::SelectionFlags command) override; - /* reimp */ void select(const QItemSelection &selection, QItemSelectionModel::SelectionFlags command) override; + void select(const QItemSelection &selection, QItemSelectionModel::SelectionFlags command) override; protected: KBreadcrumbSelectionModelPrivate *const d_ptr; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/src/kcheckableproxymodel.h new/kitemmodels-5.53.0/src/kcheckableproxymodel.h --- old/kitemmodels-5.52.0/src/kcheckableproxymodel.h 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/src/kcheckableproxymodel.h 2018-12-01 15:40:33.000000000 +0100 @@ -73,13 +73,13 @@ void setSelectionModel(QItemSelectionModel *itemSelectionModel); QItemSelectionModel *selectionModel() const; - /* reimp */ Qt::ItemFlags flags(const QModelIndex &index) const override; + Qt::ItemFlags flags(const QModelIndex &index) const override; - /* reimp */ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; + QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; - /* reimp */ bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) override; + bool setData(const QModelIndex &index, const QVariant &value, int role = Qt::EditRole) override; - /* reimp */ void setSourceModel(QAbstractItemModel *sourceModel) override; + void setSourceModel(QAbstractItemModel *sourceModel) override; protected: virtual bool select(const QItemSelection &selection, QItemSelectionModel::SelectionFlags command); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/src/kconcatenaterowsproxymodel.cpp new/kitemmodels-5.53.0/src/kconcatenaterowsproxymodel.cpp --- old/kitemmodels-5.52.0/src/kconcatenaterowsproxymodel.cpp 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/src/kconcatenaterowsproxymodel.cpp 2018-12-01 15:40:33.000000000 +0100 @@ -195,10 +195,10 @@ connect(sourceModel, SIGNAL(columnsAboutToBeInserted(QModelIndex,int,int)), this, SLOT(slotColumnsAboutToBeInserted(QModelIndex,int,int))); connect(sourceModel, SIGNAL(columnsAboutToBeRemoved(QModelIndex,int,int)), this, SLOT(slotColumnsAboutToBeRemoved(QModelIndex,int,int))); - connect(sourceModel, SIGNAL(layoutAboutToBeChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint)), - this, SLOT(slotSourceLayoutAboutToBeChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint))); - connect(sourceModel, SIGNAL(layoutChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint)), - this, SLOT(slotSourceLayoutChanged(QList<QPersistentModelIndex>, QAbstractItemModel::LayoutChangeHint))); + connect(sourceModel, SIGNAL(layoutAboutToBeChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)), + this, SLOT(slotSourceLayoutAboutToBeChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint))); + connect(sourceModel, SIGNAL(layoutChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint)), + this, SLOT(slotSourceLayoutChanged(QList<QPersistentModelIndex>,QAbstractItemModel::LayoutChangeHint))); connect(sourceModel, SIGNAL(modelAboutToBeReset()), this, SLOT(slotModelAboutToBeReset())); connect(sourceModel, SIGNAL(modelReset()), this, SLOT(slotModelReset())); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/tests/proxymodeltestapp/lessthanwidget.h new/kitemmodels-5.53.0/tests/proxymodeltestapp/lessthanwidget.h --- old/kitemmodels-5.52.0/tests/proxymodeltestapp/lessthanwidget.h 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/tests/proxymodeltestapp/lessthanwidget.h 2018-12-01 15:40:33.000000000 +0100 @@ -33,7 +33,7 @@ public: ColoredTreeModel(QObject *parent = nullptr); - /* reimp */ QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; + QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override; void setSelectionModel(QItemSelectionModel *selectionModel); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/tests/proxymodeltestapp/recursivefilterpmwidget.h new/kitemmodels-5.53.0/tests/proxymodeltestapp/recursivefilterpmwidget.h --- old/kitemmodels-5.52.0/tests/proxymodeltestapp/recursivefilterpmwidget.h 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/tests/proxymodeltestapp/recursivefilterpmwidget.h 2018-12-01 15:40:33.000000000 +0100 @@ -44,7 +44,7 @@ } - /* reimp */ bool acceptRow(int sourceRow, const QModelIndex &parent_index) const override + bool acceptRow(int sourceRow, const QModelIndex &parent_index) const override { static const int column = 0; QModelIndex srcIndex = sourceModel()->index(sourceRow, column, parent_index); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/kitemmodels-5.52.0/tests/proxymodeltestapp/scriptablereparentingwidget.h new/kitemmodels-5.53.0/tests/proxymodeltestapp/scriptablereparentingwidget.h --- old/kitemmodels-5.52.0/tests/proxymodeltestapp/scriptablereparentingwidget.h 2018-11-03 13:01:01.000000000 +0100 +++ new/kitemmodels-5.53.0/tests/proxymodeltestapp/scriptablereparentingwidget.h 2018-12-01 15:40:33.000000000 +0100 @@ -36,7 +36,7 @@ public: ScriptableReparentingProxyModel(QObject *parent = nullptr); - /* reimp */ bool isDescendantOf(const QModelIndex &ancestor, const QModelIndex &descendant) const override; + bool isDescendantOf(const QModelIndex &ancestor, const QModelIndex &descendant) const override; void setImplementation(const QString &implementation);