Hello community,
here is the log from the commit of package skiboot for openSUSE:Factory checked in at 2016-01-05 21:54:35
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Comparing /work/SRC/openSUSE:Factory/skiboot (Old)
and /work/SRC/openSUSE:Factory/.skiboot.new (New)
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Package is "skiboot"
Changes:
--------
--- /work/SRC/openSUSE:Factory/skiboot/skiboot.changes 2015-11-11 10:30:09.000000000 +0100
+++ /work/SRC/openSUSE:Factory/.skiboot.new/skiboot.changes 2016-01-05 21:55:00.000000000 +0100
@@ -1,0 +2,24 @@
+Sat Jan 2 10:08:58 UTC 2016 - mpluskal@suse.com
+
+- Update to 5.1.12
+ * opal-prd:
+ + Display an explict and obvious message if running on a
+ system that does not support opal-prd, such as an IBM FSP
+ based POWER system, where the FSP takes on the role of
+ opal-prd.
+ * pflash:
+ + Fix a missing (C) header
+ + cherry-picked from master.
+ * General:
+ + Don't link with libgcc
+ + On some toolchains, we don't have libgcc available.
+ * POWER8 PHB (PCIe) specific:
+ + hw/phb3: Flush cache line after updating P/Q bits
+ + When doing an MSI EOI, we update the P and Q bits in the
+ IVE.
+ * IBM FSP based machines:
+ + FSP: Give up PSI link on shutdown This clears up some
+ erroneous SRCs (error logs) in some situations.
+ + Correctly report back Real Time Clock errors to host.
+
+-------------------------------------------------------------------
Old:
----
skiboot-5.1.8.tar.gz
New:
----
skiboot-5.1.12.tar.gz
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Other differences:
------------------
++++++ skiboot.spec ++++++
--- /var/tmp/diff_new_pack.nO7LD3/_old 2016-01-05 21:55:01.000000000 +0100
+++ /var/tmp/diff_new_pack.nO7LD3/_new 2016-01-05 21:55:01.000000000 +0100
@@ -1,7 +1,7 @@
#
# spec file for package skiboot
#
-# Copyright (c) 2015 SUSE LINUX GmbH, Nuernberg, Germany.
+# Copyright (c) 2016 SUSE LINUX GmbH, Nuernberg, Germany.
#
# All modifications and additions to the file contributed by third parties
# remain the property of their copyright owners, unless otherwise agreed
@@ -17,7 +17,7 @@
Name: skiboot
-Version: 5.1.8
+Version: 5.1.12
Release: 0
Summary: Tools for OpenPower platform
License: Apache-2.0
@@ -28,8 +28,8 @@
Source2: opal-prd.socket
BuildRequires: linux-glibc-devel
BuildRequires: systemd-rpm-macros
-%{?systemd_requires}
BuildRoot: %{_tmppath}/%{name}-%{version}-build
+%{?systemd_requires}
ExclusiveArch: ppc64 ppc64le
%description
@@ -63,11 +63,11 @@
make %{?_smp_mflags} -C external/gard/
%install
-make install DESTDIR=%{buildroot} %{?_smp_mflags} -C external/opal-prd/ prefix=/usr install
-make install DESTDIR=%{buildroot} %{?_smp_mflags} -C external/gard/ prefix=/usr install
+make install DESTDIR=%{buildroot} %{?_smp_mflags} -C external/opal-prd/ prefix=%{_prefix} install
+make install DESTDIR=%{buildroot} %{?_smp_mflags} -C external/gard/ prefix=%{_prefix} install
mkdir -p %{buildroot}/%{_unitdir}
-%__install -D -m 444 %{S:1} %{S:2} %{buildroot}%{_unitdir}/
+install -D -m 444 %{SOURCE1} %{SOURCE2} %{buildroot}%{_unitdir}/
%pre -n opal-prd
%service_add_pre opal-prd.service opal-prd.socket
@@ -85,7 +85,7 @@
%defattr(-,root,root)
%doc README
%{_sbindir}/opal-prd
-%{_datadir}/man/man8/opal-prd.8.gz
+%{_mandir}/man8/opal-prd.8.gz
%{_unitdir}/opal-prd.service
%{_unitdir}/opal-prd.socket
@@ -93,6 +93,6 @@
%defattr(-,root,root)
%doc README
%{_sbindir}/opal-gard
-%{_datadir}/man/man1/opal-gard.1.gz
+%{_mandir}/man1/opal-gard.1.gz
%changelog
++++++ skiboot-5.1.8.tar.gz -> skiboot-5.1.12.tar.gz ++++++
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/Makefile.main new/skiboot-skiboot-5.1.12/Makefile.main
--- old/skiboot-skiboot-5.1.8/Makefile.main 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/Makefile.main 2015-12-04 05:45:07.000000000 +0100
@@ -157,7 +157,6 @@
endif
OBJS += $(LIBC) $(CCAN) $(DEVSRC_OBJ)
OBJS_NO_VER = $(OBJS)
-EXTRA_LIBS = -Wl,-lgcc
ALL_OBJS = $(OBJS) version.o
ALL_OBJS_1 = $(ALL_OBJS) asm/dummy_map.o
@@ -167,12 +166,12 @@
$(call Q,OBJCOPY, $(OBJCOPY) -O binary -S $^ $@, $@)
$(TARGET).tmp.elf: $(ALL_OBJS_1) $(TARGET).lds $(KERNEL)
- $(call Q,LD, $(CC) $(LDFLAGS) -T $(TARGET).lds $(ALL_OBJS_1) $(EXTRA_LIBS) -o $@, $@)
+ $(call Q,LD, $(CC) $(LDFLAGS) -T $(TARGET).lds $(ALL_OBJS_1) -o $@, $@)
asm/real_map.o : $(TARGET).tmp.map
$(TARGET).elf: $(ALL_OBJS_2) $(TARGET).lds $(KERNEL)
- $(call Q,LD, $(CC) $(LDFLAGS) -T $(TARGET).lds $(ALL_OBJS_2) $(EXTRA_LIBS) -o $@, $@)
+ $(call Q,LD, $(CC) $(LDFLAGS) -T $(TARGET).lds $(ALL_OBJS_2) -o $@, $@)
$(SUBDIRS):
$(call Q,MKDIR,mkdir $@, $@)
@@ -204,8 +203,8 @@
extract-gcov: extract-gcov.c
$(call Q, HOSTCC ,$(HOSTCC) $(HOSTCFLAGS) \
-DTARGET__GNUC__=`echo '__GNUC__'|$(CC) -E -|grep -v '^#'` \
- -DTARGET__GNUC_MINOR__=`echo '__GNUC__'|$(CC) -E -|grep -v '^#'` \
- -O0 -g -I$(SRC) -o $@ $<,$<)
+ -DTARGET__GNUC_MINOR__=`echo '__GNUC_MINOR__'|$(CC) -E -|grep -v '^#'` \
+ -Wpadded -O0 -g -I$(SRC) -o $@ $<,$<)
coverage-report: skiboot.info
genhtml --branch-coverage -q -o $@ $<
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/core/console.c new/skiboot-skiboot-5.1.12/core/console.c
--- old/skiboot-skiboot-5.1.8/core/console.c 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/core/console.c 2015-12-04 05:45:07.000000000 +0100
@@ -290,6 +290,12 @@
return count;
}
+void flush_console_driver(void)
+{
+ if (con_driver && con_driver->flush != NULL)
+ con_driver->flush();
+}
+
void set_console(struct con_ops *driver)
{
con_driver = driver;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/core/hmi.c new/skiboot-skiboot-5.1.12/core/hmi.c
--- old/skiboot-skiboot-5.1.8/core/hmi.c 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/core/hmi.c 2015-12-04 05:45:07.000000000 +0100
@@ -406,6 +406,17 @@
hmi_evt->u.xstop_error.xstop_reason
|= nx_pbi_xstop_bits[i].reason;
+ /*
+ * Set NXDMAENGFIR[38] to signal PRD that service action is required.
+ * Without this inject, PRD will not be able to do NX unit checkstop
+ * error analysis. NXDMAENGFIR[38] is a spare bit and used to report
+ * a software initiated attention.
+ *
+ * The behavior of this bit and all FIR bits are documented in
+ * RAS spreadsheet.
+ */
+ xscom_write(flat_chip_id, NX_DMA_ENGINE_FIR, PPC_BIT(38));
+
/* Send an HMI event. */
queue_hmi_event(hmi_evt, 0);
*event_generated = 1;
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/core/platform.c new/skiboot-skiboot-5.1.12/core/platform.c
--- old/skiboot-skiboot-5.1.8/core/platform.c 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/core/platform.c 2015-12-04 05:45:07.000000000 +0100
@@ -37,6 +37,8 @@
{
printf("OPAL: Shutdown request type 0x%llx...\n", request);
+ flush_console_driver();
+
if (platform.cec_power_down)
return platform.cec_power_down(request);
@@ -48,6 +50,8 @@
{
printf("OPAL: Reboot request...\n");
+ flush_console_driver();
+
#ifdef ENABLE_FAST_RESET
/* Try a fast reset first */
fast_reset();
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/core/sensor.c new/skiboot-skiboot-5.1.12/core/sensor.c
--- old/skiboot-skiboot-5.1.8/core/sensor.c 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/core/sensor.c 2015-12-04 05:45:07.000000000 +0100
@@ -39,6 +39,7 @@
{
sensor_node = dt_new(opal_node, "sensors");
+ dt_add_property_string(sensor_node, "compatible", "ibm,opal-sensor");
dts_sensor_create_nodes(sensor_node);
/* Register OPAL interface */
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.10.txt new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.10.txt
--- old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.10.txt 1970-01-01 01:00:00.000000000 +0100
+++ new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.10.txt 2015-12-04 05:45:07.000000000 +0100
@@ -0,0 +1,34 @@
+skiboot-5.1.10
+--------------
+
+skiboot-5.1.10 was released on Friday November 13th, 2015.
+
+skiboot-5.1.10 is the 11th stable release of 5.1, it follows skiboot-5.1.9
+(which was released October 30th, 2015).
+
+Skiboot 5.1.10 contains all fixes from skiboot-5.1.9 and is a minor bug
+fix release.
+
+Over skiboot-5.1.9, we have the following change:
+
+IBM FSP machines:
+- FSP: Handle Delayed Power Off initiated CEC shutdown with FSP in Reset/Reload
+
+ In a scenario where the DPO has been initiated, but the FSP then went into
+ reset before the CEC power down came in, OPAL may not give up the link since
+ it may never see the PSI interrupt. So, if we are in dpo_pending and an FSP
+ reset is detected via the DISR, give up the PSI link voluntarily.
+
+Generic:
+- sensor: add a compatible property
+ OPAL needs an extra compatible property "ibm,opal-sensor" to make
+ module autoload work smoothly in Linux for ibmpowernv driver.
+- console: Completely flush output buffer before power down and reboot
+ Completely flush the output buffer of the console driver before
+ power down and reboot. Implements the flushing function for uart
+ consoles, which includes the astbmc and rhesus platforms.
+
+ This fixes an issue where some console output is sometimes lost before
+ power down or reboot in uart consoles. If this issue is also prevalent
+ in other console types then it can be fixed later by adding a .flush
+ to that driver's con_ops.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.11.txt new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.11.txt
--- old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.11.txt 1970-01-01 01:00:00.000000000 +0100
+++ new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.11.txt 2015-12-04 05:45:07.000000000 +0100
@@ -0,0 +1,16 @@
+skiboot-5.1.11
+--------------
+
+skiboot-5.1.11 was released on Friday November 13th, 2015.
+
+Since it was Friday 13th, we had to find a bug right after we tagged
+and released skiboot-5.1.10.
+
+skiboot-5.1.11 is the 12th stable release of 5.1, it follows skiboot-5.1.10
+(which was released November 13th, 2015).
+
+Skiboot 5.1.11 contains one additional bug fix over skiboot-5.1.10.
+
+It is:
+- On IBM FSP machines, if IPMI/Serial console is not connected during shutdown
+ or reboot, machine would enter termination state rather than shut down.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.12.txt new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.12.txt
--- old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.12.txt 1970-01-01 01:00:00.000000000 +0100
+++ new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.12.txt 2015-12-04 05:45:07.000000000 +0100
@@ -0,0 +1,44 @@
+skiboot-5.1.12
+--------------
+
+skiboot-5.1.12 was released on Friday December 4th, 2015.
+
+skiboot-5.1.12 is the 13th stable release of 5.1, it follows skiboot-5.1.11
+(which was released November 13th, 2015).
+
+Skiboot 5.1.12 contains bug fixes and a performance improvement.
+
+opal-prd:
+- Display an explict and obvious message if running on a system that does
+ not support opal-prd, such as an IBM FSP based POWER system, where the
+ FSP takes on the role of opal-prd.
+
+pflash:
+- Fix a missing (C) header
+ - cherry-picked from master.
+
+General:
+- Don't link with libgcc
+ - On some toolchains, we don't have libgcc available.
+
+POWER8 PHB (PCIe) specific:
+- hw/phb3: Flush cache line after updating P/Q bits
+ When doing an MSI EOI, we update the P and Q bits in the IVE. That causes
+ the corresponding cache line to be dirty in the L3 which will cause a
+ subsequent update by the PHB (upon recieving the next MSI) to get a few
+ retries until it gets flushed.
+
+ We improve the situation (and thus performance) by doing a dcbf
+ instruction to force a flush of the update we do in SW.
+
+ This improves interrupt performance, reducing latency per interrupt.
+ The improvement will vary by workload.
+
+IBM FSP based machines:
+- FSP: Give up PSI link on shutdown
+ This clears up some erroneous SRCs (error logs) in some situations.
+- Correctly report back Real Time Clock errors to host
+ Under certain rare error conditions, we could return an error code
+ to the host OS that would cause current Linux kernels to get stuck
+ in an infinite loop during boot.
+ This was introduced in skiboot-5.0-rc1.
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.9.txt new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.9.txt
--- old/skiboot-skiboot-5.1.8/doc/release-notes/skiboot-5.1.9.txt 1970-01-01 01:00:00.000000000 +0100
+++ new/skiboot-skiboot-5.1.12/doc/release-notes/skiboot-5.1.9.txt 2015-12-04 05:45:07.000000000 +0100
@@ -0,0 +1,16 @@
+skiboot-5.1.9
+-------------
+
+skiboot-5.1.9 was released on October 30th, 2015.
+
+skiboot-5.1.9 is the 10th stable release of 5.1, it follows skiboot-5.1.8
+(which was released October 19th, 2015).
+
+Skiboot 5.1.9 contains all fixes from skiboot-5.1.8 and is a minor bug
+fix release, with a single fix to help diagnosis after a rare error condition.
+
+Over skiboot-5.1.8, we have the following change:
+- opal/hmi: Signal PRD about NX unit checkstop.
+ We now signal Processor Recovery & Diagnostics (PRD) correctly following
+ an NX unit checkstop
+- minor fix to the boot_test.sh test script
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/external/boot-tests/bmc_support.sh new/skiboot-skiboot-5.1.12/external/boot-tests/bmc_support.sh
--- old/skiboot-skiboot-5.1.8/external/boot-tests/bmc_support.sh 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/external/boot-tests/bmc_support.sh 2015-12-04 05:45:07.000000000 +0100
@@ -37,6 +37,7 @@
function flash {
if [ ! -z "$PFLASH_TO_COPY" ]; then
remotecp $PFLASH_TO_COPY $target /tmp/pflash
+ $SSHCMD chmod +x /tmp/pflash
PFLASH_BINARY=/tmp/pflash
fi
if [ ! -z "$PNOR" ]; then
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/external/opal-prd/opal-prd.c new/skiboot-skiboot-5.1.12/external/opal-prd/opal-prd.c
--- old/skiboot-skiboot-5.1.8/external/opal-prd/opal-prd.c 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/external/opal-prd/opal-prd.c 2015-12-04 05:45:07.000000000 +0100
@@ -1023,6 +1023,52 @@
return rc;
}
+bool find_string(const char *buffer, size_t len, const char *s)
+{
+ const char *c, *end;
+
+ if (!buffer)
+ return false;
+ c = buffer;
+ end = c + len;
+
+ while (c < end) {
+ if (!strcasecmp(s, c))
+ return true;
+ c += strlen(c) + 1;
+ }
+ return false;
+}
+
+static int is_prd_supported(void)
+{
+ char *path;
+ int rc;
+ int len;
+ char *buf;
+
+ rc = asprintf(&path, "%s/ibm,opal/diagnostics/compatible",
+ devicetree_base);
+ if (rc < 0) {
+ pr_log(LOG_ERR, "FW: error creating 'compatible' node path: %m");
+ return -1;
+ }
+
+ rc = open_and_read(path, (void *) &buf, &len);
+ if (rc)
+ goto out_free;
+
+ if (buf[len - 1] != '\0')
+ pr_log(LOG_INFO, "FW: node %s is not nul-terminated", path);
+
+ rc = find_string(buf, len, "ibm,opal-prd") ? 0 : -1;
+
+ free(buf);
+out_free:
+ free(path);
+ return rc;
+}
+
static int prd_init(struct opal_prd_ctx *ctx)
{
int rc;
@@ -1945,6 +1991,12 @@
action = ACTION_RUN_DAEMON;
}
+ if (is_prd_supported() < 0) {
+ pr_log(LOG_ERR, "CTRL: PowerNV OPAL runtime diagnostic "
+ "is not supported on this system");
+ return -1;
+ }
+
switch (action) {
case ACTION_RUN_DAEMON:
rc = run_prd_daemon(ctx);
diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/skiboot-skiboot-5.1.8/external/pflash/pflash.c new/skiboot-skiboot-5.1.12/external/pflash/pflash.c
--- old/skiboot-skiboot-5.1.8/external/pflash/pflash.c 2015-10-19 04:21:40.000000000 +0200
+++ new/skiboot-skiboot-5.1.12/external/pflash/pflash.c 2015-12-04 05:45:07.000000000 +0100
@@ -1,3 +1,19 @@
+/* Copyright 2013-2015 IBM Corp.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
+ * implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
#include