Script 'mail_helper' called by obssrc Hello community, here is the log from the commit of package aws-c-common for openSUSE:Factory checked in at 2024-06-06 12:34:24 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/aws-c-common (Old) and /work/SRC/openSUSE:Factory/.aws-c-common.new.24587 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "aws-c-common" Thu Jun 6 12:34:24 2024 rev:7 rq:1178904 version:0.9.20 Changes: -------- --- /work/SRC/openSUSE:Factory/aws-c-common/aws-c-common.changes 2024-05-16 17:15:44.289146206 +0200 +++ /work/SRC/openSUSE:Factory/.aws-c-common.new.24587/aws-c-common.changes 2024-06-06 12:34:58.633631363 +0200 @@ -1,0 +2,11 @@ +Wed Jun 5 09:45:21 UTC 2024 - John Paul Adrian Glaubitz <adrian.glaubitz@suse.com> + +- Update to version 0.9.20 + * Task scheduler: log at TRACE, instead of DEBUG by @graebm in (#1115) + * Update CJson to v1.7.18 by @waahm7 in (#1116) + * Avoid overflowing pointers passed to memcpy by @qinheping in (#874) + * Fix test skipping by @graebm in (#1118) + * Fix CMake Windows ARM typo by @graebm in (#1119) + * Fix weird decimal formatting in tests by @graebm in (#1121) + +------------------------------------------------------------------- Old: ---- v0.9.19.tar.gz New: ---- v0.9.20.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ aws-c-common.spec ++++++ --- /var/tmp/diff_new_pack.7CX75f/_old 2024-06-06 12:35:00.093684571 +0200 +++ /var/tmp/diff_new_pack.7CX75f/_new 2024-06-06 12:35:00.101684863 +0200 @@ -19,7 +19,7 @@ %define library_version 1.0.0 %define library_soversion 1 Name: aws-c-common -Version: 0.9.19 +Version: 0.9.20 Release: 0 Summary: Core C99 package for AWS SDK for C License: Apache-2.0 ++++++ v0.9.19.tar.gz -> v0.9.20.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/.github/workflows/ci.yml new/aws-c-common-0.9.20/.github/workflows/ci.yml --- old/aws-c-common-0.9.19/.github/workflows/ci.yml 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/.github/workflows/ci.yml 2024-06-04 01:59:27.000000000 +0200 @@ -125,7 +125,7 @@ python builder.pyz build -p ${{ env.PACKAGE_NAME }} --target windows-${{ matrix.arch }} --compiler msvc-16 windows-vc15: - runs-on: windows-2022 # latest + runs-on: windows-2019 # windows-2019 is last env with Visual Studio 2017 (v15.0) strategy: matrix: arch: [x86, x64] diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/CMakeLists.txt new/aws-c-common-0.9.20/CMakeLists.txt --- old/aws-c-common-0.9.19/CMakeLists.txt 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/CMakeLists.txt 2024-06-04 01:59:27.000000000 +0200 @@ -152,7 +152,7 @@ ) endif() elseif (AWS_ARCH_ARM64 OR AWS_ARCH_ARM32) - if (WINDOWS) + if (WIN32) file(GLOB AWS_COMMON_ARCH_SRC "source/arch/arm/windows/*.c" ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/cmake/AwsTestHarness.cmake new/aws-c-common-0.9.20/cmake/AwsTestHarness.cmake --- old/aws-c-common-0.9.19/cmake/AwsTestHarness.cmake 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/cmake/AwsTestHarness.cmake 2024-06-04 01:59:27.000000000 +0200 @@ -59,6 +59,7 @@ foreach(name IN LISTS TEST_CASES) add_test(${name} ${driver_exe_name} "${name}") + set_tests_properties("${name}" PROPERTIES SKIP_RETURN_CODE ${SKIP_RETURN_CODE_VALUE}) endforeach() # Clear test cases in case another driver needs to be generated diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/include/aws/testing/aws_test_harness.h new/aws-c-common-0.9.20/include/aws/testing/aws_test_harness.h --- old/aws-c-common-0.9.19/include/aws/testing/aws_test_harness.h 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/include/aws/testing/aws_test_harness.h 2024-06-04 01:59:27.000000000 +0200 @@ -83,18 +83,6 @@ * that may be returned from various tools (e.g. sanitizer). */ #define SKIP (103) -#define POSTSKIP_INTERNAL() \ - do { \ - return SKIP; \ - } while (0) - -#define RETURN_SKIP(format, ...) \ - do { \ - printf(format, ##__VA_ARGS__); \ - printf("\n"); \ - POSTSKIP_INTERNAL(); \ - } while (0) - #define RETURN_SUCCESS(format, ...) \ do { \ printf(format, ##__VA_ARGS__); \ @@ -147,7 +135,7 @@ if (assert_rv != AWS_OP_SUCCESS) { \ if (!PRINT_FAIL_INTERNAL0(__VA_ARGS__)) { \ PRINT_FAIL_INTERNAL0( \ - "Expected success at %s; got return value %d with last error 0x%04d\n", \ + "Expected success at %s; got return value %d with last error %d\n", \ #condition, \ assert_rv, \ aws_last_error()); \ @@ -162,7 +150,7 @@ if (assert_rv != AWS_OP_ERR) { \ if (!PRINT_FAIL_INTERNAL0(__VA_ARGS__)) { \ PRINT_FAIL_INTERNAL0( \ - "Expected failure at %s; got return value %d with last error 0x%04d\n", \ + "Expected failure at %s; got return value %d with last error %d\n", \ #condition, \ assert_rv, \ aws_last_error()); \ @@ -179,7 +167,7 @@ if (assert_rv != AWS_OP_ERR) { \ fprintf( \ AWS_TESTING_REPORT_FD, \ - "%sExpected error but no error occurred; rv=%d, aws_last_error=%04d (expected %04d): ", \ + "%sExpected error but no error occurred; rv=%d, aws_last_error=%d (expected %d): ", \ FAIL_PREFIX, \ assert_rv, \ assert_err, \ @@ -192,7 +180,7 @@ if (assert_err != assert_err_expect) { \ fprintf( \ AWS_TESTING_REPORT_FD, \ - "%sIncorrect error code; aws_last_error=%04d (expected %04d): ", \ + "%sIncorrect error code; aws_last_error=%d (expected %d): ", \ FAIL_PREFIX, \ assert_err, \ assert_err_expect); \ @@ -468,7 +456,7 @@ test_res |= harness->on_after(allocator, setup_res, harness->ctx); } - if (test_res != AWS_OP_SUCCESS && test_res != AWS_OP_SKIP) { + if (test_res != AWS_OP_SUCCESS) { goto fail; } @@ -492,21 +480,21 @@ aws_logger_set(NULL); aws_logger_clean_up(&err_logger); - if (test_res == AWS_OP_SUCCESS) { - RETURN_SUCCESS("%s [ \033[32mOK\033[0m ]", harness->test_name); - } else if (test_res == AWS_OP_SKIP) { - RETURN_SKIP("%s [ \033[32mSKIP\033[0m ]", harness->test_name); - } + RETURN_SUCCESS("%s [ \033[32mOK\033[0m ]", harness->test_name); fail: - PRINT_FAIL_WITHOUT_LOCATION("%s [ \033[31mFAILED\033[0m ]", harness->test_name); + if (test_res == AWS_OP_SKIP) { + fprintf(AWS_TESTING_REPORT_FD, "%s [ \033[32mSKIP\033[0m ]\n", harness->test_name); + } else { + PRINT_FAIL_WITHOUT_LOCATION("%s [ \033[31mFAILED\033[0m ]", harness->test_name); + } /* Use _Exit() to terminate without cleaning up resources. * This prevents LeakSanitizer spam (yes, we know failing tests don't bother cleaning up). * It also prevents errors where threads that haven't cleaned are still using the logger declared in this fn. */ fflush(AWS_TESTING_REPORT_FD); fflush(stdout); fflush(stderr); - _Exit(FAILURE); + _Exit(test_res == AWS_OP_SKIP ? SKIP : FAILURE); } /* Enables terminal escape sequences for text coloring on Windows. */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/source/array_list.c new/aws-c-common-0.9.20/source/array_list.c --- old/aws-c-common-0.9.19/source/array_list.c 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/source/array_list.c 2024-06-04 01:59:27.000000000 +0200 @@ -184,9 +184,12 @@ } size_t remainder = item_size & (SLICE - 1); /* item_size % SLICE */ - memcpy((void *)temp, (void *)item1, remainder); - memcpy((void *)item1, (void *)item2, remainder); - memcpy((void *)item2, (void *)temp, remainder); + + if (remainder) { + memcpy((void *)temp, (void *)item1, remainder); + memcpy((void *)item1, (void *)item2, remainder); + memcpy((void *)item2, (void *)temp, remainder); + } } void aws_array_list_swap(struct aws_array_list *AWS_RESTRICT list, size_t a, size_t b) { diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/source/external/cJSON.c new/aws-c-common-0.9.20/source/external/cJSON.c --- old/aws-c-common-0.9.19/source/external/cJSON.c 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/source/external/cJSON.c 2024-06-04 01:59:27.000000000 +0200 @@ -127,7 +127,7 @@ } /* This is a safeguard to prevent copy-pasters from using incompatible C and header files */ -#if (CJSON_VERSION_MAJOR != 1) || (CJSON_VERSION_MINOR != 7) || (CJSON_VERSION_PATCH != 17) +#if (CJSON_VERSION_MAJOR != 1) || (CJSON_VERSION_MINOR != 7) || (CJSON_VERSION_PATCH != 18) #error cJSON.h and cJSON.c have different versions. Make sure that both have the same. #endif @@ -273,10 +273,12 @@ if (!(item->type & cJSON_IsReference) && (item->valuestring != NULL)) { global_hooks.deallocate(item->valuestring); + item->valuestring = NULL; } if (!(item->type & cJSON_StringIsConst) && (item->string != NULL)) { global_hooks.deallocate(item->string); + item->string = NULL; } global_hooks.deallocate(item); item = next; @@ -407,6 +409,7 @@ return object->valuedouble = number; } +/* Note: when passing a NULL valuestring, cJSON_SetValuestring treats this as an error and return NULL */ CJSON_PUBLIC(char*) cJSON_SetValuestring(cJSON *object, const char *valuestring) { char *copy = NULL; @@ -415,8 +418,8 @@ { return NULL; } - /* return NULL if the object is corrupted */ - if (object->valuestring == NULL) + /* return NULL if the object is corrupted or valuestring is NULL */ + if (object->valuestring == NULL || valuestring == NULL) { return NULL; } @@ -903,6 +906,7 @@ if (output != NULL) { input_buffer->hooks.deallocate(output); + output = NULL; } if (input_pointer != NULL) @@ -1249,6 +1253,7 @@ /* free the buffer */ hooks->deallocate(buffer->buffer); + buffer->buffer = NULL; } return printed; @@ -1257,11 +1262,13 @@ if (buffer->buffer != NULL) { hooks->deallocate(buffer->buffer); + buffer->buffer = NULL; } if (printed != NULL) { hooks->deallocate(printed); + printed = NULL; } return NULL; @@ -1302,6 +1309,7 @@ if (!print_value(item, &p)) { global_hooks.deallocate(p.buffer); + p.buffer = NULL; return NULL; } @@ -1673,6 +1681,11 @@ current_item = new_item; } + if (cannot_access_at_index(input_buffer, 1)) + { + goto fail; /* nothing comes after the comma */ + } + /* parse the name of the child */ input_buffer->offset++; buffer_skip_whitespace(input_buffer); @@ -3140,6 +3153,7 @@ CJSON_PUBLIC(void) cJSON_free(void *object) { global_hooks.deallocate(object); + object = NULL; } /* Amazon edit */ /* NOLINTEND */ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/source/external/cJSON.h new/aws-c-common-0.9.20/source/external/cJSON.h --- old/aws-c-common-0.9.19/source/external/cJSON.h 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/source/external/cJSON.h 2024-06-04 01:59:27.000000000 +0200 @@ -88,7 +88,7 @@ /* project version */ #define CJSON_VERSION_MAJOR 1 #define CJSON_VERSION_MINOR 7 -#define CJSON_VERSION_PATCH 17 +#define CJSON_VERSION_PATCH 18 #include <stddef.h> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/source/task_scheduler.c new/aws-c-common-0.9.20/source/task_scheduler.c --- old/aws-c-common-0.9.19/source/task_scheduler.c 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/source/task_scheduler.c 2024-06-04 01:59:27.000000000 +0200 @@ -33,7 +33,7 @@ void aws_task_run(struct aws_task *task, enum aws_task_status status) { AWS_ASSERT(task->fn); - AWS_LOGF_DEBUG( + AWS_LOGF_TRACE( AWS_LS_COMMON_TASK_SCHEDULER, "id=%p: Running %s task with %s status", (void *)task, @@ -129,7 +129,7 @@ AWS_ASSERT(task); AWS_ASSERT(task->fn); - AWS_LOGF_DEBUG( + AWS_LOGF_TRACE( AWS_LS_COMMON_TASK_SCHEDULER, "id=%p: Scheduling %s task for immediate execution", (void *)task, @@ -152,7 +152,7 @@ AWS_ASSERT(task); AWS_ASSERT(task->fn); - AWS_LOGF_DEBUG( + AWS_LOGF_TRACE( AWS_LS_COMMON_TASK_SCHEDULER, "id=%p: Scheduling %s task for future execution at time %" PRIu64, (void *)task, diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/aws-c-common-0.9.19/tests/thread_test.c new/aws-c-common-0.9.20/tests/thread_test.c --- old/aws-c-common-0.9.19/tests/thread_test.c 2024-05-11 01:22:14.000000000 +0200 +++ new/aws-c-common-0.9.20/tests/thread_test.c 2024-06-04 01:59:27.000000000 +0200 @@ -243,7 +243,7 @@ /* * Increase the timeout and shut down */ - aws_thread_set_managed_join_timeout_ns(aws_timestamp_convert(5, AWS_TIMESTAMP_SECS, AWS_TIMESTAMP_NANOS, NULL)); + aws_thread_set_managed_join_timeout_ns(aws_timestamp_convert(10, AWS_TIMESTAMP_SECS, AWS_TIMESTAMP_NANOS, NULL)); aws_common_library_clean_up();