Hello community, here is the log from the commit of package chromium for openSUSE:Factory checked in at 2019-03-27 16:20:30 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/chromium (Old) and /work/SRC/openSUSE:Factory/.chromium.new.25356 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "chromium" Wed Mar 27 16:20:30 2019 rev:214 rq:688615 version:73.0.3683.86 Changes: -------- --- /work/SRC/openSUSE:Factory/chromium/chromium.changes 2019-03-14 15:00:34.375704710 +0100 +++ /work/SRC/openSUSE:Factory/.chromium.new.25356/chromium.changes 2019-03-27 16:21:15.219531637 +0100 @@ -1,0 +2,22 @@ +Mon Mar 25 13:49:17 UTC 2019 - Tomáš Chvátal <tchvatal@suse.com> + +- Add patch for pipewire build: + * chromium-73.0.3683.75-pipewire-cstring-fix.patch + +------------------------------------------------------------------- +Mon Mar 25 10:54:06 UTC 2019 - Tomáš Chvátal <tchvatal@suse.com> + +- Update to 73.0.3683.86: + * Just feature fixes around +- Refresh patch: + * chromium-non-void-return.patch + +------------------------------------------------------------------- +Thu Mar 21 11:00:28 UTC 2019 - Tomáš Chvátal <tchvatal@suse.com> + +- Update conditions to use system harfbuzz on TW+ +- Require java during build +- Enable using pipewire when available +- Rebase chromium-vaapi.patch to match up the Fedora one + +------------------------------------------------------------------- Old: ---- chromium-73.0.3683.75.tar.xz New: ---- chromium-73.0.3683.75-pipewire-cstring-fix.patch chromium-73.0.3683.86.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ chromium.spec ++++++ --- /var/tmp/diff_new_pack.xkQ9Vf/_old 2019-03-27 16:21:30.639528424 +0100 +++ /var/tmp/diff_new_pack.xkQ9Vf/_new 2019-03-27 16:21:30.643528423 +0100 @@ -27,15 +27,17 @@ %endif %if 0%{?suse_version} >= 1550 %bcond_without system_icu +%bcond_without system_harfbuzz +%bcond_without pipewire %else %bcond_with system_icu +%bcond_with system_harfbuzz +%bcond_with pipewire %endif %if 0%{?suse_version} >= 1500 %bcond_without system_libxml -%bcond_with system_harfbuzz %else %bcond_with system_libxml -%bcond_with system_harfbuzz %endif %ifarch %{arm} aarch64 %bcond_with swiftshader @@ -46,7 +48,7 @@ %bcond_with clang %bcond_with wayland Name: chromium -Version: 73.0.3683.75 +Version: 73.0.3683.86 Release: 0 Summary: Google's open source browser project License: BSD-3-Clause AND LGPL-2.1-or-later @@ -85,6 +87,7 @@ Patch15: chromium-gcc.patch # Patch-FIX-UPSTREAM https://chromium-review.googlesource.com/c/crashpad/crashpad/+/1454376 Patch16: chromium-fix_crashpad.patch +Patch17: chromium-73.0.3683.75-pipewire-cstring-fix.patch # Google seem not too keen on merging this but GPU accel is quite important # https://chromium-review.googlesource.com/c/chromium/src/+/532294 # https://github.com/saiarcot895/chromium-ubuntu-build/tree/master/debian/patc... @@ -106,6 +109,8 @@ BuildRequires: gn BuildRequires: gperf BuildRequires: hicolor-icon-theme +# Java used during build +BuildRequires: java-openjdk-headless BuildRequires: libcap-devel BuildRequires: libdc1394 BuildRequires: libgcrypt-devel @@ -208,6 +213,9 @@ Obsoletes: chromium-ffmpegsumo # no 32bit supported and it takes ages to build ExcludeArch: %{ix86} %{arm} ppc ppc64 ppc64le s390 s390x +%if %{with pipewire} +BuildRequires: pkgconfig(libpipewire-0.2) +%endif %if %{with wayland} BuildRequires: pkgconfig(gbm) BuildRequires: pkgconfig(wayland-client) @@ -510,7 +518,7 @@ %endif %endif # do not eat all memory -%limit_build -m 2500 +%limit_build -m 2600 # Set system libraries to be used gn_system_libraries=( @@ -603,6 +611,9 @@ myconf_gn+=" enable_hangout_services_extension=true" myconf_gn+=" enable_vulkan=true" myconf_gn+=" enable_hevc_demuxing=true" +%if %{with pipewire} +myconf_gn+=" rtc_use_pipewire=true rtc_link_pipewire=true" +%endif # ozone stuff %if %{with wayland} myconf_gn+=" use_ozone=true use_xkbcommon=true use_system_minigbm=true use_v4lplugin=true use_v4l2_codec=true use_linux_v4l2_only=true" ++++++ chromium-73.0.3683.75-pipewire-cstring-fix.patch ++++++ diff -up chromium-73.0.3683.75/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc.cstringfix chromium-73.0.3683.75/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc --- chromium-73.0.3683.75/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc.cstringfix 2019-03-13 13:04:25.290842447 -0400 +++ chromium-73.0.3683.75/third_party/webrtc/modules/desktop_capture/linux/base_capturer_pipewire.cc 2019-03-13 13:05:13.234897441 -0400 @@ -18,6 +18,7 @@ #include <spa/param/video/raw-utils.h> #include <spa/support/type-map.h> +#include <cstring> #include <memory> #include <utility> ++++++ chromium-73.0.3683.75.tar.xz -> chromium-73.0.3683.86.tar.xz ++++++ /work/SRC/openSUSE:Factory/chromium/chromium-73.0.3683.75.tar.xz /work/SRC/openSUSE:Factory/.chromium.new.25356/chromium-73.0.3683.86.tar.xz differ: char 26, line 1 ++++++ chromium-non-void-return.patch ++++++ ++++ 1756 lines (skipped) ++++ between /work/SRC/openSUSE:Factory/chromium/chromium-non-void-return.patch ++++ and /work/SRC/openSUSE:Factory/.chromium.new.25356/chromium-non-void-return.patch ++++++ chromium-vaapi.patch ++++++ --- /var/tmp/diff_new_pack.xkQ9Vf/_old 2019-03-27 16:21:30.731528405 +0100 +++ /var/tmp/diff_new_pack.xkQ9Vf/_new 2019-03-27 16:21:30.731528405 +0100 @@ -1,8 +1,22 @@ -Index: chromium-73.0.3664.3/chrome/browser/about_flags.cc -=================================================================== ---- chromium-73.0.3664.3.orig/chrome/browser/about_flags.cc -+++ chromium-73.0.3664.3/chrome/browser/about_flags.cc -@@ -1636,7 +1636,7 @@ const FeatureEntry kFeatureEntries[] = { +From abc7295ca1653c85472916909f0eb76e28e79a58 Mon Sep 17 00:00:00 2001 +From: Akarshan Biswas <akarshan.biswas@gmail.com> +Date: Thu, 24 Jan 2019 12:45:29 +0530 +Subject: [PATCH] Enable mojo with VDA2 on Linux + +--- + chrome/browser/about_flags.cc | 8 ++++---- + chrome/browser/flag_descriptions.cc | 9 +++++++-- + chrome/browser/flag_descriptions.h | 10 ++++++++-- + gpu/config/software_rendering_list.json | 3 ++- + media/media_options.gni | 9 ++++++--- + media/mojo/services/gpu_mojo_media_client.cc | 4 ++-- + 6 files changed, 29 insertions(+), 14 deletions(-) + +Index: chromium-73.0.3683.75/chrome/browser/about_flags.cc +=================================================================== +--- chromium-73.0.3683.75.orig/chrome/browser/about_flags.cc ++++ chromium-73.0.3683.75/chrome/browser/about_flags.cc +@@ -1606,7 +1606,7 @@ const FeatureEntry kFeatureEntries[] = { "disable-accelerated-video-decode", flag_descriptions::kAcceleratedVideoDecodeName, flag_descriptions::kAcceleratedVideoDecodeDescription, @@ -11,7 +25,7 @@ SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedVideoDecode), }, #if defined(OS_WIN) -@@ -2255,12 +2255,12 @@ const FeatureEntry kFeatureEntries[] = { +@@ -2216,12 +2216,12 @@ const FeatureEntry kFeatureEntries[] = { FEATURE_VALUE_TYPE(service_manager::features::kXRSandbox)}, #endif // ENABLE_ISOLATED_XR_SERVICE #endif // ENABLE_VR @@ -23,227 +37,78 @@ + flag_descriptions::kAcceleratedMjpegDecodeDescription, kOsCrOS | kOsLinux, SINGLE_DISABLE_VALUE_TYPE(switches::kDisableAcceleratedMjpegDecode)}, -#endif // OS_CHROMEOS -+#endif ++#endif // OS_CHROMEOS // OS_LINUX {"v8-cache-options", flag_descriptions::kV8CacheOptionsName, flag_descriptions::kV8CacheOptionsDescription, kOsAll, MULTI_VALUE_TYPE(kV8CacheOptionsChoices)}, -Index: chromium-73.0.3664.3/chrome/browser/flag_descriptions.cc +Index: chromium-73.0.3683.75/chrome/browser/flag_descriptions.cc =================================================================== ---- chromium-73.0.3664.3.orig/chrome/browser/flag_descriptions.cc -+++ chromium-73.0.3664.3/chrome/browser/flag_descriptions.cc -@@ -2999,7 +2999,7 @@ const char kTextSuggestionsTouchBarDescr +--- chromium-73.0.3683.75.orig/chrome/browser/flag_descriptions.cc ++++ chromium-73.0.3683.75/chrome/browser/flag_descriptions.cc +@@ -3096,15 +3096,20 @@ const char kTextSuggestionsTouchBarDescr - // Chrome OS ------------------------------------------------------------------- + #endif + +-// Chrome OS ------------------------------------------------------------------- ++// Chrome OS Linux------------------------------------------------------------------- -#if defined(OS_CHROMEOS) +#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID)) const char kAcceleratedMjpegDecodeName[] = "Hardware-accelerated mjpeg decode for captured frame"; -@@ -3570,7 +3570,7 @@ const char kWakeOnPacketsName[] = "Wake - const char kWakeOnPacketsDescription[] = - "Enables waking the device based on the receipt of some network packets."; - --#endif // defined(OS_CHROMEOS) -+#endif // defined(OS_CHROMEOS) || BUILDFLAG(USE_VAAPI) - - // Random platform combinations ----------------------------------------------- + const char kAcceleratedMjpegDecodeDescription[] = + "Enable hardware-accelerated mjpeg decode for captured frame where " + "available."; ++#endif ++ ++// Chrome OS -------------------------------------------------- ++ ++#if defined(OS_CHROMEOS) -Index: chromium-73.0.3664.3/chrome/browser/flag_descriptions.h -=================================================================== ---- chromium-73.0.3664.3.orig/chrome/browser/flag_descriptions.h -+++ chromium-73.0.3664.3/chrome/browser/flag_descriptions.h -@@ -1792,13 +1792,17 @@ extern const char kPermissionPromptPersi + const char kAllowTouchpadThreeFingerClickName[] = "Touchpad three-finger-click"; + const char kAllowTouchpadThreeFingerClickDescription[] = +Index: chromium-73.0.3683.75/chrome/browser/flag_descriptions.h +=================================================================== +--- chromium-73.0.3683.75.orig/chrome/browser/flag_descriptions.h ++++ chromium-73.0.3683.75/chrome/browser/flag_descriptions.h +@@ -1842,13 +1842,19 @@ extern const char kPermissionPromptPersi #endif // defined(OS_MACOSX) -// Chrome OS ------------------------------------------------------------------ -- ++// Chrome OS and Linux ------------------------------------------------------------------ + -#if defined(OS_CHROMEOS) +#if defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID)) extern const char kAcceleratedMjpegDecodeName[]; extern const char kAcceleratedMjpegDecodeDescription[]; -+#endif ++#endif // defined(OS_CHROMEOS) || (defined(OS_LINUX) && !defined(OS_ANDROID)) + -+// Chrome OS ------------------------------------------------------------------ ++// Chrome OS ------------------------------------------------------------------------ + +#if defined(OS_CHROMEOS) + extern const char kAllowTouchpadThreeFingerClickName[]; extern const char kAllowTouchpadThreeFingerClickDescription[]; -Index: chromium-73.0.3664.3/components/viz/service/main/viz_main_impl.cc -=================================================================== ---- chromium-73.0.3664.3.orig/components/viz/service/main/viz_main_impl.cc -+++ chromium-73.0.3664.3/components/viz/service/main/viz_main_impl.cc -@@ -35,7 +35,7 @@ std::unique_ptr<base::Thread> CreateAndS - // It should be possible to use |main_task_runner_| for doing IO tasks. - base::Thread::Options thread_options(base::MessageLoop::TYPE_IO, 0); - thread_options.priority = base::ThreadPriority::NORMAL; --#if defined(OS_ANDROID) || defined(OS_CHROMEOS) -+#if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_CHROMEOS) - // TODO(reveman): Remove this in favor of setting it explicitly for each - // type of process. - thread_options.priority = base::ThreadPriority::DISPLAY; -Index: chromium-73.0.3664.3/content/gpu/BUILD.gn -=================================================================== ---- chromium-73.0.3664.3.orig/content/gpu/BUILD.gn -+++ chromium-73.0.3664.3/content/gpu/BUILD.gn -@@ -6,6 +6,7 @@ import("//build/config/jumbo.gni") - import("//build/config/ui.gni") - import("//gpu/vulkan/features.gni") - import("//media/media_options.gni") -+import("//media/gpu/args.gni") - import("//ui/ozone/ozone.gni") - - # See //content/BUILD.gn for how this works. -@@ -49,7 +50,6 @@ target(link_target_type, "gpu_sources") - ] - - configs += [ "//content:content_implementation" ] -- - deps = [ - "//base", - "//base/third_party/dynamic_annotations", -@@ -136,4 +136,8 @@ target(link_target_type, "gpu_sources") - (!is_chromecast || is_cast_desktop_build)) { - configs += [ "//build/config/linux/dri" ] - } -+ -+ if (is_desktop_linux && use_vaapi) { -+ public_configs = [ "//media/gpu:libva_config" ] -+ } - } -Index: chromium-73.0.3664.3/content/gpu/gpu_main.cc -=================================================================== ---- chromium-73.0.3664.3.orig/content/gpu/gpu_main.cc -+++ chromium-73.0.3664.3/content/gpu/gpu_main.cc -@@ -284,7 +284,7 @@ int GpuMain(const MainFunctionParams& pa - - base::PlatformThread::SetName("CrGpuMain"); - --#if defined(OS_ANDROID) || defined(OS_CHROMEOS) -+#if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_CHROMEOS) - // Set thread priority before sandbox initialization. - base::PlatformThread::SetCurrentThreadPriority(base::ThreadPriority::DISPLAY); - #endif -@@ -317,7 +317,7 @@ int GpuMain(const MainFunctionParams& pa - GetContentClient()->SetGpuInfo(gpu_init->gpu_info()); - - base::ThreadPriority io_thread_priority = base::ThreadPriority::NORMAL; --#if defined(OS_ANDROID) || defined(OS_CHROMEOS) -+#if defined(OS_LINUX) || defined(OS_ANDROID) || defined(OS_CHROMEOS) - io_thread_priority = base::ThreadPriority::DISPLAY; - #endif - -Index: chromium-73.0.3664.3/gpu/config/software_rendering_list.json +Index: chromium-73.0.3683.75/gpu/config/software_rendering_list.json =================================================================== ---- chromium-73.0.3664.3.orig/gpu/config/software_rendering_list.json -+++ chromium-73.0.3664.3/gpu/config/software_rendering_list.json -@@ -370,17 +370,6 @@ - ] +--- chromium-73.0.3683.75.orig/gpu/config/software_rendering_list.json ++++ chromium-73.0.3683.75/gpu/config/software_rendering_list.json +@@ -371,11 +371,12 @@ }, { -- "id": 48, + "id": 48, - "description": "Accelerated video decode is unavailable on Linux", -- "cr_bugs": [137247], -- "os": { -- "type": "linux" -- }, -- "features": [ -- "accelerated_video_decode" -- ] -- }, -- { - "id": 50, - "description": "Disable VMware software renderer on older Mesa", - "cr_bugs": [145531, 332596, 571899, 629434], -Index: chromium-73.0.3664.3/media/base/media_switches.cc -=================================================================== ---- chromium-73.0.3664.3.orig/media/base/media_switches.cc -+++ chromium-73.0.3664.3/media/base/media_switches.cc -@@ -494,7 +494,7 @@ bool IsVideoCaptureAcceleratedJpegDecodi - switches::kUseFakeJpegDecodeAccelerator)) { - return true; - } --#if defined(OS_CHROMEOS) -+#if defined(OS_LINUX) || defined(OS_CHROMEOS) - return true; - #endif - return false; -Index: chromium-73.0.3664.3/media/filters/BUILD.gn -=================================================================== ---- chromium-73.0.3664.3.orig/media/filters/BUILD.gn -+++ chromium-73.0.3664.3/media/filters/BUILD.gn -@@ -5,6 +5,7 @@ - import("//build/config/jumbo.gni") - import("//media/media_options.gni") - import("//third_party/libaom/options.gni") -+import("//media/gpu/args.gni") - - jumbo_source_set("filters") { - # Do not expand the visibility here without double-checking with OWNERS, this -@@ -202,7 +203,7 @@ jumbo_source_set("filters") { - deps += [ "//media/base/android" ] - } - -- if (current_cpu != "arm" && is_linux) { -+ if (use_vaapi) { - sources += [ - "h264_bitstream_buffer.cc", - "h264_bitstream_buffer.h", -Index: chromium-73.0.3664.3/media/gpu/BUILD.gn -=================================================================== ---- chromium-73.0.3664.3.orig/media/gpu/BUILD.gn -+++ chromium-73.0.3664.3/media/gpu/BUILD.gn -@@ -504,6 +504,12 @@ if (use_v4l2_codec || use_vaapi || is_ma - } - } - -+import("//build/config/linux/pkg_config.gni") -+ -+pkg_config("libva_config") { -+ packages = [ "libva" ] -+} -+ - if (use_v4l2_codec || use_vaapi) { - test("jpeg_encode_accelerator_unittest") { - deps = [ -@@ -574,6 +580,7 @@ if (is_chromeos || is_linux) { - if (use_ozone) { - deps += [ "//ui/ozone" ] - } -+ public_configs = [ ":libva_config" ] - } - } - -Index: chromium-73.0.3664.3/media/gpu/gpu_video_decode_accelerator_factory.cc -=================================================================== ---- chromium-73.0.3664.3.orig/media/gpu/gpu_video_decode_accelerator_factory.cc -+++ chromium-73.0.3664.3/media/gpu/gpu_video_decode_accelerator_factory.cc -@@ -56,6 +56,7 @@ gpu::VideoDecodeAcceleratorCapabilities - // profile (instead of calculating a superset). - // TODO(posciak,henryhsu): improve this so that we choose a superset of - // resolutions and other supported profile parameters. -+ DVLOG(1) << "Get Supported profiles"; - VideoDecodeAccelerator::Capabilities capabilities; - #if defined(OS_WIN) - capabilities.supported_profiles = -Index: chromium-73.0.3664.3/media/gpu/vaapi/vaapi_wrapper.cc -=================================================================== ---- chromium-73.0.3664.3.orig/media/gpu/vaapi/vaapi_wrapper.cc -+++ chromium-73.0.3664.3/media/gpu/vaapi/vaapi_wrapper.cc -@@ -1028,7 +1028,11 @@ scoped_refptr<VASurface> VaapiWrapper::C - } - va_attrib_extbuf.num_planes = num_planes; - -+#if VA_CHECK_VERSION(1, 0, 0) -+ std::vector<uintptr_t> fds(num_fds); -+#else - std::vector<unsigned long> fds(num_fds); -+#endif - for (size_t i = 0; i < num_fds; ++i) { - int dmabuf_fd = pixmap->GetDmaBufFd(i); - if (dmabuf_fd < 0) { ++ "description": "Accelerated VA-API video decode is not supported on NVIDIA platforms", + "cr_bugs": [137247], + "os": { + "type": "linux" + }, ++ "vendor_id": "0x10de", + "features": [ + "accelerated_video_decode" + ]