Hello community, here is the log from the commit of package yast2-network for openSUSE:Factory checked in at 2015-08-05 06:48:57 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-network (Old) and /work/SRC/openSUSE:Factory/.yast2-network.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-network" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-network/yast2-network.changes 2015-07-25 07:44:05.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-network.new/yast2-network.changes 2015-08-05 06:48:59.000000000 +0200 @@ -1,0 +2,7 @@ +Fri Jul 31 13:41:08 UTC 2015 - ancor@suse.com + +- bnc#940192, bnc#935937 + - fixed crash deleting interfaces using CLI (yast lan delete) +- 3.1.123 + +------------------------------------------------------------------- Old: ---- yast2-network-3.1.122.tar.bz2 New: ---- yast2-network-3.1.123.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-network.spec ++++++ --- /var/tmp/diff_new_pack.lx0C7V/_old 2015-08-05 06:49:00.000000000 +0200 +++ /var/tmp/diff_new_pack.lx0C7V/_new 2015-08-05 06:49:00.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 3.1.122 +Version: 3.1.123 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-network-3.1.122.tar.bz2 -> yast2-network-3.1.123.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.122/.travis.yml new/yast2-network-3.1.123/.travis.yml --- old/yast2-network-3.1.122/.travis.yml 2015-07-23 17:57:12.000000000 +0200 +++ new/yast2-network-3.1.123/.travis.yml 2015-07-31 16:22:10.000000000 +0200 @@ -5,7 +5,7 @@ # disable rvm, use system Ruby - rvm reset - wget https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/tra... - - sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2 yast2-storage yast2-proxy yast2-country yast2-packager" -g "rspec:2.14.1 yast-rake gettext rubocop:0.29.1 simplecov coveralls" + - sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2 yast2-storage yast2-proxy yast2-country yast2-packager" -g "rspec:3.3.0 yast-rake gettext rubocop:0.29.1 simplecov coveralls" script: - rubocop - rake check:syntax diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.122/package/yast2-network.changes new/yast2-network-3.1.123/package/yast2-network.changes --- old/yast2-network-3.1.122/package/yast2-network.changes 2015-07-23 17:57:12.000000000 +0200 +++ new/yast2-network-3.1.123/package/yast2-network.changes 2015-07-31 16:22:10.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Fri Jul 31 13:41:08 UTC 2015 - ancor@suse.com + +- bnc#940192, bnc#935937 + - fixed crash deleting interfaces using CLI (yast lan delete) +- 3.1.123 + +------------------------------------------------------------------- Wed Jul 1 11:21:36 UTC 2015 - mfilka@suse.com - bnc#864264 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.122/package/yast2-network.spec new/yast2-network-3.1.123/package/yast2-network.spec --- old/yast2-network-3.1.122/package/yast2-network.spec 2015-07-23 17:57:12.000000000 +0200 +++ new/yast2-network-3.1.123/package/yast2-network.spec 2015-07-31 16:22:10.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-network -Version: 3.1.122 +Version: 3.1.123 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.122/src/include/network/lan/cmdline.rb new/yast2-network-3.1.123/src/include/network/lan/cmdline.rb --- old/yast2-network-3.1.122/src/include/network/lan/cmdline.rb 2015-07-23 17:57:12.000000000 +0200 +++ new/yast2-network-3.1.123/src/include/network/lan/cmdline.rb 2015-07-31 16:22:10.000000000 +0200 @@ -313,7 +313,6 @@ Ops.get_integer(value, "id", -1) ) Lan.Delete - LanItems.Commit CommandLine.Print(_("The device was deleted.")) end end diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.122/t/README.md new/yast2-network-3.1.123/t/README.md --- old/yast2-network-3.1.122/t/README.md 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-network-3.1.123/t/README.md 2015-07-31 16:22:10.000000000 +0200 @@ -0,0 +1,21 @@ +# Integration tests of the Command Line Interface (CLI) + +The idea is to have in each YaST package a standardized way to run +integration tests of the CLI features. + +Then we should be able to write an adapter for openQA or whatever CI +system to run such tests. + +## Running + +> **Warning**, they will reconfigure your system (actually the current ones + try to clean up after themselves, but they are not guaranteed to stay this + way), so use them in a scratch VM. + +```sh +prove +``` + +`prove` is a runner for the [Test Anything Protocol](http://testanything.org/), +which has a stdio interface and thus is well suited for command line tests. +The program is conveniently part of a base openSUSE system, in perl5.rpm. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-network-3.1.122/t/add-del.t new/yast2-network-3.1.123/t/add-del.t --- old/yast2-network-3.1.122/t/add-del.t 1970-01-01 01:00:00.000000000 +0100 +++ new/yast2-network-3.1.123/t/add-del.t 2015-07-31 16:22:10.000000000 +0200 @@ -0,0 +1,46 @@ +#!/bin/sh +# a TAP compatible test + +# quick and dirty: fail early +set -eu + +# test plan +echo 1..7 + +# usage: +# foo || tapfail +# echo "ok" +# this will tell TAP "not ok" IF foo has failed +tapfail() { + echo -n "not " +} + +YAST=/usr/sbin/yast + +echo "# assume and check that eth0 exists, as a base for the vlan" +ip addr show dev eth0 +echo "ok 1 eth0: exists already" + +echo "# add a (virtual) interface" +$YAST lan add name=vlan50 ethdevice=eth0 bootproto=dhcp || tapfail +echo "ok 2 vlan50: added" + +# check it has worked +ip addr show dev vlan50 +echo "ok 3 vlan50: interface exists" + +ls /etc/sysconfig/network/ifcfg-vlan50 || tapfail +echo "ok 4 vlan50: ifcfg exists" + +echo "# find it and delete it" +# the embarassing part: no way to identify by "vlan50" +ID=$($YAST lan list |& grep Virtual.LAN | cut -f1) +$YAST lan delete id=$ID verbose || tapfail +echo "ok 5 vlan50: deleted" + +# how to assert nonexistence? +! ip addr show dev vlan50 || tapfail +echo "ok 6 vlan50: interface does not exist" + +! ls /etc/sysconfig/network/ifcfg-vlan50 || tapfail +echo "ok 7 vlan50: ifcfg does not exist"