Hello community, here is the log from the commit of package libyui-ncurses for openSUSE:Factory checked in at 2015-08-13 18:09:48 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/libyui-ncurses (Old) and /work/SRC/openSUSE:Factory/.libyui-ncurses.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "libyui-ncurses" Changes: -------- --- /work/SRC/openSUSE:Factory/libyui-ncurses/libyui-ncurses.changes 2015-08-05 06:48:40.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.libyui-ncurses.new/libyui-ncurses.changes 2015-08-13 18:09:49.000000000 +0200 @@ -1,0 +2,7 @@ +Tue Aug 4 10:39:18 CEST 2015 - gs@suse.de + +- don't calculate height of an invisible widget (menu button) to + prevent segfault (bnc#931154) +- 2.47.2 + +------------------------------------------------------------------- Old: ---- libyui-ncurses-2.47.1.tar.bz2 New: ---- libyui-ncurses-2.47.2.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ libyui-ncurses-doc.spec ++++++ --- /var/tmp/diff_new_pack.TbGotb/_old 2015-08-13 18:09:50.000000000 +0200 +++ /var/tmp/diff_new_pack.TbGotb/_new 2015-08-13 18:09:50.000000000 +0200 @@ -17,7 +17,7 @@ Name: libyui-ncurses-doc -Version: 2.47.1 +Version: 2.47.2 Release: 0 Source: libyui-ncurses-%{version}.tar.bz2 ++++++ libyui-ncurses.spec ++++++ --- /var/tmp/diff_new_pack.TbGotb/_old 2015-08-13 18:09:50.000000000 +0200 +++ /var/tmp/diff_new_pack.TbGotb/_new 2015-08-13 18:09:50.000000000 +0200 @@ -17,7 +17,7 @@ Name: libyui-ncurses -Version: 2.47.1 +Version: 2.47.2 Release: 0 Source: libyui-ncurses-%{version}.tar.bz2 ++++++ libyui-ncurses-2.47.1.tar.bz2 -> libyui-ncurses-2.47.2.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.47.1/ChangeLog new/libyui-ncurses-2.47.2/ChangeLog --- old/libyui-ncurses-2.47.1/ChangeLog 2015-07-31 12:30:08.000000000 +0200 +++ new/libyui-ncurses-2.47.2/ChangeLog 2015-08-11 14:55:10.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Tue Aug 4 10:39:18 CEST 2015 - gs@suse.de + +- don't calculate height of an invisible widget (menu button) to + prevent segfault (bnc#931154) +- 2.47.2 + +------------------------------------------------------------------- Tue Jul 21 14:57:46 UTC 2015 - mvidner@suse.com - Added a libyui-terminal helper script (boo#937026). diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.47.1/VERSION.cmake new/libyui-ncurses-2.47.2/VERSION.cmake --- old/libyui-ncurses-2.47.1/VERSION.cmake 2015-07-31 12:30:08.000000000 +0200 +++ new/libyui-ncurses-2.47.2/VERSION.cmake 2015-08-11 14:55:10.000000000 +0200 @@ -1,6 +1,6 @@ SET( VERSION_MAJOR "2" ) SET( VERSION_MINOR "47" ) -SET( VERSION_PATCH "1" ) +SET( VERSION_PATCH "2" ) SET( VERSION "${VERSION_MAJOR}.${VERSION_MINOR}.${VERSION_PATCH}${GIT_SHA1_VERSION}" ) ##### This is need for the libyui core, ONLY. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.47.1/src/NCComboBox.cc new/libyui-ncurses-2.47.2/src/NCComboBox.cc --- old/libyui-ncurses-2.47.1/src/NCComboBox.cc 2014-02-21 11:37:26.000000000 +0100 +++ new/libyui-ncurses-2.47.2/src/NCComboBox.cc 2015-08-11 14:55:10.000000000 +0200 @@ -586,7 +586,8 @@ if ( !deflist.empty() ) { - wpos at( ScreenPos() + wpos( win->height(), -1 ) ); + // add fix heigth of 2 (dont't use win->height() because win might be invalid, bnc#931154) + wpos at( ScreenPos() + wpos( 2, -1 ) ); NCPopupList * dialog = new NCPopupList( at, "", deflist, index ); YUI_CHECK_NEW( dialog ); idx = dialog->post(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.47.1/src/NCMenuButton.cc new/libyui-ncurses-2.47.2/src/NCMenuButton.cc --- old/libyui-ncurses-2.47.1/src/NCMenuButton.cc 2014-02-21 11:37:26.000000000 +0100 +++ new/libyui-ncurses-2.47.2/src/NCMenuButton.cc 2015-08-11 14:55:10.000000000 +0200 @@ -136,7 +136,9 @@ NCursesEvent NCMenuButton::postMenu() { - wpos at( ScreenPos() + wpos( win->height(), 0 ) ); + // add fix heigth of 1 (dont't use win->height() because win might be invalid, bnc#931154) + wpos at( ScreenPos() + wpos( 1, 0 ) ); + NCPopupMenu * dialog = new NCPopupMenu( at, itemsBegin(), itemsEnd() ); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/libyui-ncurses-2.47.1/src/NCTable.cc new/libyui-ncurses-2.47.2/src/NCTable.cc --- old/libyui-ncurses-2.47.1/src/NCTable.cc 2014-07-28 10:26:45.000000000 +0200 +++ new/libyui-ncurses-2.47.2/src/NCTable.cc 2015-08-11 14:55:10.000000000 +0200 @@ -511,8 +511,8 @@ { if ( ! keepSorting() ) { - // get the column - wpos at( ScreenPos() + wpos( win->height() / 2, 1 ) ); + // get the column - show popup in upper left corner + wpos at( ScreenPos() + wpos( 2, 1 ) ); YItemCollection ic; ic.reserve( _header.size() );