Hello community, here is the log from the commit of package lollypop for openSUSE:Factory checked in at 2018-12-24 11:47:50 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/lollypop (Old) and /work/SRC/openSUSE:Factory/.lollypop.new.28833 (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "lollypop" Mon Dec 24 11:47:50 2018 rev:59 rq:660733 version:0.9.907 Changes: -------- --- /work/SRC/openSUSE:Factory/lollypop/lollypop.changes 2018-12-21 08:21:53.473543479 +0100 +++ /work/SRC/openSUSE:Factory/.lollypop.new.28833/lollypop.changes 2018-12-24 11:47:51.825108975 +0100 @@ -1,0 +2,8 @@ +Sat Dec 22 20:01:33 UTC 2018 - antoine.belvire@opensuse.org + +- Update to version 0.9.907: + * Fix some playback issues (glgo#World/lollypop#1574). + * Import loved tracks from playlists (glgo#World/lollypop#1573). + * Fix a crash (glgo#World/lollypop#1571). + +------------------------------------------------------------------- Old: ---- lollypop-0.9.906.tar.xz New: ---- lollypop-0.9.907.tar.xz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ lollypop.spec ++++++ --- /var/tmp/diff_new_pack.x0V0Wu/_old 2018-12-24 11:47:52.249108603 +0100 +++ /var/tmp/diff_new_pack.x0V0Wu/_new 2018-12-24 11:47:52.249108603 +0100 @@ -17,7 +17,7 @@ Name: lollypop -Version: 0.9.906 +Version: 0.9.907 Release: 0 Summary: GNOME music playing application License: GPL-3.0-or-later ++++++ _service ++++++ --- /var/tmp/diff_new_pack.x0V0Wu/_old 2018-12-24 11:47:52.265108589 +0100 +++ /var/tmp/diff_new_pack.x0V0Wu/_new 2018-12-24 11:47:52.265108589 +0100 @@ -1,7 +1,7 @@ <services> <service mode="disabled" name="tar_scm"> <param name="changesgenerate">enable</param> - <param name="revision">0.9.906</param> + <param name="revision">0.9.907</param> <param name="scm">git</param> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> <param name="versionformat">@PARENT_TAG@</param> ++++++ _servicedata ++++++ --- /var/tmp/diff_new_pack.x0V0Wu/_old 2018-12-24 11:47:52.277108579 +0100 +++ /var/tmp/diff_new_pack.x0V0Wu/_new 2018-12-24 11:47:52.277108579 +0100 @@ -1,4 +1,4 @@ <servicedata> <service name="tar_scm"> <param name="url">https://gitlab.gnome.org/World/lollypop.git</param> - <param name="changesrevision">5a6551cd34ce8f76650b7cea5b93157ee9e6ad40</param></service></servicedata> \ No newline at end of file + <param name="changesrevision">297838526b4d9e2acc83f831f48c0b7467620990</param></service></servicedata> \ No newline at end of file ++++++ lollypop-0.9.906.tar.xz -> lollypop-0.9.907.tar.xz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/lollypop/database_upgrade.py new/lollypop-0.9.907/lollypop/database_upgrade.py --- old/lollypop-0.9.906/lollypop/database_upgrade.py 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/lollypop/database_upgrade.py 2018-12-22 15:54:58.000000000 +0100 @@ -88,9 +88,26 @@ self._UPGRADES = { 1: "ALTER TABLE playlists ADD synced INT NOT NULL DEFAULT 0", 2: "ALTER TABLE playlists ADD smart_enabled INT NOT NULL DEFAULT 0", - 3: "ALTER TABLE playlists ADD smart_sql TEXT" + 3: "ALTER TABLE playlists ADD smart_sql TEXT", + 4: self.__upgrade_4, } +####################### +# PRIVATE # +####################### + def __upgrade_4(self, db): + """ + Import tracks from loved playlist to DB + """ + with SqlCursor(db, True) as sql1: + result = sql1.execute("SELECT uri\ + FROM tracks\ + WHERE playlist_id=?", (Type.LOVED,)) + with SqlCursor(App().db, True) as sql2: + for uri in list(itertools.chain(*result)): + sql2.execute("UPDATE tracks SET loved=1 WHERE uri=?", + (uri,)) + class DatabaseAlbumsUpgrade(DatabaseUpgrade): """ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/lollypop/player_linear.py new/lollypop-0.9.907/lollypop/player_linear.py --- old/lollypop-0.9.906/lollypop/player_linear.py 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/lollypop/player_linear.py 2018-12-22 15:54:58.000000000 +0100 @@ -12,6 +12,7 @@ from lollypop.define import NextContext from lollypop.player_base import BasePlayer +from lollypop.logger import Logger class LinearPlayer(BasePlayer): @@ -38,14 +39,15 @@ # next album if new_track_position >= len(album.track_ids): try: - pos = self._albums.index(album) + pos = self.album_ids.index(album.id) # we are on last album, go to first if pos + 1 >= len(self._albums): self._next_context = NextContext.STOP pos = 0 else: pos += 1 - except: + except Exception as e: + Logger.error("LinearPlayer::next(): %s", e) pos = 0 # Happens if current album has been removed track = self._albums[pos].tracks[0] # next track @@ -66,12 +68,13 @@ # Previous album if new_track_position < 0: try: - pos = self._albums.index(album) + pos = self.album_ids.index(album.id) if pos - 1 < 0: # we are on last album, go to first pos = len(self._albums) - 1 else: pos -= 1 - except: + except Exception as e: + Logger.error("LinearPlayer::prev(): %s", e) pos = 0 # Happens if current album has been removed track = self._albums[pos].tracks[-1] # Previous track diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/lollypop/view_lyrics.py new/lollypop-0.9.907/lollypop/view_lyrics.py --- old/lollypop-0.9.906/lollypop/view_lyrics.py 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/lollypop/view_lyrics.py 2018-12-22 15:54:58.000000000 +0100 @@ -182,7 +182,7 @@ artist = split[0] title = split[1] else: - artist = self.__current_track.artists[0] + artist = self.__current_track.artists title = self.__current_track.name string = escape("%s %s" % (artist, title)) uri = "https://genius.com/%s-lyrics" % string.replace(" ", "-") diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/lollypop/widgets_row.py new/lollypop-0.9.907/lollypop/widgets_row.py --- old/lollypop-0.9.906/lollypop/widgets_row.py 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/lollypop/widgets_row.py 2018-12-22 15:54:58.000000000 +0100 @@ -10,7 +10,7 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see <http://www.gnu.org/licenses/>. -from gi.repository import Gtk, Pango, GLib, Gst +from gi.repository import Gtk, Pango, GLib, Gst, Gdk from lollypop.define import App, RowListType from lollypop.pop_menu import TrackMenuPopover, TrackMenu @@ -284,6 +284,10 @@ App().player.remove_from_queue(self._track.id) else: App().player.append_to_queue(self._track.id) + elif event.state & Gdk.ModifierType.SHIFT_MASK: + App().player.clear_albums() + App().player.reset_history() + App().player.load(self._track) else: self.activate() return True diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/meson.build new/lollypop-0.9.907/meson.build --- old/lollypop-0.9.906/meson.build 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/meson.build 2018-12-22 15:54:58.000000000 +0100 @@ -1,5 +1,5 @@ project('lollypop', - version: '0.9.906', + version: '0.9.907', meson_version: '>= 0.40.0' ) i18n = import('i18n') diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/search-provider/lollypop-sp.in new/lollypop-0.9.907/search-provider/lollypop-sp.in --- old/lollypop-0.9.906/search-provider/lollypop-sp.in 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/search-provider/lollypop-sp.in 2018-12-22 15:54:58.000000000 +0100 @@ -175,16 +175,18 @@ album = Album(int(search_id[2:])) name = " ".join(album.artists) or " " description = album.name - surface = self.art.get_album_artwork(album, ArtSize.BIG, 1) - gicon = self.art.get_album_cache_path(album, ArtSize.BIG) + surface = self.art.get_album_artwork( + album, ArtSize.BIG, ArtSize.BIG, 1) + gicon = self.art.get_album_cache_path( + album, ArtSize.BIG, ArtSize.BIG) else: track = Track(int(search_id[2:])) name = "♫ " + track.name description = " ".join(track.artists) or " " - surface = self.art.get_album_artwork(track.album, - ArtSize.BIG, 1) - gicon = self.art.get_album_cache_path(track.album, - ArtSize.BIG) + surface = self.art.get_album_artwork( + track.album, ArtSize.BIG, ArtSize.BIG, 1) + gicon = self.art.get_album_cache_path( + track.album, ArtSize.BIG, ArtSize.BIG) if surface is not None: del surface d = { 'id': GLib.Variant('s', search_id), diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/subprojects/po/eo.po new/lollypop-0.9.907/subprojects/po/eo.po --- old/lollypop-0.9.906/subprojects/po/eo.po 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/subprojects/po/eo.po 2018-12-22 15:54:58.000000000 +0100 @@ -11,8 +11,8 @@ "Project-Id-Version: lollypop\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-12-17 22:36+0100\n" -"PO-Revision-Date: 2018-12-10 13:08+0000\n" -"Last-Translator: Carmen Bianca Bakker <account@carmenbianca.eu>\n" +"PO-Revision-Date: 2018-12-19 21:08+0000\n" +"Last-Translator: Sebastien Zurfluh <sebastien.zurfluh@gmail.com>\n" "Language-Team: Esperanto <https://hosted.weblate.org/projects/gnumdk/" "lollypop/eo/>\n" "Language: eo\n" @@ -414,31 +414,31 @@ #: ../data/org.gnome.Lollypop.appdata.xml.in:32 msgid "New navigation mode when sidebar is off" -msgstr "" +msgstr "Nova maniero de umado kiam flankpanelo malaktivas" #: ../data/org.gnome.Lollypop.appdata.xml.in:33 msgid "New smart playlists" -msgstr "" +msgstr "Novaj lertaj ludlistoj" #: ../data/org.gnome.Lollypop.appdata.xml.in:34 msgid "Faster album loading" -msgstr "" +msgstr "Plirapida ŝarĝado de albumoj" #: ../data/org.gnome.Lollypop.appdata.xml.in:35 msgid "Faster track loading" -msgstr "" +msgstr "Plirapida ŝarĝado de muzikpecoj" #: ../data/org.gnome.Lollypop.appdata.xml.in:36 msgid "Better sync to device" -msgstr "" +msgstr "Plibona sinkronigado al aparato" #: ../data/org.gnome.Lollypop.appdata.xml.in:37 msgid "Restore playback position on start" -msgstr "" +msgstr "Restarigi la pozicion de la ludado dum startigo" #: ../data/org.gnome.Lollypop.appdata.xml.in:38 msgid "Better adaptive mode: radio support, toolbar buttons, search, ..." -msgstr "" +msgstr "Plibona adaptiĝa reĝimo: subteno de radio, bretaj butonoj, serĉo, ..." #: ../data/org.gnome.Lollypop.desktop.in:4 msgid "Music Player" @@ -584,7 +584,7 @@ #: ../data/LastfmPopover.ui:46 msgid "No results" -msgstr "" +msgstr "Neniuj rezultoj" #: ../data/LyricsView.ui:75 msgid "Translate" @@ -1410,7 +1410,7 @@ #: ../lollypop/view_information.py:167 ../lollypop/view_information.py:236 #, python-format msgid "No information for %s" -msgstr "" +msgstr "Neniu informo por %s" #: ../lollypop/view_information.py:172 ../lollypop/view_information.py:200 msgid "Loading information" @@ -1422,11 +1422,11 @@ #: ../lollypop/view_lyrics.py:130 msgid "You need to install python3-textblob module" -msgstr "" +msgstr "Vi bezonas instali la modulon python3-textblob" #: ../lollypop/view_lyrics.py:135 msgid "Can't translate this lyrics" -msgstr "" +msgstr "Malpovas traduki ĉi-tiujn kantparolojn" #: ../lollypop/view_lyrics.py:260 msgid "No lyrics found " diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/lollypop-0.9.906/subprojects/po/ja.po new/lollypop-0.9.907/subprojects/po/ja.po --- old/lollypop-0.9.906/subprojects/po/ja.po 2018-12-19 19:35:36.000000000 +0100 +++ new/lollypop-0.9.907/subprojects/po/ja.po 2018-12-22 15:54:58.000000000 +0100 @@ -8,9 +8,9 @@ "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2018-12-17 22:36+0100\n" -"PO-Revision-Date: 2018-12-17 13:08+0000\n" -"Last-Translator: YAMADA Shinichirou <yamada_strong_yamada_nice_64bit@yahoo." -"co.jp>\n" +"PO-Revision-Date: 2018-12-19 21:08+0000\n" +"Last-Translator: YAMADA Shinichirou " +"<yamada_strong_yamada_nice_64bit@yahoo.co.jp>\n" "Language-Team: Japanese <https://hosted.weblate.org/projects/gnumdk/lollypop/" "ja/>\n" "Language: ja\n" @@ -582,7 +582,7 @@ #: ../data/LastfmPopover.ui:46 msgid "No results" -msgstr "" +msgstr "結果はありません" #: ../data/LyricsView.ui:75 msgid "Translate" @@ -1406,7 +1406,7 @@ #: ../lollypop/view_information.py:167 ../lollypop/view_information.py:236 #, python-format msgid "No information for %s" -msgstr "" +msgstr "%s の情報はありません" #: ../lollypop/view_information.py:172 ../lollypop/view_information.py:200 msgid "Loading information"