Hello community, here is the log from the commit of package yast2-iscsi-client for openSUSE:Factory checked in at 2015-08-13 18:09:53 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/yast2-iscsi-client (Old) and /work/SRC/openSUSE:Factory/.yast2-iscsi-client.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "yast2-iscsi-client" Changes: -------- --- /work/SRC/openSUSE:Factory/yast2-iscsi-client/yast2-iscsi-client.changes 2015-07-16 17:17:39.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.yast2-iscsi-client.new/yast2-iscsi-client.changes 2015-08-13 18:09:55.000000000 +0200 @@ -1,0 +2,7 @@ +Thu Jul 30 12:06:28 CEST 2015 - gs@suse.de + +- show error popup if target connection failed (bsc#9339537) +- rename Log In/Log Out to Connect/Disconnect (bsc#939529) +- 3.1.23 + +------------------------------------------------------------------- Old: ---- yast2-iscsi-client-3.1.22.tar.bz2 New: ---- yast2-iscsi-client-3.1.23.tar.bz2 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ yast2-iscsi-client.spec ++++++ --- /var/tmp/diff_new_pack.64ftku/_old 2015-08-13 18:09:56.000000000 +0200 +++ /var/tmp/diff_new_pack.64ftku/_new 2015-08-13 18:09:56.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-iscsi-client -Version: 3.1.22 +Version: 3.1.23 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build ++++++ yast2-iscsi-client-3.1.22.tar.bz2 -> yast2-iscsi-client-3.1.23.tar.bz2 ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-client-3.1.22/.travis.yml new/yast2-iscsi-client-3.1.23/.travis.yml --- old/yast2-iscsi-client-3.1.22/.travis.yml 2015-07-01 11:37:38.000000000 +0200 +++ new/yast2-iscsi-client-3.1.23/.travis.yml 2015-08-11 15:47:11.000000000 +0200 @@ -5,7 +5,7 @@ # disable rvm, use system Ruby - rvm reset - wget https://raw.githubusercontent.com/yast/yast-devtools/master/travis-tools/tra... - - sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2" -g "rspec:2.14.1 yast-rake gettext" + - sh ./travis_setup.sh -p "rake yast2-devtools yast2-testsuite yast2" -g "rspec:3.3.0 yast-rake gettext" script: - rake check:syntax - rake check:pot diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-client-3.1.22/package/yast2-iscsi-client.changes new/yast2-iscsi-client-3.1.23/package/yast2-iscsi-client.changes --- old/yast2-iscsi-client-3.1.22/package/yast2-iscsi-client.changes 2015-07-01 11:37:38.000000000 +0200 +++ new/yast2-iscsi-client-3.1.23/package/yast2-iscsi-client.changes 2015-08-11 15:47:11.000000000 +0200 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Thu Jul 30 12:06:28 CEST 2015 - gs@suse.de + +- show error popup if target connection failed (bsc#9339537) +- rename Log In/Log Out to Connect/Disconnect (bsc#939529) +- 3.1.23 + +------------------------------------------------------------------- Thu Jun 18 14:22:05 CEST 2015 - gs@suse.de - warn only once about non-standard initiator name (bsc#926621) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-client-3.1.22/package/yast2-iscsi-client.spec new/yast2-iscsi-client-3.1.23/package/yast2-iscsi-client.spec --- old/yast2-iscsi-client-3.1.22/package/yast2-iscsi-client.spec 2015-07-01 11:37:38.000000000 +0200 +++ new/yast2-iscsi-client-3.1.23/package/yast2-iscsi-client.spec 2015-08-11 15:47:11.000000000 +0200 @@ -17,7 +17,7 @@ Name: yast2-iscsi-client -Version: 3.1.22 +Version: 3.1.23 Release: 0 BuildRoot: %{_tmppath}/%{name}-%{version}-build diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-client-3.1.22/src/include/iscsi-client/dialogs.rb new/yast2-iscsi-client-3.1.23/src/include/iscsi-client/dialogs.rb --- old/yast2-iscsi-client-3.1.22/src/include/iscsi-client/dialogs.rb 2015-07-01 11:37:38.000000000 +0200 +++ new/yast2-iscsi-client-3.1.23/src/include/iscsi-client/dialogs.rb 2015-08-11 15:47:11.000000000 +0200 @@ -158,7 +158,7 @@ HBox( PushButton(Id(:add), _("Add")), # `PushButton(`id(`toggle), _("Toggle Start-Up")) PushButton(Id(:edit), _("Edit")), - PushButton(Id(:del), _("Log Out")) + PushButton(Id(:del), _("Disconnect")) ) ) ), @@ -190,7 +190,7 @@ Left( HBox( PushButton(Id(:discovery), _("Discovery")), - PushButton(Id(:connect), _("Log In")), + PushButton(Id(:connect), _("Connect")), PushButton(Id(:delete), Label.DeleteButton) ) ) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-client-3.1.22/src/include/iscsi-client/helps.rb new/yast2-iscsi-client-3.1.23/src/include/iscsi-client/helps.rb --- old/yast2-iscsi-client-3.1.22/src/include/iscsi-client/helps.rb 2015-07-01 11:37:38.000000000 +0200 +++ new/yast2-iscsi-client-3.1.23/src/include/iscsi-client/helps.rb 2015-08-11 15:47:11.000000000 +0200 @@ -92,7 +92,7 @@ "<p>Use the <b>Add</b> button to get additional targets. A discovery is started to " \ "detect new targets and the start-up mode of already connected targets keeps " \ "unchanged.<br>" \ - "Use <b>Log Out</b> to cancel the connection and with it remove the target from the list.<br>" \ + "Use <b>Disconnect</b> to cancel the connection and with it remove the target from the list.<br>" \ "To change the start-up status, press <b>Edit</b>.</p>" ) + # Warning @@ -152,12 +152,12 @@ "<p>This screen shows the list of discovered targets.</p>" \ "<p>Use the <b>Discovery</b> button to get available iSCSI targets " \ "from a server specified by IP address.<br>" \ - "<b>Log In</b> to a target to establih the connection. If login was successful " \ + "<b>Connect</b> to a target to establih the connection. If login was successful " \ "the column <i>Connected</i> shows status 'True' and the target will appear on " \ "the <i>Connected Targets</i> screen.<br>" \ "To remove a target use the <b>Delete</b> button.<br> <b>Hint:</b> " \ "Removing of targets is only possible for not connected onces. " \ - "If required, <b>Log Out</b> at <i>Connected Targets</i> first.</p>" \ + "If required, <b>Disconnect</b> at <i>Connected Targets</i> first.</p>" \ "<p><b>Please note:</b> Starting the <b>Discovery</b> again means doing a re-discovery " \ "of targets which possibly will change the start-up mode of already connected targets " \ "(to default 'manual'). " \ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/yast2-iscsi-client-3.1.22/src/modules/IscsiClientLib.rb new/yast2-iscsi-client-3.1.23/src/modules/IscsiClientLib.rb --- old/yast2-iscsi-client-3.1.22/src/modules/IscsiClientLib.rb 2015-07-01 11:37:38.000000000 +0200 +++ new/yast2-iscsi-client-3.1.23/src/modules/IscsiClientLib.rb 2015-08-11 15:47:11.000000000 +0200 @@ -1008,6 +1008,11 @@ :to => "map <string, any>" ) Builtins.y2internal("output %1", output) + + if (output["exit"] || -1) != 0 + Report.Error( _("Target connection failed.\n") + + output["stderr"] || "" ) + end # if (output["exit"]:-1==0){ # set startup status to auto by default (bnc#400610) setStartupStatus("onboot") if !Mode.autoinst