![](https://seccdn.libravatar.org/avatar/e2145bc5cf53dda95c308a3c75e8fef3.jpg?s=120&d=mm&r=g)
Hello community, here is the log from the commit of package perl-MooseX-Role-Parameterized for openSUSE:Factory checked in at 2011-12-21 10:02:29 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Comparing /work/SRC/openSUSE:Factory/perl-MooseX-Role-Parameterized (Old) and /work/SRC/openSUSE:Factory/.perl-MooseX-Role-Parameterized.new (New) ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Package is "perl-MooseX-Role-Parameterized", Maintainer is "" Changes: -------- --- /work/SRC/openSUSE:Factory/perl-MooseX-Role-Parameterized/perl-MooseX-Role-Parameterized.changes 2011-09-23 12:38:12.000000000 +0200 +++ /work/SRC/openSUSE:Factory/.perl-MooseX-Role-Parameterized.new/perl-MooseX-Role-Parameterized.changes 2011-12-21 10:02:31.000000000 +0100 @@ -1,0 +2,10 @@ +Mon Dec 19 15:38:03 UTC 2011 - coolo@suse.de + +- update to 0.27 + * Remove MooseX::Role::Parameterized::Meta::Parameter; instead, + the default for parameters of (is => 'ro') is set by the + "parameter" sugar. This removes an unnecessary metaclass and + removes weird edge cases caused by it. Please please please + report any breakage! + +------------------------------------------------------------------- Old: ---- MooseX-Role-Parameterized-0.26.tar.gz New: ---- MooseX-Role-Parameterized-0.27.tar.gz ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ Other differences: ------------------ ++++++ perl-MooseX-Role-Parameterized.spec ++++++ --- /var/tmp/diff_new_pack.twL0ro/_old 2011-12-21 10:02:32.000000000 +0100 +++ /var/tmp/diff_new_pack.twL0ro/_new 2011-12-21 10:02:32.000000000 +0100 @@ -16,15 +16,14 @@ # - Name: perl-MooseX-Role-Parameterized -Version: 0.26 -Release: 1 -License: GPL+ or Artistic +Version: 0.27 +Release: 0 %define cpan_name MooseX-Role-Parameterized Summary: Roles with composition parameters -Url: http://search.cpan.org/dist/MooseX-Role-Parameterized/ +License: GPL-1.0+ or Artistic-1.0 Group: Development/Libraries/Perl +Url: http://search.cpan.org/dist/MooseX-Role-Parameterized/ Source: http://www.cpan.org/authors/id/S/SA/SARTAK/%{cpan_name}-%{version}.tar.gz Patch1: perl-MooseX-Role-Parameterized-old_Test_More.patch BuildArch: noarch ++++++ MooseX-Role-Parameterized-0.26.tar.gz -> MooseX-Role-Parameterized-0.27.tar.gz ++++++ diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/Changes new/MooseX-Role-Parameterized-0.27/Changes --- old/MooseX-Role-Parameterized-0.26/Changes 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/Changes 2011-08-22 20:58:49.000000000 +0200 @@ -1,5 +1,12 @@ Changes for MooseX-Role-Parameterized +0.27 August 22, 2011 + * Remove MooseX::Role::Parameterized::Meta::Parameter; instead, + the default for parameters of (is => 'ro') is set by the + "parameter" sugar. This removes an unnecessary metaclass and + removes weird edge cases caused by it. Please please please + report any breakage! + 0.26 March 20, 2011 * make tests stop relying on a specific format for anon class/role names (doy) diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/MANIFEST new/MooseX-Role-Parameterized-0.27/MANIFEST --- old/MooseX-Role-Parameterized-0.26/MANIFEST 2011-04-20 19:29:13.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/MANIFEST 2011-08-22 20:59:12.000000000 +0200 @@ -1,16 +1,17 @@ Changes inc/Module/Install.pm +inc/Module/Install/AutoManifest.pm inc/Module/Install/Base.pm inc/Module/Install/Can.pm inc/Module/Install/Fetch.pm inc/Module/Install/GithubMeta.pm inc/Module/Install/Makefile.pm +inc/Module/Install/ManifestSkip.pm inc/Module/Install/Metadata.pm inc/Module/Install/Win32.pm inc/Module/Install/WriteAll.pm lib/MooseX/Role/Parameterized.pm lib/MooseX/Role/Parameterized/Extending.pod -lib/MooseX/Role/Parameterized/Meta/Parameter.pm lib/MooseX/Role/Parameterized/Meta/Role/Parameterizable.pm lib/MooseX/Role/Parameterized/Meta/Role/Parameterized.pm lib/MooseX/Role/Parameterized/Meta/Trait/Parameterized.pm @@ -39,6 +40,7 @@ t/018-parameter-roles.t t/019-custom-metaclass.t t/020-metaclass-reinitialize.t +t/021-parameter-trait.t t/100-erroneous-keywords.t t/101-alias-excludes.t t/102-nested.t diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/META.yml new/MooseX-Role-Parameterized-0.27/META.yml --- old/MooseX-Role-Parameterized-0.26/META.yml 2011-04-20 19:27:59.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/META.yml 2011-08-22 20:58:54.000000000 +0200 @@ -10,7 +10,7 @@ configure_requires: ExtUtils::MakeMaker: 6.42 distribution_type: module -generated_by: 'Module::Install version 1.00' +generated_by: 'Module::Install version 1.01' license: perl meta-spec: url: http://module-build.sourceforge.net/META-spec-v1.4.html @@ -26,5 +26,8 @@ resources: homepage: http://github.com/sartak/MooseX-Role-Parameterized/tree license: http://dev.perl.org/licenses/ - repository: git://github.com/sartak/MooseX-Role-Parameterized.git -version: 0.26 + repository: + type: git + url: git://github.com/sartak/MooseX-Role-Parameterized.git + web: http://github.com/sartak/MooseX-Role-Parameterized/tree +version: 0.27 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/Makefile.PL new/MooseX-Role-Parameterized-0.27/Makefile.PL --- old/MooseX-Role-Parameterized-0.26/Makefile.PL 2011-04-20 19:26:54.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/Makefile.PL 2011-08-22 20:58:49.000000000 +0200 @@ -1,6 +1,8 @@ # Load the Module::Install bundled in ./inc/ use inc::Module::Install; use Module::Install::GithubMeta; +use Module::Install::ManifestSkip; +use Module::Install::AutoManifest; # Define metadata name 'MooseX-Role-Parameterized'; @@ -12,6 +14,7 @@ test_requires 'Test::More' => '0.96'; test_requires 'Test::Fatal'; +manifest_skip; +auto_manifest; WriteAll; - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/AutoManifest.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/AutoManifest.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/AutoManifest.pm 1970-01-01 01:00:00.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/AutoManifest.pm 2011-08-22 20:58:53.000000000 +0200 @@ -0,0 +1,45 @@ +#line 1 +use strict; +use warnings; + +package Module::Install::AutoManifest; + +use Module::Install::Base; + +BEGIN { + our $VERSION = '0.003'; + our $ISCORE = 1; + our @ISA = qw(Module::Install::Base); +} + +sub auto_manifest { + my ($self) = @_; + + return unless $Module::Install::AUTHOR; + + die "auto_manifest requested, but no MANIFEST.SKIP exists\n" + unless -e "MANIFEST.SKIP"; + + if (-e "MANIFEST") { + unlink('MANIFEST') or die "Can't remove MANIFEST: $!"; + } + + $self->postamble(<<"END"); +create_distdir: manifest_clean manifest + +distclean :: manifest_clean + +manifest_clean: +\t\$(RM_F) MANIFEST +END + +} + +1; +__END__ + +#line 48 + +#line 131 + +1; # End of Module::Install::AutoManifest diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Base.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Base.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Base.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Base.pm 2011-08-22 20:58:53.000000000 +0200 @@ -4,7 +4,7 @@ use strict 'vars'; use vars qw{$VERSION}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; } # Suspend handler for "redefined" warnings diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Can.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Can.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Can.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Can.pm 2011-08-22 20:58:53.000000000 +0200 @@ -9,7 +9,7 @@ use vars qw{$VERSION @ISA $ISCORE}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; @ISA = 'Module::Install::Base'; $ISCORE = 1; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Fetch.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Fetch.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Fetch.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Fetch.pm 2011-08-22 20:58:53.000000000 +0200 @@ -6,7 +6,7 @@ use vars qw{$VERSION @ISA $ISCORE}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; @ISA = 'Module::Install::Base'; $ISCORE = 1; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/GithubMeta.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/GithubMeta.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/GithubMeta.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/GithubMeta.pm 2011-08-22 20:58:53.000000000 +0200 @@ -7,7 +7,7 @@ use base qw(Module::Install::Base); use vars qw($VERSION); -$VERSION = '0.10'; +$VERSION = '0.12'; sub githubmeta { my $self = shift; @@ -20,7 +20,13 @@ $git_url =~ s![\w\-]+\@([^:]+):!git://$1/!; $http_url =~ s![\w\-]+\@([^:]+):!http://$1/!; $http_url =~ s!\.git$!/tree!; - $self->repository( $git_url ); + $self->repository( + { + type => 'git', + url => $git_url, + web => $http_url, + }, + ); $self->homepage( $http_url ) unless $self->homepage(); return 1; } @@ -47,4 +53,4 @@ 'Github'; __END__ -#line 108 +#line 114 diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Makefile.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Makefile.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Makefile.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Makefile.pm 2011-08-22 20:58:53.000000000 +0200 @@ -8,7 +8,7 @@ use vars qw{$VERSION @ISA $ISCORE}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; @ISA = 'Module::Install::Base'; $ISCORE = 1; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/ManifestSkip.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/ManifestSkip.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/ManifestSkip.pm 1970-01-01 01:00:00.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/ManifestSkip.pm 2011-08-22 20:58:53.000000000 +0200 @@ -0,0 +1,48 @@ +#line 1 +## +# name: Module::Install::ManifestSkip +# abstract: Generate a MANIFEST.SKIP file +# author: Ingy döt Net <ingy@cpan.org> +# license: perl +# copyright: 2010, 2011 +# see: +# - Module::Manifest::Skip + +package Module::Install::ManifestSkip; +use 5.008003; +use strict; +use warnings; + +use base 'Module::Install::Base'; + +my $requires = " +use Module::Manifest::Skip 0.10 (); +"; + +our $VERSION = '0.19'; +our $AUTHOR_ONLY = 1; + +my $skip_file = "MANIFEST.SKIP"; + +sub manifest_skip { + my $self = shift; + return unless $self->is_admin; + + eval $requires; die $@ if $@; + + print "Writing $skip_file\n"; + + open OUT, '>', $skip_file + or die "Can't open $skip_file for output: $!";; + + print OUT Module::Manifest::Skip->new->text; + + close OUT; + + $self->clean_files('MANIFEST'); + $self->clean_files($skip_file) + if grep /^clean$/, @_; +} + +1; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Metadata.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Metadata.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Metadata.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Metadata.pm 2011-08-22 20:58:53.000000000 +0200 @@ -6,7 +6,7 @@ use vars qw{$VERSION @ISA $ISCORE}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; @ISA = 'Module::Install::Base'; $ISCORE = 1; } @@ -515,6 +515,7 @@ 'GNU Free Documentation license' => 'unrestricted', 1, 'GNU Affero General Public License' => 'open_source', 1, '(?:Free)?BSD license' => 'bsd', 1, + 'Artistic license 2\.0' => 'artistic_2', 1, 'Artistic license' => 'artistic', 1, 'Apache (?:Software )?license' => 'apache', 1, 'GPL' => 'gpl', 1, @@ -550,9 +551,9 @@ sub _extract_bugtracker { my @links = $_[0] =~ m#L<( - \Qhttp://rt.cpan.org/\E[^>]+| - \Qhttp://github.com/\E[\w_]+/[\w_]+/issues| - \Qhttp://code.google.com/p/\E[\w_\-]+/issues/list + https?\Q://rt.cpan.org/\E[^>]+| + https?\Q://github.com/\E[\w_]+/[\w_]+/issues| + https?\Q://code.google.com/p/\E[\w_\-]+/issues/list )>#gx; my %links; @links{@links}=(); diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Win32.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Win32.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/Win32.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/Win32.pm 2011-08-22 20:58:53.000000000 +0200 @@ -6,7 +6,7 @@ use vars qw{$VERSION @ISA $ISCORE}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; @ISA = 'Module::Install::Base'; $ISCORE = 1; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install/WriteAll.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install/WriteAll.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install/WriteAll.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install/WriteAll.pm 2011-08-22 20:58:53.000000000 +0200 @@ -6,7 +6,7 @@ use vars qw{$VERSION @ISA $ISCORE}; BEGIN { - $VERSION = '1.00'; + $VERSION = '1.01'; @ISA = qw{Module::Install::Base}; $ISCORE = 1; } diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/inc/Module/Install.pm new/MooseX-Role-Parameterized-0.27/inc/Module/Install.pm --- old/MooseX-Role-Parameterized-0.26/inc/Module/Install.pm 2011-04-20 19:27:58.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/inc/Module/Install.pm 2011-08-22 20:58:53.000000000 +0200 @@ -31,7 +31,7 @@ # This is not enforced yet, but will be some time in the next few # releases once we can make sure it won't clash with custom # Module::Install extensions. - $VERSION = '1.00'; + $VERSION = '1.01'; # Storage for the pseudo-singleton $MAIN = undef; @@ -467,4 +467,4 @@ 1; -# Copyright 2008 - 2010 Adam Kennedy. +# Copyright 2008 - 2011 Adam Kennedy. diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Parameter.pm new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Parameter.pm --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Parameter.pm 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Parameter.pm 1970-01-01 01:00:00.000000000 +0100 @@ -1,44 +0,0 @@ -package MooseX::Role::Parameterized::Meta::Parameter; -use Moose; -extends 'Moose::Meta::Attribute'; - -our $VERSION = '0.26'; - -# This doesn't actually do anything because _process_options does not consult -# the default value of "is". hrm. -has '+is' => ( - default => 'ro', -); - -around _process_options => sub { - my $orig = shift; - my ($class, $name, $options) = @_; - - $options->{is} ||= 'ro'; - - $orig->(@_); -}; - -__PACKAGE__->meta->make_immutable( - inline_constructor => 1, - replace_constructor => 1, - constructor_name => "_new", -); -no Moose; - -1; - -__END__ - -=head1 NAME - -MooseX::Role::Parameterized::Meta::Parameter - metaclass for parameters - -=head1 DESCRIPTION - -This is the metaclass for parameter objects, a subclass of -L<Moose::Meta::Attribute>. Its sole purpose is to make the default value -of the C<is> option C<ro>. - -=cut - diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Role/Parameterizable.pm new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Role/Parameterizable.pm --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Role/Parameterizable.pm 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Role/Parameterizable.pm 2011-08-22 20:58:49.000000000 +0200 @@ -2,14 +2,12 @@ use Moose; extends 'Moose::Meta::Role'; -our $VERSION = '0.26'; +our $VERSION = '0.27'; use MooseX::Role::Parameterized::Meta::Role::Parameterized; -use MooseX::Role::Parameterized::Meta::Parameter; use MooseX::Role::Parameterized::Parameters; use constant parameterized_role_metaclass => 'MooseX::Role::Parameterized::Meta::Role::Parameterized'; -use constant parameter_metaclass => 'MooseX::Role::Parameterized::Meta::Parameter'; has parameters_class => ( is => 'ro', @@ -25,8 +23,7 @@ my $self = shift; $self->parameters_class->meta->create_anon_class( - superclasses => [$self->parameters_class], - attribute_metaclass => $self->parameter_metaclass, + superclasses => [$self->parameters_class], ); }, handles => { @@ -47,7 +44,6 @@ confess "You must provide a name for the parameter" if !defined($name); - # need to figure out a plan for these guys.. confess "The parameter name ($name) is currently forbidden" if $name eq 'alias' || $name eq 'excludes'; @@ -59,7 +55,6 @@ my $self = shift; my %args = @_; - # need to figure out a plan for these guys.. for my $name ('alias', 'excludes') { confess "The parameter name ($name) is currently forbidden" if exists $args{$name}; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Role/Parameterized.pm new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Role/Parameterized.pm --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Role/Parameterized.pm 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Role/Parameterized.pm 2011-08-22 20:58:49.000000000 +0200 @@ -3,7 +3,7 @@ extends 'Moose::Meta::Role'; with 'MooseX::Role::Parameterized::Meta::Trait::Parameterized'; -our $VERSION = '0.26'; +our $VERSION = '0.27'; __PACKAGE__->meta->make_immutable; no Moose; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Trait/Parameterized.pm new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Trait/Parameterized.pm --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Meta/Trait/Parameterized.pm 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Meta/Trait/Parameterized.pm 2011-08-22 20:58:49.000000000 +0200 @@ -1,7 +1,7 @@ package MooseX::Role::Parameterized::Meta::Trait::Parameterized; use Moose::Role; -our $VERSION = '0.26'; +our $VERSION = '0.27'; use MooseX::Role::Parameterized::Parameters; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Parameters.pm new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Parameters.pm --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Parameters.pm 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Parameters.pm 2011-08-22 20:58:49.000000000 +0200 @@ -1,7 +1,7 @@ package MooseX::Role::Parameterized::Parameters; use Moose; -our $VERSION = '0.26'; +our $VERSION = '0.27'; __PACKAGE__->meta->make_immutable; no Moose; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Tutorial.pod new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Tutorial.pod --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized/Tutorial.pod 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized/Tutorial.pod 2011-04-22 22:28:58.000000000 +0200 @@ -11,14 +11,15 @@ L<Moose::Cookbook::Roles::Recipe1> for an introduction to L<Moose::Role>. While combining roles affords you a great deal of flexibility, individual roles -have very little in the way of configurability. Core Moose provides C<alias> -for renaming methods and C<excludes> for ignoring methods. These options are -primarily (perhaps solely) for resolving role conflicts. See -L<Moose::Cookbook::Roles::Recipe2> for more about C<alias> and C<excludes>. +have very little in the way of configurability. Core Moose provides C<-alias> +for renaming methods and C<-excludes> for ignoring methods. These options are +primarily for resolving role conflicts. Depending on how much of a purist you are, +these options are I<solely> for resolving role conflicts. See +L<Moose::Cookbook::Roles::Recipe2> for more about C<-alias> and C<-excludes>. Because roles serve many different masters, they usually provide only the least common denominator of functionality. To empower roles further, more -configurability than C<alias> and C<excludes> is required. Perhaps your role +configurability than C<-alias> and C<-excludes> is required. Perhaps your role needs to know which method to call when it is done processing. Or what default value to use for its C<url> attribute. @@ -29,8 +30,9 @@ =head3 C<with> The syntax of a class consuming a parameterized role has not changed from the -standard C<with>. You pass in parameters just like you pass in C<alias> and -C<excludes> to ordinary roles: +standard C<with>. You pass in parameters just like you pass in C<-alias> and +C<-excludes> to ordinary roles (though without hyphens, since these are not +core Moose composition parameters): with 'MyRole::InstrumentMethod' => { method_name => 'dbh_do', diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized.pm new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized.pm --- old/MooseX-Role-Parameterized-0.26/lib/MooseX/Role/Parameterized.pm 2011-04-20 19:27:56.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/lib/MooseX/Role/Parameterized.pm 2011-08-22 20:58:49.000000000 +0200 @@ -7,7 +7,7 @@ use MooseX::Role::Parameterized::Meta::Role::Parameterizable; -our $VERSION = '0.26'; +our $VERSION = '0.27'; our $CURRENT_METACLASS; Moose::Exporter->setup_import_methods( @@ -31,7 +31,10 @@ $names = [$names] if !ref($names); for my $name (@$names) { - $meta->add_parameter($name, @_); + $meta->add_parameter($name => ( + is => 'ro', + @_, + )); } } @@ -250,11 +253,6 @@ C<< method NAME => sub { ... }; >>. This is due to a limitation in Perl. In return though you can use parameters I<in your methods>! -L<Moose::Role/alias> and L<Moose::Role/excludes> are not yet supported. I'm -completely unsure of whether they should be handled by this module. Until we -figure out a plan, either declaring or providing a parameter named C<alias> or -C<excludes> is an error. - =head1 AUTHOR Shawn M Moore, C<sartak@gmail.com> diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/001-parameters.t new/MooseX-Role-Parameterized-0.27/t/001-parameters.t --- old/MooseX-Role-Parameterized-0.26/t/001-parameters.t 2010-11-26 20:50:50.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/001-parameters.t 2011-08-11 19:21:51.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 16; +use Test::More; use Test::Fatal; use MooseX::Role::Parameterized::Parameters; @@ -31,7 +31,6 @@ is($parameters_metaclass->get_all_attributes, 1, "exactly one parameter"); my $parameter = ($parameters_metaclass->get_all_attributes)[0]; -isa_ok($parameter, 'MooseX::Role::Parameterized::Meta::Parameter'); is($parameter->name, 'length', "parameter name"); ok($parameter->is_required, "parameter is required"); @@ -71,3 +70,5 @@ ok(!$param->is_required, "$param_name is optional"); } +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/002-role-block.t new/MooseX-Role-Parameterized-0.27/t/002-role-block.t --- old/MooseX-Role-Parameterized-0.26/t/002-role-block.t 2010-11-26 20:54:04.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/002-role-block.t 2011-04-22 22:53:40.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 3; +use Test::More; my ($parameters, %args); @@ -32,7 +32,6 @@ ok(MyPerson->meta->has_role_generator, "MyPerson has a role generator"); subtest "generation of an anonymous role" => sub { - plan tests => 8; my $role = MyPerson->meta->generate_role( parameters => { default_age => 7, @@ -57,8 +56,6 @@ }; subtest "generating a role with a provided name" => sub { - plan tests => 8; - my $role = MyPerson->meta->generate_role( package => 'RJBS::Was::Here', parameters => { @@ -82,3 +79,6 @@ is($birthday_method->name, 'birthday', "method name"); is($birthday_method->package_name, $role->name, "package name"); }; + +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/003-apply.t new/MooseX-Role-Parameterized-0.27/t/003-apply.t --- old/MooseX-Role-Parameterized-0.26/t/003-apply.t 2010-11-26 20:50:50.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/003-apply.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 22; +use Test::More; use Test::Fatal; my %args; @@ -155,3 +155,5 @@ } } +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/004-with.t new/MooseX-Role-Parameterized-0.27/t/004-with.t --- old/MooseX-Role-Parameterized-0.26/t/004-with.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/004-with.t 2011-08-22 20:24:19.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 6; +use Test::More; do { package MyItem::Role::Wearable; @@ -62,3 +62,5 @@ ok(!$utility->is_worn); is($utility->slot, 'waist'); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/005-with-parameterized.t new/MooseX-Role-Parameterized-0.27/t/005-with-parameterized.t --- old/MooseX-Role-Parameterized-0.26/t/005-with-parameterized.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/005-with-parameterized.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 6; +use Test::More; do { package MyItem::Role::Wearable; @@ -82,3 +82,5 @@ ok($chastity->is_worn, "default for belt is worn"); is($chastity->slot, 'waist'); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/006-requires.t new/MooseX-Role-Parameterized-0.27/t/006-requires.t --- old/MooseX-Role-Parameterized-0.26/t/006-requires.t 2011-04-20 19:23:41.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/006-requires.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 5; +use Test::More; use Test::Fatal; do { @@ -84,3 +84,5 @@ ); }, undef); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/007-excludes.t new/MooseX-Role-Parameterized-0.27/t/007-excludes.t --- old/MooseX-Role-Parameterized-0.26/t/007-excludes.t 2011-04-20 19:23:41.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/007-excludes.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 3; +use Test::More; use Test::Fatal; do { @@ -56,3 +56,5 @@ ); }, undef); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/008-method-modifers.t new/MooseX-Role-Parameterized-0.27/t/008-method-modifers.t --- old/MooseX-Role-Parameterized-0.26/t/008-method-modifers.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/008-method-modifers.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 2; +use Test::More; my @calls; @@ -48,3 +48,5 @@ MyClass->new; is_deeply([splice @calls], ["calling new", "took 0 seconds", "called new"], "instrumented new"); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/009-override-super.t new/MooseX-Role-Parameterized-0.27/t/009-override-super.t --- old/MooseX-Role-Parameterized-0.26/t/009-override-super.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/009-override-super.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 2; +use Test::More; my @calls; @@ -38,3 +38,5 @@ MyClass->new; is_deeply([splice @calls], ["calling new", "called new"], "instrumented new"); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/010-blessed-confess.t new/MooseX-Role-Parameterized-0.27/t/010-blessed-confess.t --- old/MooseX-Role-Parameterized-0.26/t/010-blessed-confess.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/010-blessed-confess.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 2; +use Test::More; do { package MyRole; @@ -10,3 +10,5 @@ ::is(\&blessed, \&Scalar::Util::blessed, 'blessed'); }; +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/011-reference-parameters.t new/MooseX-Role-Parameterized-0.27/t/011-reference-parameters.t --- old/MooseX-Role-Parameterized-0.26/t/011-reference-parameters.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/011-reference-parameters.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 8; +use Test::More; do { package MyRole::Delegator; @@ -75,3 +75,5 @@ } } +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/012-rename-role.t new/MooseX-Role-Parameterized-0.27/t/012-rename-role.t --- old/MooseX-Role-Parameterized-0.26/t/012-rename-role.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/012-rename-role.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 1; +use Test::More; do { package MyRole; @@ -18,3 +18,5 @@ my $role = MyRole->meta->generate_role; ok($role->has_method('ok'), "renaming the role block export works"); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/013-does.t new/MooseX-Role-Parameterized-0.27/t/013-does.t --- old/MooseX-Role-Parameterized-0.26/t/013-does.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/013-does.t 2011-04-22 22:55:32.000000000 +0200 @@ -1,8 +1,7 @@ - +#!/usr/bin/env perl use strict; use warnings; - -use Test::More tests => 3; +use Test::More; use Test::Moose; { @@ -27,3 +26,5 @@ 'generated role does the parameterized role' ); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/014-compose-parameterizable.t new/MooseX-Role-Parameterized-0.27/t/014-compose-parameterizable.t --- old/MooseX-Role-Parameterized-0.26/t/014-compose-parameterizable.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/014-compose-parameterizable.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 2; +use Test::More; do { package MyRole; @@ -33,3 +33,5 @@ ok(MyClass->can('attr'), "the parameterized attribute was composed"); ok(MyClass->can('meth'), "the unparameterized method was composed"); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/015-compose-keywords.t new/MooseX-Role-Parameterized-0.27/t/015-compose-keywords.t --- old/MooseX-Role-Parameterized-0.26/t/015-compose-keywords.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/015-compose-keywords.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 20; +use Test::More; do { package OtherRole; @@ -47,3 +47,5 @@ ok($meta->excludes_role('exclusion'), 'excludes'); } +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/016-trait.t new/MooseX-Role-Parameterized-0.27/t/016-trait.t --- old/MooseX-Role-Parameterized-0.26/t/016-trait.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/016-trait.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 2; +use Test::More; do { package MyTrait::Label; @@ -51,3 +51,5 @@ is(MyClass::LabeledURL->meta->get_attribute('url')->label, 'yay'); is(MyClass::LabeledURL::Redux->meta->get_attribute('url')->label, 'overridden'); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/017-current_metaclass.t new/MooseX-Role-Parameterized-0.27/t/017-current_metaclass.t --- old/MooseX-Role-Parameterized-0.26/t/017-current_metaclass.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/017-current_metaclass.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 7; +use Test::More; do { package Labeled; @@ -43,3 +43,5 @@ ::is(MooseX::Role::Parameterized->current_metaclass, undef, 'metaclass is gone now'); }; +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/018-parameter-roles.t new/MooseX-Role-Parameterized-0.27/t/018-parameter-roles.t --- old/MooseX-Role-Parameterized-0.26/t/018-parameter-roles.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/018-parameter-roles.t 2011-08-11 19:21:51.000000000 +0200 @@ -2,7 +2,7 @@ use strict; use warnings; use Test::More skip_all => "Not implemented yet"; -#use Test::More tests => 7; +#use Test::More; { package Test::Role; @@ -20,7 +20,6 @@ method foo => sub { "hello " . $p->name }; has blech => ( - metaclass => "MooseX::Role::Parameterized::Meta::Parameter", isa => "Str", is => "ro", required => 1, @@ -59,3 +58,6 @@ is( $p->blech, "yes" ); is( $p->foo, "hello foo" ); + +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/019-custom-metaclass.t new/MooseX-Role-Parameterized-0.27/t/019-custom-metaclass.t --- old/MooseX-Role-Parameterized-0.26/t/019-custom-metaclass.t 2010-09-26 05:22:53.000000000 +0200 +++ new/MooseX-Role-Parameterized-0.27/t/019-custom-metaclass.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 1; +use Test::More; use Test::Moose; do { @@ -43,3 +43,6 @@ }; MyClass->new; + +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/020-metaclass-reinitialize.t new/MooseX-Role-Parameterized-0.27/t/020-metaclass-reinitialize.t --- old/MooseX-Role-Parameterized-0.26/t/020-metaclass-reinitialize.t 2011-03-01 06:45:00.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/020-metaclass-reinitialize.t 2011-08-22 20:53:53.000000000 +0200 @@ -2,14 +2,12 @@ use strict; use warnings; use Test::More; + BEGIN { require Moose; if (Moose->VERSION < 1.9900) { plan skip_all => "this test isn't relevant on Moose 1.x"; } - else { - plan tests => 1; - } } { @@ -52,3 +50,6 @@ is(Foo->meta->find_attribute_by_name('foo')->foo, 'bar', "applied_attribute metaroles work"); } + +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/021-parameter-trait.t new/MooseX-Role-Parameterized-0.27/t/021-parameter-trait.t --- old/MooseX-Role-Parameterized-0.26/t/021-parameter-trait.t 1970-01-01 01:00:00.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/021-parameter-trait.t 2011-08-06 23:55:27.000000000 +0200 @@ -0,0 +1,48 @@ +#!/usr/bin/env perl +use strict; +use warnings; +use Test::More; + +do { + package MyTrait::Labeled; + use Moose::Role; + + has label => ( + is => 'ro', + isa => 'Str', + ); +}; + +do { + package P::Role; + use MooseX::Role::Parameterized; + + parameter favorite => ( + traits => ['MyTrait::Labeled'], + label => 'FAVE', + isa => 'Str', + ); + + role { + my $p = shift; + + method faves => sub { $p->meta->get_attribute('favorite')->label . ': ' . $p->favorite }; + } +}; + +do { + package Class::P::d; + use Moose; + with 'P::Role' => { favorite => 'ether' }; +}; + +do { + package Other::Class::P::d; + use Moose; + with 'P::Role' => { favorite => 'karen' }; +}; + +is(Class::P::d->faves, 'FAVE: ether'); +is(Other::Class::P::d->faves, 'FAVE: karen'); + +done_testing; diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/100-erroneous-keywords.t new/MooseX-Role-Parameterized-0.27/t/100-erroneous-keywords.t --- old/MooseX-Role-Parameterized-0.26/t/100-erroneous-keywords.t 2010-11-26 20:50:50.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/100-erroneous-keywords.t 2011-08-22 20:52:36.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 5; +use Test::More; use Test::Fatal; do { @@ -32,3 +32,5 @@ roles => ['MyRole::Storage'], ); +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/101-alias-excludes.t new/MooseX-Role-Parameterized-0.27/t/101-alias-excludes.t --- old/MooseX-Role-Parameterized-0.26/t/101-alias-excludes.t 2010-11-26 20:50:50.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/101-alias-excludes.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,7 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; -use Test::More tests => 4; +use Test::More; use Test::Fatal; do { @@ -19,7 +19,7 @@ do { package MyClass; - use MooseX::Role::Parameterized; + use Moose; ::like( ::exception { with MyRole => { @@ -34,3 +34,30 @@ }, qr/^The parameter name \(excludes\) is currently forbidden/); }; +do { + package OrdinaryRole; + use MooseX::Role::Parameterized; + + sub code { 'originally code' } + + sub other_code { 'originally other_code' } + + role { } +}; + +do { + package OrdinaryClass; + use Moose; + + with OrdinaryRole => { + -alias => { code => 'new_code' }, + -excludes => [ 'other_code' ], + }; +}; + +ok(!OrdinaryClass->can('other_code')); +is(OrdinaryClass->code, 'originally code'); +is(OrdinaryClass->new_code, 'originally code'); + +done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/102-nested.t new/MooseX-Role-Parameterized-0.27/t/102-nested.t --- old/MooseX-Role-Parameterized-0.26/t/102-nested.t 2010-11-26 20:50:50.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/102-nested.t 2011-08-22 20:52:40.000000000 +0200 @@ -1,3 +1,4 @@ +#!/usr/bin/env perl use strict; use warnings; use Test::More; @@ -22,7 +23,7 @@ } { - package Moo; + package Foo::Class; use Moose; ::is( ::exception { with 'Foo'; @@ -30,18 +31,18 @@ } { - package se; + package Bar::Class; use Moose; ::is( ::exception { with 'Bar'; }, undef); } -my $foo = Moo->meta->roles->[0]; +my $foo = Foo::Class->meta->roles->[0]; ok($foo->has_method('is_foo'), 'Foo got the "is_foo" method'); ok(!$foo->has_method('is_bar'), 'Foo did not get the "is_bar" method from Bar'); -my $bar = se->meta->roles->[0]; +my $bar = Bar::Class->meta->roles->[0]; ok($bar->has_method('is_bar'), 'Bar got the "is_bar" method'); ok(!$bar->has_method('is_foo'), 'Bar does not get "is_foo"'); @@ -51,3 +52,4 @@ ok(!Bar->meta->has_parameter('outer'), 'Bar does not have outer param'); done_testing; + diff -urN '--exclude=CVS' '--exclude=.cvsignore' '--exclude=.svn' '--exclude=.svnignore' old/MooseX-Role-Parameterized-0.26/t/150-composite-role-application.t new/MooseX-Role-Parameterized-0.27/t/150-composite-role-application.t --- old/MooseX-Role-Parameterized-0.26/t/150-composite-role-application.t 2010-11-26 20:50:50.000000000 +0100 +++ new/MooseX-Role-Parameterized-0.27/t/150-composite-role-application.t 2011-04-22 22:54:24.000000000 +0200 @@ -1,8 +1,7 @@ #!/usr/bin/env perl use strict; use warnings; - -use Test::More tests => 7; +use Test::More; do { package MyCompositeRoleA; @@ -113,3 +112,5 @@ ok(MyProxyConsumer->can('baz'), 'proxied role got applied successfully'); ok(MyProxyConsumer->can('qux'), 'other role besides proxied one got applied successfully'); +done_testing; + -- To unsubscribe, e-mail: opensuse-commit+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-commit+help@opensuse.org