[opensuse-cloud] quantum: Systemd service files?
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones. Details: https://build.opensuse.org/package/show?package=openstack-quantum&project=home%3Aa_jaeger%3AFactoryFix Could somebody review my changes and tell me whether this is the right way forward - or tell me what to change? Feel free to enhance as well ;) Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
Hi AJ,
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones.
I don't think there is such a difference. the .init files are templates that are generating the actual init files during %install phase. Which is also the main reason why I would discourage your approach. BTW, the user parameter is wrong in your service files (yes, copying blindly from Fedora does not adhere to suse packaging standards), I've not looked further on the diff. I don't think this duplication is going to lower our effort of maintaining the packages, and since systemd can perfectly well work with init scripts and our main *target* is to support a non-systemd distribution, I personally don't see the benefit of using something that can only become rotten and broken over time. BTW is it documented why the review team believes packages that will at no point in time end up on SLE12 are discouraged to be submitted to Factory? That seems to be the first thing that stood out from the decline comment for me. Greetings, Dirk -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
On Tuesday, April 23, 2013 23:04:21 Dirk Müller wrote:
Hi AJ,
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones.
I don't think there is such a difference. the .init files are templates that are generating the actual init files during %install phase. Which is also the main reason why I would discourage your approach.
Ah, I see. Yes, the same approach might be usable for the service files as well...
BTW, the user parameter is wrong in your service files (yes, copying blindly from Fedora does not adhere to suse packaging standards), I've
You looked much further than I did ;)
not looked further on the diff. I don't think this duplication is going to lower our effort of maintaining the packages, and since systemd can perfectly well work with init scripts and our main *target* is to support a non-systemd distribution, I personally don't see the benefit of using something that can only become rotten and broken over time.
BTW is it documented why the review team believes packages that will at no point in time end up on SLE12 are discouraged to be submitted to Factory? That seems to be the first thing that stood out from the decline comment for me.
Dirk, there will be a point in time when SUSE Cloud is based on SLE 12 which is going to use systemd . Adding service files early will not harm us but is not a hard requirement: https://en.opensuse.org/openSUSE:Packaging_guidelines#Init_scripts Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
2013/4/24 Andreas Jaeger <aj@suse.com>:
BTW is it documented why the review team believes packages that will at no point in time end up on SLE12 are discouraged to be submitted to Factory? That seems to be the first thing that stood out from the decline comment for me. Dirk, there will be a point in time when SUSE Cloud is based on SLE 12 which is going to use systemd .
Right, but at that point in time we're goint to drop the SLE11 support, which means we can remove the init scripts (looking forward to that, don't get me wrong). For now, we need to concentrate on the main goals and not sidetrack on nice to have things, there is plenty of real work other than beautification left.
Adding service files early will not harm us but is not a hard requirement: https://en.opensuse.org/openSUSE:Packaging_guidelines#Init_scripts
Thanks for the confirmation, Greetings, Dirk -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
Hello, Not speaking as a SLES user, but interested in background how this is moving forward. Although also not a systemd developer and not actually looked at how the systemd project code is managed, 1. I think that the systemd project has split up its code as "core" with other non-core units managed as "modules." Am not certain, but believe this why "systemctl --version" returns the systemd version number (currently 195 for openSUSE 12.3, uncertain what might be for anything else) and below that the distro name (suse) and several names in capital letters (likely modules?). 1a. So, my first thought is whether there might be code upstream from Fedora as an official "module" somewhere. If so, although Fedora is leading implementation I wonder if upstream is more stable and perhaps "basic." 1b. My second thought is that when messing with systemd units, it might be advisable to have at least some minimal communication with whoever determines core and maybe module code being implemented as a whole in SUSE/openSUSE. Although I think the namespaces are pretty safe, IMO the SUSE overall decision-makers on systemd versions and updating from upstream should at least know what is being done here to avoid duplication of effort and possible conflicts. How is the current code that is being created going to be distributed, as a "module?" If not, I think it'd be a mistake to just deploy Units ad hoc to distros. 2. Am I correct that the only code being considered is to simply integrate with Quantum which is a SLES only implementation, not available to openSUSE? 3. Because I don't have visibility into what is happening in SLES (I'm deploying only on openSUSE personally), as someone who has been studying/learning systemd on 12.3, on general principles implementing compiled code Units that replace and do not just reference init scripts is good for many reasons. If the Unit simply references an init script, it can still be useful bridging to eventual replacement, allows systemctl commands (like status) to greatly enhance troubleshooting and management and presumably allows the process to run as an "equal citizen" managed in a cgroup instead of buried in a hierarchy called the "legacy" way. 4. More Units (and defined Unit services) is supposed to be good on general principles. AFAIK defining greater numbers of Units means more granularity in the code which should enhance future maintenance, updates and upgrades. Since the "parent" Unit and the child Units called by that parent are in the same cgroup, this should not increase the complexity exposed to the User and Management tools. 4a. If Fedora is that much different than SUSE, perhaps a short conversation with someone "over there" might be beneficial to know <why>, eg does someone have thoughts on some kind of management tool that would read values generated by some of these Units? Or, is it something someone decided to do just on instinct? Also, the "greater number of Fedora service units" might only mean that the Fedora you were looking at is a more advanced version (ie version number greater than 195). It might be that if you compared the same level systemd on both the Fedora and SUSE system you're working on, the number of service units would be very similar. Just some of my thoughts, Tony On Tue, Apr 23, 2013 at 11:35 AM, Andreas Jaeger <aj@suse.com> wrote:
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones.
Could somebody review my changes and tell me whether this is the right way forward - or tell me what to change? Feel free to enhance as well ;)
Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
-- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
On Tuesday, April 23, 2013 17:10:37 Tony Su wrote:
Hello, Not speaking as a SLES user, but interested in background how this is moving forward. Although also not a systemd developer and not actually looked at how the systemd project code is managed,
1. I think that the systemd project has split up its code as "core" with other non-core units managed as "modules." Am not certain, but believe this why "systemctl --version" returns the systemd version number (currently 195 for openSUSE 12.3, uncertain what might be for anything else) and below that the distro name (suse) and several names in capital letters (likely modules?).
Those are the features compiled in. There's no split in core/modules.
2. Am I correct that the only code being considered is to simply integrate with Quantum which is a SLES only implementation, not available to openSUSE?
openstack-quantum is part of openSUSE 12.3, Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
Le mardi 23 avril 2013, à 20:35 +0200, Andreas Jaeger a écrit :
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones.
Could somebody review my changes and tell me whether this is the right way forward - or tell me what to change? Feel free to enhance as well ;)
Better to have the systemd files upstream than to have more and more distros shipping slightly different systemd files, imho. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
On Wednesday, April 24, 2013 09:05:29 Vincent Untz wrote:
Le mardi 23 avril 2013, à 20:35 +0200, Andreas Jaeger a écrit :
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones.
Details: https://build.opensuse.org/package/show?package=openstack-quantum&pr oject=home%3Aa_jaeger%3AFactoryFix
Could somebody review my changes and tell me whether this is the right way forward - or tell me what to change? Feel free to enhance as well ;)
Better to have the systemd files upstream than to have more and more distros shipping slightly different systemd files, imho.
Yes, this would be perfect, indeed. How to achieve this best? Andreas -- Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg) GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
Le mercredi 24 avril 2013, à 10:52 +0200, Andreas Jaeger a écrit :
On Wednesday, April 24, 2013 09:05:29 Vincent Untz wrote:
Le mardi 23 avril 2013, à 20:35 +0200, Andreas Jaeger a écrit :
I've started adding systemd service files to quantum (taking what Fedora has) and noticed that their setup is different from ours, especially they have many more service files than we have have init ones.
Details: https://build.opensuse.org/package/show?package=openstack-quantum&pr oject=home%3Aa_jaeger%3AFactoryFix
Could somebody review my changes and tell me whether this is the right way forward - or tell me what to change? Feel free to enhance as well ;)
Better to have the systemd files upstream than to have more and more distros shipping slightly different systemd files, imho.
Yes, this would be perfect, indeed. How to achieve this best?
I guess it's just a matter of submitting them upstream? If there are things that change between distros (like the user), then we should probably just submit them with @USER@ variables easy to sed. Vincent -- Les gens heureux ne sont pas pressés. -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
participants (4)
-
Andreas Jaeger
-
Dirk Müller
-
Tony Su
-
Vincent Untz