[opensuse-cloud] Re: OBS Cloud:OpenStack:Master/openstack-keystone r123 commited
Hi Andre,
switched default_catalog.templates to projects default which works
Modified: openstack-keystone.changes openstack-keystone.spec
could you explain which part is "not working" with the previous default_catalog.template? the upstream one does not have the %SERVICE_HOST marker that are used by the quickstart script in order to expand the catalog properly. Your change breaks that. In addition, this change was not mentioned in the changes file:
@@ -230,8 +231,9 @@ %config(noreplace) %attr(0640, root, %{groupname}) %{_sysconfdir}/%{component}/logging.conf %config %{_sysconfdir}/%{component}/keystone-paste.ini %config %{_sysconfdir}/%{component}/policy.json +%config %{_sysconfdir}/%{component}/default_catalog.templates %config(noreplace) %{_sysconfdir}/logrotate.d/%{name} -%attr(0640, %{username}, %{groupname}) %{_sysconfdir}/%{component}/default_catalog.templates.sample +%attr(0640, %{username}, %{groupname}) %{_sysconfdir}/%{component}/default_catalog.templates %{_initddir}/%{name} %{_sbindir}/rc%{name} %{_bindir}/keystone-all
Also, you forgot to remove the old default_catalog.templates file. If you're not so sure about the change, could you please send a submitrequest? others will review it and comment on it then, and four eyes see usually more than two. Thanks a lot in advance, Greetings, Dirk -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
Hello Dirk,
On Fri, 12 Jul 2013 13:29:04 +0200
Dirk Müller
switched default_catalog.templates to projects default which works
Modified: openstack-keystone.changes openstack-keystone.spec
could you explain which part is "not working" with the previous default_catalog.template?
I've replaced your modified version (%SERVICE.../S3) with the original file distributed by the project. I believe, the delivered files should be as unchanged as possible to the original project, this makes it easier for beginners to take a dive into openstack with the original documentation. And the answer, to get keystone working, you not only have to replace SERVICE_HOST with IP or hostname (which is localhost in the original file) and you have to remove the part regarding S3, to get it working as quick as possible.
the upstream one does not have the %SERVICE_HOST marker that are used by the quickstart script in order to expand the catalog properly. Your change breaks that.
So why do you not change the original file in your "opensuse-quickstart"? Instead you are changing an already modified version. You are delivering a not original file and modify it in another package. Why that? I would prefer to get this modification within opensuse-quickstart rather than the original project and configuration.
Also, you forgot to remove the old default_catalog.templates file. If you're not so sure about the change, could you please send a submitrequest? others will review it and comment on it then, and four eyes see usually more than two.
Yes you are right, got me there. ;) I'll do this that way the next time. Greetings, André -- André Naehring Linux Consultant & Trainer Mail: naehring@b1-systems.de B1 Systems GmbH Osterfeldstraße 7 / 85088 Vohburg / http://www.b1-systems.de GF: Ralph Dehner / Unternehmenssitz: Vohburg / AG: Ingolstadt,HRB 3537
Hi Andre,
I've replaced your modified version (%SERVICE.../S3) with the original file distributed by the project. I believe, the delivered files should be as unchanged as possible to the original project, this makes it easier for beginners to take a dive into openstack with the original documentation.
Thats debateable (and I'M not generally opposed to this). Currently however we install config files to match the openstack-quickstart scripts, which sed'in the generic keys with concrete values.
the upstream one does not have the %SERVICE_HOST marker that are used by the quickstart script in order to expand the catalog properly. Your change breaks that. So why do you not change the original file in your "opensuse-quickstart"?
We do use the "original" file. opensuse-quickstart should perhaps be renamed to opensuse-devstack, since that is what people are looking for anyway (imho). We're shipping the file from devstack, which does have those %..% markers. Greetings, Dirk -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org
participants (2)
-
André Nähring -
Dirk Müller