On 04/23/2013 09:48 AM, Marcus Meissner wrote:
On Tue, Apr 23, 2013 at 09:39:37AM +0200, Andreas Jaeger wrote:
On Tuesday, April 23, 2013 09:06:38 Sascha Peilicke wrote:
On 04/22/2013 02:29 PM, Andreas Jaeger wrote:
I just reviewed and declined a lot of openstack packages since the changes files contained removal of entries and I did not see that those were added anywhere else.
What's going on here? The changes are sometimes quite extensive and therefore it's difficult to figure out whether there are some changes lost or not.
Let me add the review team so that they are aware of this packages,
So it's that time of the year again. But it is still the same thing as was when we pushed Essex to Factory. These packages come from different (git, but doesn't matter) branches which by nature don't necessarily share a common history. They do share a common ancestor though:
----+----- master branch
\----- stable branch with bugfixes
It's the same thing with every project following that model by the way, so _yes_ deleted lines in changes files are expected. So what exactly is new here?
Communication! It's not obvious that no changes are lost and that this was really intented.
This submissions came in via an auto submission script, so I took the save guard. Next time I'll just let them sit and ask...
For next time, I would appreciate a word of warning and explanation before you do this.
In fact, I'm going to reopen all requests.
Fine with me ;) I have now the info that I needed...
You are violating your own set rules... And it is sad that you think that they do not apply to you.
This sets bad precedence.
Can you elaborate more on what the potential issue is? Both changes files (old branch / new branch) have changed entries for about every commit. So the only thing missing is the "Hey, we're changing branches here" notification in the submit request message. So you would prefer revoking the old submit requests and add new ones (potentially superseding) with that message?
The same discussion process should be done this way. http://en.opensuse.org/openSUSE:Creating_a_changes_file_%28RPM%29
Once we have settled this discussion, I'm sure we can distill an new paragraph for that wiki page. Currently, this case doesn't seem covered. -- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-cloud+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-cloud+owner@opensuse.org