[opensuse-buildservice] GSoC OBS comment system. Plan and Questions.
Hello, During the last days I have, with my mentors, hashed out the plan for my GSOC project - Building a discussion system for the OBS. I would appreciate your feedback on what I plan to achieve: Comment System: An OBS user can comment on a package and/or on a project. The comment consists of a title, body, timestamp and user info. The discussion is threaded, there is a parent comment and there are replies. So a user can either start a new thread or reply to an existing one. One can also add a thread as watched. Notification system : Each new comment will trigger a notification through the OBS notification system (hermes). A user can configure in his hermes settings to get notifications about new comments for projects/packages where he is maintainer/bugowner. By default these notifications are enabled. Another setting is to get notification about “watched threads”. Watched threads are threads where the user participates in or that he selected to follow. This setting is also enabled by default. These are the decisions I would like to get feedback from other OBS developers on. The most important question for me is: Where do we store the comment data? I was thinking on the webui database but I’m not sure. Any feedback is appreciated here. For your reference the trello board can be located at - https://trello.com/board/discussion-system/51a5ede2db062a7e6f001b7c Cheers Shayon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 06.06.2013 15:23, Shayon Mukherjee wrote:
Hello,
During the last days I have, with my mentors, hashed out the plan for my GSOC project - Building a discussion system for the OBS. I would appreciate your feedback on what I plan to achieve:
Comment System: An OBS user can comment on a package and/or on a project. The comment consists of a title, body, timestamp and user info. The discussion is threaded, there is a parent comment and there are replies. So a user can either start a new thread or reply to an existing one. One can also add a thread as watched.
Notification system : Each new comment will trigger a notification through the OBS notification system (hermes). A user can configure in his hermes settings to get notifications about new comments for projects/packages where he is maintainer/bugowner. By default these notifications are enabled. Another setting is to get notification about “watched threads”. Watched threads are threads where the user participates in or that he selected to follow. This setting is also enabled by default.
These are the decisions I would like to get feedback from other OBS developers on. The most important question for me is: Where do we store the comment data? I was thinking on the webui database but I’m not sure. Any feedback is appreciated here.
Hmm, your lines are pretty long ;) One thing that is very important IMO is having comments on requests - e.g. having a discussion on why an add_role request is or is not a good idea. And what would be beneficial in this context is getting notifications if someone mentions @coolo in a comment, no matter if I'm maintainer there or not. BTW: if you want to rely on hermes (like you should), a small warning: hermes has no default notifications. It would be good to move the subscriptions to the OBS and remove the build service plugin in hermes and simply have a global OBS subscribtion there and then have OBS decide who gets what when. This of course also implies that OBS needs to render the text. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Thu, Jun 6, 2013 at 7:32 PM, Stephan Kulow
On 06.06.2013 15:23, Shayon Mukherjee wrote:
Hello,
During the last days I have, with my mentors, hashed out the plan for my GSOC project - Building a discussion system for the OBS. I would appreciate your feedback on what I plan to achieve:
Comment System: An OBS user can comment on a package and/or on a project. The comment consists of a title, body, timestamp and user info. The discussion is threaded, there is a parent comment and there are replies. So a user can either start a new thread or reply to an existing one. One can also add a thread as watched.
Notification system : Each new comment will trigger a notification through the OBS notification system (hermes). A user can configure in his hermes settings to get notifications about new comments for projects/packages where he is maintainer/bugowner. By default these notifications are enabled. Another setting is to get notification about “watched threads”. Watched threads are threads where the user participates in or that he selected to follow. This setting is also enabled by default.
These are the decisions I would like to get feedback from other OBS developers on. The most important question for me is: Where do we store the comment data? I was thinking on the webui database but I’m not sure. Any feedback is appreciated here.
Hmm, your lines are pretty long ;)
Excuse me for that. Mail client :p.
One thing that is very important IMO is having comments on requests - e.g. having a discussion on why an add_role request is or is not a good idea.
And what would be beneficial in this context is getting notifications if someone mentions @coolo in a comment, no matter if I'm maintainer there or not.
This is indeed a good feature to have. I planned on doing it when I first started writing the proposal. But missed to include the same in the final version. Thanks for bringing it up :). And yes, the notification system accordingly makes sense.
BTW: if you want to rely on hermes (like you should), a small warning: hermes has no default notifications. It would be good to move the subscriptions to the OBS and remove the build service plugin in hermes and simply have a global OBS subscribtion there and then have OBS decide who gets what when.
This of course also implies that OBS needs to render the text.
I think I do understand what you are talking about here. I am very new to hermes and obs. That being said, still in the process of knowing hermes. As of now, I dont have any specific questions to ask but will for sure once I catch some pace. In the meanwhile, when you say, moving the subscription to OBS is a good idea. Where exactly are we talking about ? That being said, from which database or database-part (api or webui) should we be dealing with?
Greetings, Stephan
Cheers! Shayon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 06.06.2013 16:33, Shayon Mukherjee wrote:
In the meanwhile, when you say, moving the subscription to OBS is a good idea. Where exactly are we talking about ? That being said, from which database or database-part (api or webui) should we be dealing with?
The hidden long term plan is to get rid of the webui/api split, so putting something into the webui that does not strictly belong there is wasted effort. Put everything in the API database and add a JSON interface in the webui controller of it. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Thursday, June 6, 2013 at 8:16 PM, Stephan Kulow wrote:
On 06.06.2013 16:33, Shayon Mukherjee wrote:
In the meanwhile, when you say, moving the subscription to OBS is a good idea. Where exactly are we talking about ? That being said, from which database or database-part (api or webui) should we be dealing with?
The hidden long term plan is to get rid of the webui/api split, so putting something into the webui that does not strictly belong there is wasted effort.
Makes sense.
Put everything in the API database and add a JSON interface in the webui controller of it.
Out of curiosity, Is this process being followed anywhere? in the current webui setup? Just so that, something I could reference on.
Greetings, Stephan
Thank you Shayon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 07.06.2013 15:02, Shayon Mukherjee wrote:
On Thursday, June 6, 2013 at 8:16 PM, Stephan Kulow wrote:
On 06.06.2013 16:33, Shayon Mukherjee wrote:
In the meanwhile, when you say, moving the subscription to OBS is a good idea. Where exactly are we talking about ? That being said, from which database or database-part (api or webui) should we be dealing with?
The hidden long term plan is to get rid of the webui/api split, so putting something into the webui that does not strictly belong there is wasted effort.
Makes sense.
Put everything in the API database and add a JSON interface in the webui controller of it.
Out of curiosity, Is this process being followed anywhere? in the current webui setup? Just so that, something I could reference on.
The webui controller is used for the project and request views Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Friday, June 7, 2013 at 6:34 PM, Stephan Kulow wrote:
On 07.06.2013 15:02, Shayon Mukherjee wrote:
On Thursday, June 6, 2013 at 8:16 PM, Stephan Kulow wrote:
On 06.06.2013 16:33, Shayon Mukherjee wrote:
In the meanwhile, when you say, moving the subscription to OBS is a good idea. Where exactly are we talking about ? That being said, from which database or database-part (api or webui) should we be dealing with?
The hidden long term plan is to get rid of the webui/api split, so putting something into the webui that does not strictly belong there is wasted effort.
Makes sense.
Put everything in the API database and add a JSON interface in the webui controller of it.
Out of curiosity, Is this process being followed anywhere? in the current webui setup? Just so that, something I could reference on.
The webui controller is used for the project and request views Ok. Thanks :).
Greetings, Stephan Shayon
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (2)
-
Shayon Mukherjee -
Stephan Kulow