[opensuse-buildservice] perl-BSSolv
Hi, package obs-server has: BuildRequires: perl-BSSolv but BSSolv is only provided by obs-server itself. While there exist: https://build.opensuse.org/package/show/openSUSE:Tools/perl-BSSolv It contains old BSSolv linked against old libsolv. I have questions: 1) why is BSSolv.pm bundled in obs-server in first place and why it is not just simply required and used from standard path? 2) Where is ultimate upstream for perl-BSSolv? I feel that correct way is to create new repository perl-BSSolv under https://github.com/openSUSE/ Another approach is to remove BR and Requires of perl-BSSolv as it is part of obs-server, but that does not seem systematic to me. -- Miroslav Suchy Red Hat, Software Engineer -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Mon, Jul 22, 2013 at 07:55:31PM +0200, Miroslav Suchý wrote:
package obs-server has: BuildRequires: perl-BSSolv but BSSolv is only provided by obs-server itself.
I don't think that this is intentional. BSSolv.pm and BSSolv.xs should not be part of obs-server.
While there exist: https://build.opensuse.org/package/show/openSUSE:Tools/perl-BSSolv It contains old BSSolv linked against old libsolv.
Yes, that's the one obs-server needs.
I have questions: 1) why is BSSolv.pm bundled in obs-server in first place and why it is not just simply required and used from standard path?
Bug. But note that obs-server just provides perl(BSSolv), and not perl-BSSolv.
2) Where is ultimate upstream for perl-BSSolv? I feel that correct way is to create new repository perl-BSSolv under https://github.com/openSUSE/
The upstream is currently https://github.com/openSUSE/build-service. We could create an extra repo, but perl-BSSolv is pretty tied to the other backend code. Hmm.
Another approach is to remove BR and Requires of perl-BSSolv as it is part of obs-server, but that does not seem systematic to me.
Or make perl-BSSolv an sub-package of obs-server. That could also work. Thanks for noticing the bad provides! Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Jeff Hawn, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 07/22/2013 08:07 PM, Michael Schroeder wrote:
2) Where is ultimate upstream for perl-BSSolv? I feel that correct way is
to create new repository perl-BSSolv underhttps://github.com/openSUSE/ The upstream is currentlyhttps://github.com/openSUSE/build-service. We could create an extra repo, but perl-BSSolv is pretty tied to the other backend code. Hmm.
Another approach is to remove BR and Requires of perl-BSSolv as it is part of obs-server, but that does not seem systematic to me. Or make perl-BSSolv an sub-package of obs-server. That could also work.
I investigated it. And I do not think having perl-BSSolv as subpackage of obs-server is good idea. For several reasons: * BSSolv is just interface to satsolv and is pretty standalone. Even usage in backend code is quite encapsulated. And there will be no problem if moved out. * version of BSSolv from backendend is not used (!) because the C extension is not compiled. So the BSSolv load .so library from required perl-BSSolv (which is albeit older then the one included in backend). For this reason if we remove BSSolv source from backend and move it to somewhere else, then it should not bring regression, because it is not used right now. * if we make BSSolv subpackage of obs-server, it will increase complecity of obs-server.spec, which is already quite big. If you agree, can you please create new repository under: https://github.com/openSUSE ? I'm willing to send initial PR. But I can not create new repository. And one more question. This version: https://build.opensuse.org/package/view_file/OBS:Server:Unstable/perl-BSSolv... bundle its own version of libsolv. As bundling is discouraged in Fedora I created spec, which does not bundle libsolv and use system version of libsolv: https://github.com/xsuchy/perl-BSSolv/blob/master/perl-BSSolv.spec The question is which approach we want in upstream? One or other? Or should I make it little more complicate with conditions in spec like: "if Fedora then use system library, otherwise bundle libsolv"? -- Miroslav Suchy Red Hat, Software Engineer -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (2)
-
Michael Schroeder -
Miroslav Suchý