[opensuse-buildservice] %clean section in rpm packages in OBS
All, I have a question lately I see spec files that have been changed with the remark (cf. specfile guidelines). The %clean section has been removed for example, this doesn't feel right to me. Does anyone know something about the cf. specfile guidelines? Did I miss something? Regards, Joop. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Am Freitag, 23. Dezember 2011, 22:25:34 schrieb Joop Boonen:
All,
I have a question lately I see spec files that have been changed with the remark (cf. specfile guidelines).
The %clean section has been removed for example, this doesn't feel right to me.
Does anyone know something about the cf. specfile guidelines? Did I miss something?
AFAIK the newer rpms do default to the standard cleanup when %clean is missing. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
With RPM 4.9+ you no longer require the %clean section, it's done
automatically. There's the new %check section amongst other things...
Newer versions of RPM shouldn't require either the
%defattr(-,root,root,-) as they should be doing it by default... and
if things are like in Fedora, the BuildRoot should be handled
automatically also (not sure if implemented on OBS).
NM
2011/12/23 Joop Boonen
All,
I have a question lately I see spec files that have been changed with the remark (cf. specfile guidelines).
The %clean section has been removed for example, this doesn't feel right to me.
Does anyone know something about the cf. specfile guidelines? Did I miss something?
Regards,
Joop.
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
-- Nelson Marques /* http://www.marques.so nmo.marques@gmail.com */ -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Hi Nelson, This sounds great. Does anyone know if a wiki page will be created / updated about how spec files should look like? As I look at your reply, I'm thinking about SLE(S|D)10 and maybe even SLE(S|D)11 they won't be handling a missing %clean correctly as their rpm is 4.4.2. So I wonder if it's a good idea to remove %clean now? Regards, Joop. On Fri, December 23, 2011 11:25 pm, Nelson Marques wrote:
With RPM 4.9+ you no longer require the %clean section, it's done automatically. There's the new %check section amongst other things... Newer versions of RPM shouldn't require either the %defattr(-,root,root,-) as they should be doing it by default... and if things are like in Fedora, the BuildRoot should be handled automatically also (not sure if implemented on OBS).
NM
2011/12/23 Joop Boonen
: All,
I have a question lately I see spec files that have been changed with the remark (cf. specfile guidelines).
The %clean section has been removed for example, this doesn't feel right to me.
Does anyone know something about the cf. specfile guidelines? Did I miss something?
Regards,
Joop.
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
-- Nelson Marques
/* http://www.marques.so  nmo.marques@gmail.com */
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 12/23/2011 11:49 PM, Joop Boonen wrote:
Hi Nelson,
This sounds great. Does anyone know if a wiki page will be created / updated about how spec files should look like?
As I look at your reply, I'm thinking about SLE(S|D)10 and maybe even SLE(S|D)11 they won't be handling a missing %clean correctly as their rpm is 4.4.2.
So I wonder if it's a good idea to remove %clean now?
Yes its a good idea, OBS handles it itself. Regards. -- Ismail Dönmez - openSUSE Booster SUSE LINUX Products GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Sat, December 24, 2011 12:03 am, Ismail Donmez wrote:
On 12/23/2011 11:49 PM, Joop Boonen wrote:
Hi Nelson,
This sounds great. Does anyone know if a wiki page will be created / updated about how spec files should look like?
As I look at your reply, I'm thinking about SLE(S|D)10 and maybe even SLE(S|D)11 they won't be handling a missing %clean correctly as their rpm is 4.4.2.
So I wonder if it's a good idea to remove %clean now?
Yes its a good idea, OBS handles it itself.
But what if someone uses a srpm package for SLED/SLES10 and builds this one locally via rpmbuild won't this cause problems?
Regards.
-- Ismail Dönmez - openSUSE Booster SUSE LINUX Products GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Regards, Joop. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
You only can remove %clean if RPM > 4.8. If your version of RPM is
lower, you need to have that section.
NM
2011/12/23 Joop Boonen
Hi Nelson,
This sounds great. Does anyone know if a wiki page will be created / updated about how spec files should look like?
As I look at your reply, I'm thinking about SLE(S|D)10 and maybe even SLE(S|D)11 they won't be handling a missing %clean correctly as their rpm is 4.4.2.
So I wonder if it's a good idea to remove %clean now?
Regards,
Joop.
On Fri, December 23, 2011 11:25 pm, Nelson Marques wrote:
With RPM 4.9+ you no longer require the %clean section, it's done automatically. There's the new %check section amongst other things... Newer versions of RPM shouldn't require either the %defattr(-,root,root,-) as they should be doing it by default... and if things are like in Fedora, the BuildRoot should be handled automatically also (not sure if implemented on OBS).
NM
2011/12/23 Joop Boonen
: All,
I have a question lately I see spec files that have been changed with the remark (cf. specfile guidelines).
The %clean section has been removed for example, this doesn't feel right to me.
Does anyone know something about the cf. specfile guidelines? Did I miss something?
Regards,
Joop.
-- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
-- Nelson Marques
/* http://www.marques.so nmo.marques@gmail.com */
-- Nelson Marques /* http://www.marques.so nmo.marques@gmail.com */ -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
I don't know on SUSE how it happens, I don't have a SLE license to
test... But from my experience with Red Hat Enterprise Linux if you
build a SRPM with RPM 4.9 (ex: Fedora 16) and try to rebuild it with
'rpmbuild --rebuild' or mock, it doesn't allow you to because db
versioning blows up.
I think people are making a huge fuss without being really required...
Look, here's the real deal:
1. Having the %clean section doesn't hurt, for old systems (where it
is actually required) or new ones (rpm > 4.8);
2. If you are a syntax lover and love to complicate things you can use
conditionals, for example:
# -- this should cut the slack
if 0%{?suse_version} =< 1140 || 0%{rhel} < 6 || 0%{?fedora} < 15
%clean
rm -rf %{buildroot}
%endif
3. If you build only for recent systems, lets say openSUSE 12.1 or
Factory, then you don't need clean... For all the rest you do need it.
Find the best solution (maybe conditionals ?).
NM
2011/12/23 Joop Boonen
On Sat, December 24, 2011 12:03 am, Ismail Donmez wrote:
On 12/23/2011 11:49 PM, Joop Boonen wrote:
Hi Nelson,
This sounds great. Does anyone know if a wiki page will be created / updated about how spec files should look like?
As I look at your reply, I'm thinking about SLE(S|D)10 and maybe even SLE(S|D)11 they won't be handling a missing %clean correctly as their rpm is 4.4.2.
So I wonder if it's a good idea to remove %clean now?
Yes its a good idea, OBS handles it itself.
But what if someone uses a srpm package for SLED/SLES10 and builds this one locally via rpmbuild won't this cause problems?
Regards.
-- Ismail Dönmez - openSUSE Booster SUSE LINUX Products GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Regards,
Joop.
-- Nelson Marques /* http://www.marques.so nmo.marques@gmail.com */ -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (4)
-
Adrian Schröter
-
Ismail Donmez
-
Joop Boonen
-
Nelson Marques