[opensuse-buildservice] Re: [obs submit-request 163623] devel:libraries:c_c++/hxtools: accepted by dirkmueller
On Thursday 2013-04-11 14:59, dmueller@suse.com wrote:
State of submit-request #163623 was changed by dirkmueller:
new -> accepted
Comment: ok
To accept this is not acceptable for at least two reasons: - there is a package maintainer defined, and you gave him a measly 74 minutes to respond. - the patch has no description or author info whatsoever http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Type_2:_Complet... There is practically no information as to what it fixes, or why, other than what could be guessed from the filename or the project it came from. Robert Schweikert once proposed/brought up [http://lists.opensuse.org/opensuse-factory/2012-10/msg00282.html ] that we have too many maintainers on particular levels. Implicit inheritance of users is also an issue unresolved to date. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Am 11.04.2013 19:00, schrieb Jan Engelhardt: Hi Jan,
- there is a package maintainer defined, and you gave him a measly 74 minutes to respond.
Sorry, I didn't realize that, the webui does not show this information to me while accepting the request and I didn't remember it off hand (while I read commits in that project, the last commit was a quarter ago and I simply didn't match the information).
- the patch has no description or author info whatsoever http://en.opensuse.org/openSUSE:Packaging_Patches_guidelines#Type_2:_Complet... There is practically no information as to what it fixes, or why, other than what could be guessed from the filename or the project it came from.
It is a build fix for aarch64, as you might have guesst already. Given that you're the maintainer, could you work with Andreas on upstreaming the patch? This fix(or a similar one) is needed anyway, be it with opensuse policy correctness or not :-)
Robert Schweikert once proposed/brought up [http://lists.opensuse.org/opensuse-factory/2012-10/msg00282.html ] that we have too many maintainers on particular levels. Implicit inheritance of users is also an issue unresolved to date.
I'm just maintaining it on a project level, ensuring that stuck requests are being handled. as I went through the pending submitrequests (which I do rarely once a week, if at all), I just picked this one as well as it looked obvious to me. I see you already reverted the change, I've revoked the submitrequest to factory and now I would like to ask you to work with Andreas on getting the fix upstream. Thanks a lot in advance, Greetings, Dirk -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Friday 2013-04-12 08:53, Dirk Müller wrote:
Am 11.04.2013 19:00, schrieb Jan Engelhardt:
Hi Jan,
- there is a package maintainer defined, and you gave him a measly 74 minutes to respond.
Sorry, I didn't realize that, the webui does not show this information to me
Ok, I was under the assumption people would react to Hermes email notifications; I am not sure what other information the webui hides. However, I do see a "Modified" column next to "Source", "Requester", "Type" and "State" in https://build.opensuse.org/home and https://build.opensuse.org/project/requests?project=devel%3Alibraries%3Ac_c%... Has that column, for some reason, disappeared in your page renderings? -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
Jan Engelhardt <jengelh@inai.de> writes:
- the patch has no description or author info whatsoever
You mean this? # PATCH-FIX-UPSTREAM Avoid conflicting use of implementation namespace - schwab@suse.de Patch: hxtools-namespace.patch Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Friday 2013-04-12 16:39, Andreas Schwab wrote:
Jan Engelhardt <jengelh@inai.de> writes:
- the patch has no description or author info whatsoever
You mean this?
# PATCH-FIX-UPSTREAM Avoid conflicting use of implementation namespace - schwab@suse.de Patch: hxtools-namespace.patch
That is just a summary to me. A description would be like "xfs_irecover.c defines typedef uint8_t __u8, but __u8 is already provided by way of #include <signal.h> -> <asm/signal.h> -> <linux/types.h> (this include chain is the same for asm-arm and asm-x86).", perhaps including the compiler error message that was generated. At first I guessed that asm-arm/ had different includes than asm-x86/, but that does not seem to be the case, so the current guess is that the __u8 is something different than uint8_t/unsigned char on ARM, but that would then raise the question “why?”. Hence, the compiler error is really desirable. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (3)
-
Andreas Schwab -
Dirk Müller -
Jan Engelhardt