Hi,
the netwwork:samba:TESTING/samba project failed to build till we added an line with
%exclude /usr/lib/debug/.build-id
to the spec.
Shouldn't anything from this location be catched by the automatically created samba-debuginfo package and therefore not cause trouble like the seen one?
This is how it works for network:samba:STABLE/samba (4.2.3) while the code in network.samba:TESTING/samba is 4.3.0rc3 based.
Cheers,
Lars
On Wed, 2015-08-19 at 22:45 +0200, Lars Müller wrote:
Hi,
the netwwork:samba:TESTING/samba project failed to build till we added an line with
%exclude /usr/lib/debug/.build-id
This is 100% wrong... there is another error inside your .spec file. Most likely, you're wrongly using %exclude against a binary/library.
%exclude is ONLY suitable to exclude a file to be matched by a glob AND only if this said file ends up in a different sub-package.
Any other case, if the file is not to be packaged: rm it after it has been installed.
Cheers, Dominique
Hi Dominique,
On Wed, Aug 19, 2015 at 11:02:23PM +0200, Dominique Leuenberger / DimStar wrote:
On Wed, 2015-08-19 at 22:45 +0200, Lars Müller wrote:
the netwwork:samba:TESTING/samba project failed to build till we added an line with
%exclude /usr/lib/debug/.build-id
This is 100% wrong... there is another error inside your .spec file. Most likely, you're wrongly using %exclude against a binary/library.
Thanks again for your polite feedback.
%exclude is ONLY suitable to exclude a file to be matched by a glob AND only if this said file ends up in a different sub-package.
Any other case, if the file is not to be packaged: rm it after it has been installed.
We exclude three man pages which are installed unintentionally.
There might be something else broken. But who knows.
Cheers,
Lars
On Wed, 2015-08-19 at 23:26 +0200, Lars Müller wrote:
Hi Dominique,
On Wed, Aug 19, 2015 at 11:02:23PM +0200, Dominique Leuenberger / DimStar wrote:
On Wed, 2015-08-19 at 22:45 +0200, Lars Müller wrote:
the netwwork:samba:TESTING/samba project failed to build till we added an line with
%exclude /usr/lib/debug/.build-id
This is 100% wrong... there is another error inside your .spec file. Most likely, you're wrongly using %exclude against a binary/library.
Thanks again for your polite feedback.
Did I offend you with my reply? Apologies if this sounded rude to you (it does not to me, and was certainly not meant to be rude)
%exclude is ONLY suitable to exclude a file to be matched by a glob AND only if this said file ends up in a different sub-package.
Any other case, if the file is not to be packaged: rm it after it has been installed.
We exclude three man pages which are installed unintentionally.
The rule would still apply: if it should not be packaged at all, it should be deleted in the install section. Man pages normally do not cause this issue though when excluded... binaries do (and it's generally a pain to find, so I'd simply recommend to never sue %exclude, unless the file does go to a different package)
There might be something else broken. But who knows.
I can try to branch and remove the %exclude 'fix' added to see what this gives.. but it will have to wait for tomorrow I'm afraid.
Cheers, Dominique
On Wednesday 2015-08-19 23:35, Dominique Leuenberger / DimStar wrote:
We exclude three man pages which are installed unintentionally.
The rule would still apply: if it should not be packaged at all, it should be deleted in the install section. Man pages normally do not cause this issue though when excluded... binaries do (and it's generally a pain to find, so I'd simply recommend to never sue %exclude, unless the file does go to a different package)
Expanding on that:
%exclude not only excludes the file, it also causes rpmbuild to "untrack" and not report it -- the latter part is unwanted by most developers though.
This is why rm in %install is preferable. Preferably even without -f, so that one notices when the file is gone upstream.
(smells like wiki material ;-)
On Wed, 2015-08-19 at 22:45 +0200, Lars Müller wrote:
Hi,
the netwwork:samba:TESTING/samba project failed to build till we added an line with
I branched samba, removed the %exclude line you mentioned and hoped to get an error... but at least for openSUSE_Factory, this builds just fine at
https://build.opensuse.org/package/show/home:dimstar:branches:network:s amba:TESTING/samba
The applied diff is really nothing else but: @@ -1744,7 +1744,6 @@ %if 0%{?suse_version} > 1220 %{_var}/adm/fillup-templates/sysconfig.samba %endif -%exclude /usr/lib/debug/.build-id
%files client %defattr(-,root,root)
I see also Marcus Meissner rebuilt your samba package with the same diff (plus some more debug); he did not limit it to Factory, but rebuilt all repositories you have in :Testing too... apparently also without issues: https://build.opensuse.org/package/show/home:msmeissn:branches:network: samba:TESTING/samba
So unfortunately, it seems none of us two can actually reproduce the error you reported / saw when we remove the line you introduced...
Cheers, Dominique
On Thu, Aug 20, 2015 at 07:38:26AM +0200, Dominique Leuenberger / DimStar wrote:
On Wed, 2015-08-19 at 22:45 +0200, Lars Müller wrote:
Hi,
the netwwork:samba:TESTING/samba project failed to build till we added an line with
I branched samba, removed the %exclude line you mentioned and hoped to get an error... but at least for openSUSE_Factory, this builds just fine at
https://build.opensuse.org/package/show/home:dimstar:branches:network:s amba:TESTING/samba
The applied diff is really nothing else but: @@ -1744,7 +1744,6 @@ %if 0%{?suse_version} > 1220 %{_var}/adm/fillup-templates/sysconfig.samba %endif -%exclude /usr/lib/debug/.build-id
%files client %defattr(-,root,root)
I see also Marcus Meissner rebuilt your samba package with the same diff (plus some more debug); he did not limit it to Factory, but rebuilt all repositories you have in :Testing too... apparently also without issues: https://build.opensuse.org/package/show/home:msmeissn:branches:network: samba:TESTING/samba
So unfortunately, it seems none of us two can actually reproduce the error you reported / saw when we remove the line you introduced...
Yes.
My thoughts were:
- you might have a /usr/lib/* wildcard, but this did not appear to be the case. (the file list generation makes it a bit non obvious) - you might have switched debuginfo settings on/off
So I am not seeing an error currently.
Ciao, Marcus
Hi,
On Thu, Aug 20, 2015 at 09:46:15AM +0200, Marcus Meissner wrote:
On Thu, Aug 20, 2015 at 07:38:26AM +0200, Dominique Leuenberger / DimStar wrote:
On Wed, 2015-08-19 at 22:45 +0200, Lars Müller wrote:
the netwwork:samba:TESTING/samba project failed to build till we added an line with
I branched samba, removed the %exclude line you mentioned and hoped to get an error... but at least for openSUSE_Factory, this builds just fine at
https://build.opensuse.org/package/show/home:dimstar:branches:network:s amba:TESTING/samba
The applied diff is really nothing else but: @@ -1744,7 +1744,6 @@ %if 0%{?suse_version} > 1220 %{_var}/adm/fillup-templates/sysconfig.samba %endif -%exclude /usr/lib/debug/.build-id
%files client %defattr(-,root,root)
I see also Marcus Meissner rebuilt your samba package with the same diff (plus some more debug); he did not limit it to Factory, but rebuilt all repositories you have in :Testing too... apparently also without issues: https://build.opensuse.org/package/show/home:msmeissn:branches:network: samba:TESTING/samba
So unfortunately, it seems none of us two can actually reproduce the error you reported / saw when we remove the line you introduced...
Yes.
My thoughts were:
- you might have a /usr/lib/* wildcard, but this did not appear to be the case. (the file list generation makes it a bit non obvious)
- you might have switched debuginfo settings on/off
So I am not seeing an error currently.
ctdb was missing in network:samba:TESTING It is since some minutes after I posted the initial mail a linked project against network:samba:STABLE/ctdb again.
The missing ctdb caused only _one_ failing build target. And we saw it yesterday after I started this thread and enabled it.
One local osc build finished some minutes back and network:samba:STABLE package samba includes /usr/lib/debug/.build-id again.
Also SLE 11 ppc64 succeeded now in the OBS. Good enough to release. ;)
Cheers,
Lars
Hi,
On Thu, Aug 20, 2015 at 01:03:31PM +0200, Lars Müller wrote: [ 8< ]
ctdb was missing in network:samba:TESTING It is since some minutes after I posted the initial mail a linked project against network:samba:STABLE/ctdb again.
The missing ctdb caused only _one_ failing build target. And we saw it yesterday after I started this thread and enabled it.
One local osc build finished some minutes back and network:samba:STABLE
network:samba:TESTING includes it too
package samba includes /usr/lib/debug/.build-id again.
Also SLE 11 ppc64 succeeded now in the OBS. Good enough to release. ;)
Even if all looks good for us in network:samba:TESTING this might nevertheless be an issue on the OBS side. I have no clue how to investigate further.
Cheers,
Lars
Lars Müller lmuelle@suse.com writes:
Even if all looks good for us in network:samba:TESTING this might nevertheless be an issue on the OBS side. I have no clue how to investigate further.
Where is the log file?
Andreas.
Hi,
On Thu, Aug 20, 2015 at 02:21:36PM +0200, Andreas Schwab wrote:
Lars Müller lmuelle@suse.com writes:
Even if all looks good for us in network:samba:TESTING this might nevertheless be an issue on the OBS side. I have no clue how to investigate further.
Where is the log file?
It doesn't longer fail even after removing network:samba:TESTING/ctdb again.
And all we did in between the failing state and the working one was to link the missing ctdb from network:samba:STABLE
Sorry, this is unfortunately no longer reproduceable. :/
Cheers,
Lars
buildservice@lists.opensuse.org
-
Andreas Schwab -
Dominique Leuenberger / DimStar -
Jan Engelhardt -
Lars Müller -
Marcus Meissner