[opensuse-buildservice] [PATCH] [backend] fix error msg when using external tool.
Fix typo on error message when using external publisher program. Signed-off-by: Hector Oron <hector.oron@collabora.co.uk> --- src/backend/bs_publish | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/backend/bs_publish b/src/backend/bs_publish index afa1bbb..f549261 100755 --- a/src/backend/bs_publish +++ b/src/backend/bs_publish @@ -1430,7 +1430,7 @@ sub publish { return; } if (system($BSConfig::publishprogram->{$prp}, $prp, $extrep)) { - die(" $BSConfig::publishprogram{$prp} failed: $?\n"); + die(" $BSConfig::publishprogram->{$prp} failed: $?\n"); } goto publishprog_done; } -- 1.7.9.1 -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Thu, Apr 12, 2012 at 7:17 PM, Hector Oron <hector.oron@collabora.co.uk> wrote:
Fix typo on error message when using external publisher program.
Signed-off-by: Hector Oron <hector.oron@collabora.co.uk> --- src/backend/bs_publish | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/backend/bs_publish b/src/backend/bs_publish index afa1bbb..f549261 100755 --- a/src/backend/bs_publish +++ b/src/backend/bs_publish @@ -1430,7 +1430,7 @@ sub publish { return; } if (system($BSConfig::publishprogram->{$prp}, $prp, $extrep)) { - die(" $BSConfig::publishprogram{$prp} failed: $?\n"); + die(" $BSConfig::publishprogram->{$prp} failed: $?\n"); } goto publishprog_done;
goto? Is goto really a good programming practice? I've always understood it as an anti-pattern. Regards, Jeremiah -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On 13 April 2012 08:18, Jeremiah Foster <jeremiah.foster@pelagicore.com> wrote:
On Thu, Apr 12, 2012 at 7:17 PM, Hector Oron <hector.oron@collabora.co.uk> wrote:
Fix typo on error message when using external publisher program.
Signed-off-by: Hector Oron <hector.oron@collabora.co.uk> --- src/backend/bs_publish | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/backend/bs_publish b/src/backend/bs_publish index afa1bbb..f549261 100755 --- a/src/backend/bs_publish +++ b/src/backend/bs_publish @@ -1430,7 +1430,7 @@ sub publish { return; } if (system($BSConfig::publishprogram->{$prp}, $prp, $extrep)) { - die(" $BSConfig::publishprogram{$prp} failed: $?\n"); + die(" $BSConfig::publishprogram->{$prp} failed: $?\n"); } goto publishprog_done;
goto? Is goto really a good programming practice? I've always understood it as an anti-pattern.
Oversimplification. And anyway is not part of the modifications in this patch... Look at the complete code. And if *after* that you thing there is a better solution than the goto, submit a patch. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
On Fri, Apr 13, 2012 at 09:18:14AM +0200, Jeremiah Foster wrote:
goto? Is goto really a good programming practice? I've always understood it as an anti-pattern.
No, goto is fine, just look at the kernel source ;) Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Jeff Hawn, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org
participants (4)
-
Cristian Morales Vega -
Hector Oron -
Jeremiah Foster -
Michael Schroeder