Am Samstag, 16. Dezember 2006 12:32 schrieb Gernot Hillier:

Hi!

(I'm not sure if this is on-topic for the buildservice list, sorry if not!) sure it is...

As I needed a quick way to create packages from Source RPMs, I thought about controlling osc from a shell script first. But then, I found the TODO entry - and here's my first version of a patch to osc. :-)) Cool :-) I think that's the first non-suse-employee code bit for the BS and friends, right? Brilliant! Give us MORE :-) Be part and kick our ashes code-wise!

The patch should cleanly apply to the current SVN head of osc.

However, it's definitely not perfect yet -

oeeaaahahhhh ;-))

In general, I'd welcome any feedback Thanks & have fun,

Klaas

--------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

* Christoph Thiel [2006-12-20 00:09]:

On Tue, Dec 19, 2006 at 11:11:48PM +0100, Klaas Freitag wrote:

...

Cool :-) I think that's the first non-suse-employee code bit for the BS and friends, right?

Not really -- we got quite some contributions from Summer of Code :)

Btw, what's about the KDE client. Will it be developed further? Regards, Bernhard

Hi! Am Dienstag, 19. Dezember 2006 23:11 schrieb Klaas Freitag:

...

As I needed a quick way to create packages from Source RPMs, I thought about controlling osc from a shell script first. But then, I found the TODO entry - and here's my first version of a patch to osc. :-))

Cool :-) I think that's the first non-suse-employee code bit for the BS and friends, right? Brilliant! Give us MORE :-) Be part and kick our ashes code-wise!

So that means you plan to include it in osc? If yes, I'd like to include the suggestions of Mauricio (later on in this thread) before and I also remembered that I forgot to rmdir the temp dir at the end of the operation... -- Ciao, Gernot --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Am Thursday 21 December 2006 11:21 schrieb Gernot Hillier:

Hi!

Am Dienstag, 19. Dezember 2006 23:11 schrieb Klaas Freitag:

...

...

As I needed a quick way to create packages from Source RPMs, I thought about controlling osc from a shell script first. But then, I found the TODO entry - and here's my first version of a patch to osc. :-))

Cool :-) I think that's the first non-suse-employee code bit for the BS and friends, right? Brilliant! Give us MORE :-) Be part and kick our ashes code-wise!

So that means you plan to include it in osc?

Peter is on vacation atm and he is guy who should tell about that. But I think it will go inside when he is back in early January next year.

If yes, I'd like to include the suggestions of Mauricio (later on in this thread) before and I also remembered that I forgot to rmdir the temp dir at the end of the operation...

thanks a lot adrian -- Adrian Schroeter SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany email: adrian@suse.de --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

Am Thursday 21 December 2006 11:45 schrieb Bernhard Walle:

* Gernot Hillier [2006-12-21 11:25]:

...

...

Looks like you're converting rpm->cpio in a tmp file then extracting. Why not just piping the two commands?

rpm2cpio <file> | cpio -idv

Yeah, that looks like a good idea. Came to my mind after sending the patch, too. I'll try to integrate it ASAP - perhaps sooner if I get a feedback from the osc team that my patch might be worth for inclusion. :-)

Why not just using unrpm? That's what I use normally (when I not use mc :)).

You need a Requires: build for that, but I think this makes sense for osc anyway. bye adrian -- Adrian Schroeter SUSE Linux Products GmbH, Maxfeldstr. 5, 90409 Nuernberg, Germany email: adrian@suse.de --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org

* Gernot Hillier [2006-12-21 12:46]:

Hmmm - I'm not really sure where the benefit lies in calling "rpm2cpio | cpio" from a shell script instead of calling it directly...

Ok, next time I'll have a look at the commands I suggest :P Regards, Bernhard

On Thu, Dec 21, 2006 at 11:46:45AM +0100, Adrian Schröter wrote:

Am Thursday 21 December 2006 11:45 schrieb Bernhard Walle:

...

* Gernot Hillier [2006-12-21 11:25]:

...

...

Looks like you're converting rpm->cpio in a tmp file then extracting. Why not just piping the two commands?

rpm2cpio <file> | cpio -idv

Yeah, that looks like a good idea. Came to my mind after sending the patch, too. I'll try to integrate it ASAP - perhaps sooner if I get a feedback from the osc team that my patch might be worth for inclusion. :-)

Why not just using unrpm? That's what I use normally (when I not use mc :)).

You need a Requires: build for that, but I think this makes sense for osc anyway.

No, it makes less sense than I initially thought. Experience shows that lots of people install osc and are confused by the requirement to also get another package (and a specific version of it, which is only in the buildservice before 10.2), and lots of people don't want to build packages at all and don't bother. Therefore I removed the requirement again, and osc instead tells you what you need when you call its build subcommand, after checking for the presence of a sufficiently new version of build.rpm. Peter -- SUSE LINUX Products GmbH Bug, bogey, bugbear, bugaboo: Research & Development A malevolent monster (not true?); Some mischief microbic; What makes someone phobic; The work one does not want to do. From: Chris Young (The Omnificent English Dictionary In Limerick Form)