[opensuse-buildservice] Exclude param in tar_scm
Hi, Can anyone confirm if the 'exclude' parameter in tar_scm source service works fine? For what I can tell, it isn't working or I'm missing something. Example of a generated tar command by tar_scm: $ tar cf /tmp/tmpARm7Lt/debian-2.6.tar '--exclude='\''docs'\''' debian-2.6 The tarball debian-2.6.tar still includes the unwanted 'docs' file. Applying this diff: --- /usr/lib/obs/service/tar_scm.orig 2011-08-11 23:30:47.592347273 +0100 +++ /usr/lib/obs/service/tar_scm 2011-08-11 23:31:07.603889711 +0100 @@ -48 +48 @@ - EXCLUDES="$EXCLUDES --exclude='${2#/}'" + EXCLUDES="$EXCLUDES --exclude=${2#/}" The generated tar command is now $ tar cf /tmp/tmpNdpxNR/debian-2.6.tar --exclude=docs debian-2.6 And as a result the tarball produced doesn't include the 'docs' file, as expected. Cheers, Carlos Gonçalves -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Donnerstag, 11. August 2011, 23:45:53 schrieb Carlos Gonçalves:
Hi,
Can anyone confirm if the 'exclude' parameter in tar_scm source service works fine? For what I can tell, it isn't working or I'm missing something.
Example of a generated tar command by tar_scm: $ tar cf /tmp/tmpARm7Lt/debian-2.6.tar '--exclude='\''docs'\''' debian-2.6
The tarball debian-2.6.tar still includes the unwanted 'docs' file.
Applying this diff:
--- /usr/lib/obs/service/tar_scm.orig 2011-08-11 23:30:47.592347273 +0100 +++ /usr/lib/obs/service/tar_scm 2011-08-11 23:31:07.603889711 +0100 @@ -48 +48 @@ - EXCLUDES="$EXCLUDES --exclude='${2#/}'" + EXCLUDES="$EXCLUDES --exclude=${2#/}"
The generated tar command is now $ tar cf /tmp/tmpNdpxNR/debian-2.6.tar --exclude=docs debian-2.6
And as a result the tarball produced doesn't include the 'docs' file, as expected.
yep, I have changed this now. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
2011/8/12 Adrian Schröter <adrian@suse.de>
Am Donnerstag, 11. August 2011, 23:45:53 schrieb Carlos Gonçalves:
Hi,
Can anyone confirm if the 'exclude' parameter in tar_scm source service works fine? For what I can tell, it isn't working or I'm missing something.
Example of a generated tar command by tar_scm: $ tar cf /tmp/tmpARm7Lt/debian-2.6.tar '--exclude='\''docs'\''' debian-2.6
The tarball debian-2.6.tar still includes the unwanted 'docs' file.
Applying this diff:
--- /usr/lib/obs/service/tar_scm.orig 2011-08-11 23:30:47.592347273 +0100 +++ /usr/lib/obs/service/tar_scm 2011-08-11 23:31:07.603889711 +0100 @@ -48 +48 @@ - EXCLUDES="$EXCLUDES --exclude='${2#/}'" + EXCLUDES="$EXCLUDES --exclude=${2#/}"
The generated tar command is now $ tar cf /tmp/tmpNdpxNR/debian-2.6.tar --exclude=docs debian-2.6
And as a result the tarball produced doesn't include the 'docs' file, as expected.
yep, I have changed this now.
Thanks Adrian. Btw, where is the source code repository of such source services? I only found in OBS project openSUSE:Tools, but expected to be in http://gitorious.org/opensuse. Carlos Gonçalves -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Sonntag, 14. August 2011, 10:52:41 schrieb Carlos Gonçalves:
2011/8/12 Adrian Schröter <adrian@suse.de>
Am Donnerstag, 11. August 2011, 23:45:53 schrieb Carlos Gonçalves:
Hi,
Can anyone confirm if the 'exclude' parameter in tar_scm source service works fine? For what I can tell, it isn't working or I'm missing something.
Example of a generated tar command by tar_scm: $ tar cf /tmp/tmpARm7Lt/debian-2.6.tar '--exclude='\''docs'\''' debian-2.6
The tarball debian-2.6.tar still includes the unwanted 'docs' file.
Applying this diff:
--- /usr/lib/obs/service/tar_scm.orig 2011-08-11 23:30:47.592347273 +0100 +++ /usr/lib/obs/service/tar_scm 2011-08-11 23:31:07.603889711 +0100 @@ -48 +48 @@ - EXCLUDES="$EXCLUDES --exclude='${2#/}'" + EXCLUDES="$EXCLUDES --exclude=${2#/}"
The generated tar command is now $ tar cf /tmp/tmpNdpxNR/debian-2.6.tar --exclude=docs debian-2.6
And as a result the tarball produced doesn't include the 'docs' file, as expected.
yep, I have changed this now.
Thanks Adrian.
Btw, where is the source code repository of such source services? I only found in OBS project openSUSE:Tools, but expected to be in http://gitorious.org/opensuse.
We don't have any git for it. Someone wanted to setup a repo and provide auto import scripts, but this did not happen yet. For me this is not important, because the services are almost only single scripts so far. Another SCM would be just overhead for them IMHO. bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (2)
-
Adrian Schröter -
Carlos Gonçalves