[opensuse-buildservice] Patches to easy Stand Alone OBS install.
Hi, Here are some patches to make setting up a stand alone OBS install easier. They mostly remove some hard code URLs, allowing the use of the environment configuration files. Also included is a patch for the obs-server.spec file to make it work with a tarball made from current development tree. All of the patches are against r1638. -- David B. Anderson Linux Networx Sr. Software Engineer Email: danderson@lnxi.com Phone: (801) 649-1311 --- ../obs-r/buildservice/src/webclient/app/helpers/application_helper.rb 2007-05-11 16:04:41.000000000 -0600 +++ buildservice/src/webclient/app/helpers/application_helper.rb 2007-05-11 15:46:42.000000000 -0600 @@ -28,8 +28,12 @@ :project => project, :package => package end + def link_to_repo(message='', repo='') + link_to "Build Service Software #{message}", URL_SW_REPO_HOST + "/#{repo}" + end + def repo_url(project, repo='' ) - 'http://software.opensuse.org/download/' + project.gsub(':', ':/') + "/#{repo}" + URL_SW_REPO_HOST + '/download/' + project.gsub(':', ':/') + "/#{repo}" end --- ../obs-r/buildservice/src/backend/BSConfig.pm 2007-05-11 16:04:41.000000000 -0600 +++ buildservice/src/backend/BSConfig.pm 2007-05-11 15:46:42.000000000 -0600 @@ -27,6 +27,8 @@ our $stageserver = 'rsync://149.44.161.5/put-repos-main'; our $stageserver_sync = 'rsync://149.44.161.5/trigger-repos-sync'; our $repodownload = 'http://software.opensuse.org/download/repositories'; +our $gpgkeyurl = 'http://software.opensuse.org/openSUSE-Build-Service.asc'; +our $gpgcheck_flag ='1'; our $sign = '/root/bin/sign'; our $bsdir = '/bs'; our $keyfile = '/bs/openSUSE-Build-Service.asc'; --- ../obs-r/buildservice/src/webclient/config/environments/development.rb 2007-05-11 16:04:41.000000000 -0600 +++ buildservice/src/webclient/config/environments/development.rb 2007-05-11 15:46:42.000000000 -0600 @@ -42,3 +42,8 @@ ### ICHAIN_HOST = "212.12.12.12" ICHAIN_TEST_USER = "test" +# Software Repository Machine Path +URL_SW_REPO_HOST = "http://software.opensuse.org" + +# API Machine URL +URL_API_HOST ="https://api.opensuse.org" --- ../obs-r/buildservice/src/webclient/app/views/main/index.rhtml 2007-05-11 16:04:41.000000000 -0600 +++ buildservice/src/webclient/app/views/main/index.rhtml 2007-05-11 15:46:42.000000000 -0600 @@ -16,7 +16,10 @@ It can build packages for various Linux distributions.<br/> Most of the advanced features are still missing, but the basic build functionality is there.</p> -<p class="description">Everyone can download the resulting software packages via the <a href="http://software.opensuse.org">software browsing interface</a>.</p> +<p class="description">Everyone can download the resulting software packages via the + <%= link_to_repo 'browsing interface' + -%>. +</p> Reply
On Saturday, 12. May 2007 01:10, David B. Anderson wrote:
Hi,
Here are some patches to make setting up a stand alone OBS install easier. They mostly remove some hard code URLs, allowing the use of the environment configuration files.
Cool, thanks. A few comments: + def link_to_repo(message='', repo='') + link_to "Build Service Software #{message}", URL_SW_REPO_HOST + "/#{repo}" + end I'll remove the "Build Service Software" prefix, as this makes it very difficult to see what the final displayed text is. - number_to_human_size(bytes, 2) + hs = number_to_human_size(bytes.to_i) + if hs == nil + hs = bytes + end + hs I don't see the need for that. number_to_human_size can only return nil if the argument is nil. So your check effectively does nothing, because if hs == nil, bytes == nil. Additionally, the argument can never be nil as to_i, if defined, is guaranteed to always return an integer. I'll check in the fixes for the hardcoded URLs if no one else has objections.
Also included is a patch for the obs-server.spec file to make it work with a tarball made from current development tree.
All of the patches are against r1638.
-- Andreas Bauer - Novell - SUSE Internal Tools --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Thanks, Andreas Bauer wrote:
On Saturday, 12. May 2007 01:10, David B. Anderson wrote:
Hi,
Here are some patches to make setting up a stand alone OBS install easier. They mostly remove some hard code URLs, allowing the use of the environment configuration files.
Cool, thanks.
A few comments:
+ def link_to_repo(message='', repo='') + link_to "Build Service Software #{message}", URL_SW_REPO_HOST + "/#{repo}" + end
I'll remove the "Build Service Software" prefix, as this makes it very difficult to see what the final displayed text is.
Just trying to make the end user experience the same.
- number_to_human_size(bytes, 2) + hs = number_to_human_size(bytes.to_i) + if hs == nil + hs = bytes + end + hs
I don't see the need for that. number_to_human_size can only return nil if the argument is nil. So your check effectively does nothing, because if hs == nil, bytes == nil. Additionally, the argument can never be nil as to_i, if defined, is guaranteed to always return an integer.
During the initial OBS install, I was having problems with this function causing the pages to abort with exceptions. After I put the check for nil, I figured out bytes was a numerical string, hence .to_i. I left the nil check just in case bytes ever contained a none numeric value. This is a pure sanity check. I try to make it so that after I hit a problem, it will never come back.
I'll check in the fixes for the hardcoded URLs if no one else has objections.
Also included is a patch for the obs-server.spec file to make it work with a tarball made from current development tree.
All of the patches are against r1638.
Looking forward to the updates. Thanks. -- David B. Anderson Linux Networx Sr. Software Engineer Email: danderson@lnxi.com Phone: (801) 649-1311 --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (2)
-
Andreas Bauer -
David B. Anderson