[opensuse-buildservice] RFC: osc vc command
Hi all, For non-SUSE folks: vc is an internal command used for editing of .changes files. I'm working on implementation of vc command for osc. The current implementation supports some subset of functionality of it's original. But currently it can: - smart detect of .changes to edit - edit it using default editor - or add a defaul message using -m It can work in cwd only (should be implemented later) and not support locking (not necessary for OBS). The biggest changes are in header of .changes: ------------------------------------------------------------------- Thu Apr 16 15:47:06 UTC 2009 - mvyskocil@novell.com - osc vc test ------------------------------------------------------------------- Thu Apr 16 16:00:58 CEST 2009 - mvyskocil@suse.cz - vc test The date is always in UTC, which I considered better than TZ=Europe/Berlin used in vc, but it's a big change. Different email is rather cosmetic change, even if it will be nice to have my nice old @suse.cz back :), I don't know how to fix it. So any comments and proposals? Best regards Michal Vyskocil
On 4/16/2009 at 18:01, Michal Vyskocil <mvyskocil@suse.cz> wrote: Hi all,
For non-SUSE folks: vc is an internal command used for editing of .changes files.
Even though I'm non-SUSE, this sounds great... anything that automates any process is appreciated.
------------------------------------------------------------------- Thu Apr 16 15:47:06 UTC 2009 - mvyskocil@novell.com
- osc vc test
The date is always in UTC, which I considered better than TZ=Europe/Berlin used in vc, but it's a big change.
Different email is rather cosmetic change, even if it will be nice to have my nice old @suse.cz back :), I don't know how to fix it.
Where do you get the address from? I think it would be great if this could be specified in ~/.obsrc I for example NEVER use the email address I use on IChain. simply becasue on IChain I have my work account registered (as we're Novell Client I need access to NCC) but all the commits I do into OBS are 'private' based.. so even though I use my business IChain account, I would not want this email address to appear in the RPM Changelogs. Dominique -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Thursday 16 of April 2009 18:18:58 Dominique Leuenberger wrote:
On 4/16/2009 at 18:01, Michal Vyskocil <mvyskocil@suse.cz> wrote:
Hi all,
For non-SUSE folks: vc is an internal command used for editing of .changes files.
Even though I'm non-SUSE, this sounds great... anything that automates any process is appreciated.
------------------------------------------------------------------- Thu Apr 16 15:47:06 UTC 2009 - mvyskocil@novell.com
- osc vc test
The date is always in UTC, which I considered better than TZ=Europe/Berlin used in vc, but it's a big change.
Different email is rather cosmetic change, even if it will be nice to have my nice old @suse.cz back :), I don't know how to fix it.
Where do you get the address from?
e-mail is a part of user meta data and it's read from it. See `osc meta user <login>'. It cannot be changed, so maybe it's really connected with IChain.
I think it would be great if this could be specified in ~/.obsrc I for example NEVER use the email address I use on IChain. simply becasue on IChain I have my work account registered (as we're Novell Client I need access to NCC) but all the commits I do into OBS are 'private' based.. so even though I use my business IChain account, I would not want this email address to appear in the RPM Changelogs.
So vc could be improved - when email is defined in ~/.oscrc, then it will be used instead of one in metadata. [https://api.opensuse.org/] user = login pass = password email = not@ichain.email Regards Michal Vyskocil -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Freitag, 17. April 2009 09:56:24 schrieb Michal Vyskocil:
On Thursday 16 of April 2009 18:18:58 Dominique Leuenberger wrote:
On 4/16/2009 at 18:01, Michal Vyskocil <mvyskocil@suse.cz> wrote:
Hi all,
For non-SUSE folks: vc is an internal command used for editing of .changes files.
Even though I'm non-SUSE, this sounds great... anything that automates any process is appreciated.
------------------------------------------------------------------- Thu Apr 16 15:47:06 UTC 2009 - mvyskocil@novell.com
- osc vc test
The date is always in UTC, which I considered better than TZ=Europe/Berlin used in vc, but it's a big change.
Different email is rather cosmetic change, even if it will be nice to have my nice old @suse.cz back :), I don't know how to fix it.
Where do you get the address from?
e-mail is a part of user meta data and it's read from it. See `osc meta user <login>'. It cannot be changed, so maybe it's really connected with IChain.
yes, this comes from iChain. Having old email addresses back would be nice, but it is maybe better to have the same everywhere ;) bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Thursday 16 of April 2009 18:18:58 Dominique Leuenberger wrote: [snip]
Where do you get the address from? I think it would be great if this could be specified in ~/.obsrc I for example NEVER use the email address I use on IChain. simply becasue on IChain I have my work account registered (as we're Novell Client I need access to NCC) but all the commits I do into OBS are 'private' based.. so even though I use my business IChain account, I would not want this email address to appear in the RPM Changelogs.
The new patch adds and optional email field to ~/.oscrc [https://api.opensuse.org/] user = login pass = password email = not@ichain.email So you can define an email for each API. If it was not found, then osc will get a metadata from BS. Regards Michal Vyskocil
Hi, On 2009-04-17 11:03:36 +0200, Michal Vyskocil wrote:
On Thursday 16 of April 2009 18:18:58 Dominique Leuenberger wrote: [snip]
Where do you get the address from? I think it would be great if this could be specified in ~/.obsrc I for example NEVER use the email address I use on IChain. simply becasue on IChain I have my work account registered (as we're Novell Client I need access to NCC) but all the commits I do into OBS are 'private' based.. so even though I use my business IChain account, I would not want this email address to appear in the RPM Changelogs.
The new patch adds and optional email field to ~/.oscrc
[https://api.opensuse.org/] user = login pass = password email = not@ichain.email
So you can define an email for each API. If it was not found, then osc will get a metadata from BS.
That sounds good:) Just a small remark:
+ # user's email + apiurl = conf.config['apiurl']
Is it likely that "osc vc" will be executed in a non package dir/working copy? If not it would be nice if you use something like: # note if cwd is no working copy it'll bail out apiurl = findpacs(os.getcwd())[0].apiurl or apiurl = conf.config['apiurl'] if is_package_dir(os.getcwd()): apiurl = store_read_apiurl(os.getcwd()) This way osc always uses the correct apiurl. Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Freitag, 17. April 2009 14:58:12 schrieb Marcus Hüwe: ...
That sounds good:)
Just a small remark:
+ # user's email + apiurl = conf.config['apiurl']
Is it likely that "osc vc" will be executed in a non package dir/working copy? If not it would be nice if you use something like:
JFYI, the classic "vc" will become part of the build.rpm package right soon. A new version has been build for testing already, but it is not yet published. bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Friday 17 of April 2009 14:58:12 Marcus Hüwe wrote:
Hi,
On 2009-04-17 11:03:36 +0200, Michal Vyskocil wrote:
On Thursday 16 of April 2009 18:18:58 Dominique Leuenberger wrote: [snip]
That sounds good:)
Just a small remark:
+ # user's email + apiurl = conf.config['apiurl']
Is it likely that "osc vc" will be executed in a non package dir/working copy? If not it would be nice if you use something like:
# note if cwd is no working copy it'll bail out apiurl = findpacs(os.getcwd())[0].apiurl
or
apiurl = conf.config['apiurl'] if is_package_dir(os.getcwd()): apiurl = store_read_apiurl(os.getcwd())
This way osc always uses the correct apiurl.
Thanks, I'll fix that. Regards Michal Vyskocil -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Michal Vyskocil wrote:
For non-SUSE folks: vc is an internal command used for editing of .changes files.
I'm working on implementation of vc command for osc. The current implementation supports some subset of functionality of it's original.
vc should be put into the build package. lbuild already has lbuildvc but it's not feature complete compared to the internal vc yet. cu Ludwig -- (o_ Ludwig Nussel //\ SUSE LINUX Products GmbH, Development V_/_ http://www.suse.de/ -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Thursday 16 of April 2009 18:52:43 Ludwig Nussel wrote:
Michal Vyskocil wrote:
For non-SUSE folks: vc is an internal command used for editing of .changes files.
I'm working on implementation of vc command for osc. The current implementation supports some subset of functionality of it's original.
vc should be put into the build package. lbuild already has lbuildvc but it's not feature complete compared to the internal vc yet.
JFI: I commited osc vc command to trunk. It uses Ludwig's buildvc from build.rpm 2009.04.17. The most important difference is that osc allows to specify a custom email address for each used API in ~/.oscrc as mentioned above. [https://api.opensuse.org/] user = login pass = password email = user@defined.email So you don't need remains with your email used for iChain. Regards Michal Vyskocil -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (5)
-
Adrian Schröter -
Dominique Leuenberger -
Ludwig Nussel -
Marcus Hüwe -
Michal Vyskocil