[opensuse-buildservice] cannot add empty files to a package
Hi, I'm just playing with the latest BS packages from trunk (r3552) and it seems that the api rejects the upload of empty files (see attached development.log): marcus@linux:~/home:Admin/foo> touch bar marcus@linux:~/home:Admin/foo> curl -u Admin:opensuse -X PUT -d "$(cat bar)" http://127.0.42.2/source/home:Admin/foo/bar?rev=upload <?xml version="1.0" encoding="UTF-8"?> <status code="unknown"> <summary>XML validation failed</summary> <details>illegal document type 'NilClass'</details> </status> marcus@linux:~/home:Admin/foo> Is this a bug or feature?:) In case it is a bug I attached a small patch which fixes/works around this problem. Marcus
Marcus Hüwe wrote:
On 2008-03-17 00:26:08 +0100, Marcus Hüwe wrote:
Is this a bug or feature?:) In case it is a bug I attached a small patch which fixes/works around this problem.
Here's a shorter version of the patch.
Both fixes are good and make the code more robust. Although, the real cause of the problem is the validator being triggered by a file upload. Should never happen. Go ahead and check them in, you should have access already. Thanks, Andreas --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 2008-03-17 16:36:42 +0100, Andreas Bauer wrote:
Marcus Hüwe wrote:
On 2008-03-17 00:26:08 +0100, Marcus Hüwe wrote:
Is this a bug or feature?:) In case it is a bug I attached a small patch which fixes/works around this problem.
Here's a shorter version of the patch.
Both fixes are good and make the code more robust. Although, the real cause of the problem is the validator being triggered by a file upload. Should never happen.
I added a small note about this to the commit message.
Go ahead and check them in, you should have access already.
done. Marcus --------------------------------------------------------------------- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (2)
-
Andreas Bauer -
Marcus Hüwe