[opensuse-buildservice] small patch proposal for "build"
Hi I'm trying to work with git repositories of build-service on my MacOS laptop, and noticed that in build package there is a small issue: mbp:tmp kad$ git clone git://gitorious.org/opensuse/build.git Initialized empty Git repository in /Users/kanevski/tmp/build/.git/ remote: Counting objects: 1590, done. remote: Compressing objects: 100% (742/742), done. remote: Total 1590 (delta 1059), reused 1261 (delta 842) Receiving objects: 100% (1590/1590), 330.21 KiB, done. Resolving deltas: 100% (1059/1059), done. mbp:tmp kad$ cd build/ mbp:build kad$ git st # On branch master # Changed but not updated: # (use "git add/rm <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # deleted: Build/Deb.pm # deleted: Build/Kiwi.pm # deleted: Build/Rpm.pm # deleted: Build/Susetags.pm # deleted: Build/Zypp.pm # no changes added to commit (use "git add" and/or "git commit -a") mbp:build kad$ git co Build mbp:build kad$ git st # On branch master # Changed but not updated: # (use "git add/rm <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # deleted: build # no changes added to commit (use "git add" and/or "git commit -a") This is happening because "build" script and "Build" directory is the same filename on filesystems like MacOS where they have by default "case insensitive" flag. To fix that, I'm proposing small fix which consists of: 1. git mv build build.sh 2. modify Makefile to have "build.sh" installed as $(DESTDIR)$(pkglibdir)/build See diff here: http://gitorious.org/~kad/opensuse/kad-build/commit/f19a4803e791a11cd01d32ca... Any underwater stones which I haven't noticed ? -- br, Alexander Kanevskiy -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Samstag, 13. März 2010 14:42:23 schrieb Alexander Kanevskiy:
Hi
I'm trying to work with git repositories of build-service on my MacOS laptop, and noticed that in build package there is a small issue:
mbp:tmp kad$ git clone git://gitorious.org/opensuse/build.git Initialized empty Git repository in /Users/kanevski/tmp/build/.git/ remote: Counting objects: 1590, done. remote: Compressing objects: 100% (742/742), done. remote: Total 1590 (delta 1059), reused 1261 (delta 842) Receiving objects: 100% (1590/1590), 330.21 KiB, done. Resolving deltas: 100% (1059/1059), done. mbp:tmp kad$ cd build/ mbp:build kad$ git st # On branch master # Changed but not updated: # (use "git add/rm <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # deleted: Build/Deb.pm # deleted: Build/Kiwi.pm # deleted: Build/Rpm.pm # deleted: Build/Susetags.pm # deleted: Build/Zypp.pm # no changes added to commit (use "git add" and/or "git commit -a") mbp:build kad$ git co Build mbp:build kad$ git st # On branch master # Changed but not updated: # (use "git add/rm <file>..." to update what will be committed) # (use "git checkout -- <file>..." to discard changes in working directory) # # deleted: build # no changes added to commit (use "git add" and/or "git commit -a")
This is happening because "build" script and "Build" directory is the same filename on filesystems like MacOS where they have by default "case insensitive" flag.
To fix that, I'm proposing small fix which consists of:
1. git mv build build.sh 2. modify Makefile to have "build.sh" installed as $(DESTDIR)$(pkglibdir)/build See diff here: http://gitorious.org/~kad/opensuse/kad-build/commit/f19a4803e791a11cd01d32ca...
Any underwater stones which I haven't noticed ?
renaming it during installation would mean that the fresh checkout would not work anymore. And all our OBS parts should be able to run out of git without installing it. We could do this, but also call "build.sh" in all tools, like bs_worker and osc by default. We can still make a compatibility symlink to "build" during packaging. Any more opinions ? bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Alexander Kanevskiy wrote:
This is happening because "build" script and "Build" directory is the same filename on filesystems like MacOS where they have by default "case insensitive" flag.
To fix that, I'm proposing small fix which consists of:
1. git mv build build.sh 2. modify Makefile to have "build.sh" installed as $(DESTDIR)$(pkglibdir)/build
Does that mean only your checkout dir is case insensitive while $(pkglibdir) is ok? Both Build/ and build are installed in $(pkglibdir) ... cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.de/ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Mon, Mar 15, 2010 at 10:58, Ludwig Nussel
Alexander Kanevskiy wrote:
This is happening because "build" script and "Build" directory is the same filename on filesystems like MacOS where they have by default "case insensitive" flag.
To fix that, I'm proposing small fix which consists of:
1. git mv build build.sh 2. modify Makefile to have "build.sh" installed as $(DESTDIR)$(pkglibdir)/build
Does that mean only your checkout dir is case insensitive while $(pkglibdir) is ok?
Yes. I wanted to change/review some bits in the git repositories sing my laptop OS (with gitx specifically) during traveling without need to start VM.
Both Build/ and build are installed in $(pkglibdir) ...
Actual usage and testing of those scripts are anyway limited to the Linux, thus worrying about DESTDIR is not a high priority until we got "MacOS as worker" support. And in my opinion, person changing something is anyway need to build and deploy packages in some separate testing environment... -- br, Alexander Kanevskiy -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (3)
-
Adrian Schröter -
Alexander Kanevskiy -
Ludwig Nussel