[opensuse-buildservice] Re: [PATCH] - cut *.changes message after 30 lines (as request by darix)
Huh ? I suppose this get also written out to the file ? We do not want this. This would mean we loose informations in the changes files. We cut .changes when applying to the rpm %changes to avoid that the rpm database gross. But we definitily do not want to loose .changes log entries. please revert that bye adrian Am Sonntag, 9. Mai 2010, 21:39:00 schrieben Sie:
From: Marcus Huewe
--- osc/core.py | 7 ++++++- 1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/osc/core.py b/osc/core.py index b944618..e68c235 100644 --- a/osc/core.py +++ b/osc/core.py @@ -2508,12 +2508,17 @@ def run_editor(filename):
return subprocess.call([ editor, filename ])
-def edit_message(footer='', template=''): +def edit_message(footer='', template='', templatelen=30): delim = '--This line, and those below, will be ignored--\n' import tempfile (fd, filename) = tempfile.mkstemp(prefix = 'osc-commitmsg', suffix = '.diff') f = os.fdopen(fd, 'w') if template != '': + if not templatelen is None: + lines = template.splitlines() + template = '\n'.join(lines[:templatelen]) + if lines[templatelen:]: + footer = '%s\n\n%s' % ('\n'.join(lines[templatelen:]), footer) f.write(template) f.write('\n') f.write(delim)
-- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Monday 2010-05-10 07:12, Adrian Schröter wrote:
Huh ?
I suppose this get also written out to the file ?
We do not want this. This would mean we loose informations in the changes files.
If the OBS storage only worked a little more like git, you would not have to do things like these. Or, as the public puts it, authorship and change information does not belong into tracked files, but into the history log. I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Montag, 10. Mai 2010, 07:30:05 schrieb Jan Engelhardt:
On Monday 2010-05-10 07:12, Adrian Schröter wrote:
Huh ?
I suppose this get also written out to the file ?
We do not want this. This would mean we loose informations in the changes files.
If the OBS storage only worked a little more like git, you would not have to do things like these. Or, as the public puts it, authorship and change information does not belong into tracked files, but into the history log.
An advanced history is planned. But this is just a plain file for now.
I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has.
Well, feel free to comment the changelog 2.0 concept. But this is currently how the distro works in first place. -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Mon, May 10, 2010 at 07:30:05AM +0200, Jan Engelhardt wrote:
If the OBS storage only worked a little more like git, you would not have to do things like these. Or, as the public puts it, authorship and change information does not belong into tracked files, but into the history log.
Huh? OBS already has authorship and change information in the history log.
I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has.
Nonsense. The .changes (and thus rpm's %changelog) is intended for the end user that installs packages, not the developer. The information should be displayed in YaST/zypper, so the user can make an informed decision if he wants to install/update a package. Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Monday 2010-05-10 12:02, Michael Schroeder wrote:
On Mon, May 10, 2010 at 07:30:05AM +0200, Jan Engelhardt wrote:
If the OBS storage only worked a little more like git, you would not have to do things like these. Or, as the public puts it, authorship and change information does not belong into tracked files, but into the history log.
Huh? OBS already has authorship and change information in the history log.
And 'loses' them when merging (= accepting an SR) whose log entry only reports the acceptance of the SR normally, but does not have all the commits from the branch.
I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has.
Nonsense. The .changes (and thus rpm's %changelog) is intended for the end user that installs packages, not the developer. The information should be displayed in YaST/zypper, so the user can make an informed decision if he wants to install/update a package.
If it is, then it should probably be trimmed. Users are unlikely to be interested in all the change reasons since 9.3. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Monday 10 of May 2010, Michael Schroeder wrote:
On Mon, May 10, 2010 at 07:30:05AM +0200, Jan Engelhardt wrote:
If the OBS storage only worked a little more like git, you would not have to do things like these. Or, as the public puts it, authorship and change information does not belong into tracked files, but into the history log.
Huh? OBS already has authorship and change information in the history log.
Which is however rather poorly usable. Digging out things from the history can be hard or even impossible.
I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has.
Nonsense. The .changes (and thus rpm's %changelog) is intended for the end user that installs packages, not the developer. The information should be displayed in YaST/zypper, so the user can make an informed decision if he wants to install/update a package.
Nonsense :). Updates for factory are rejected if they do not have a .changes entry, so we are required to add things like 'remove obsolete build requirement' or 'compile fix' to the changelog that users could not care less about. This is even documented somewhere in the wiki. -- Lubos Lunak openSUSE Boosters team, KDE developer l.lunak@suse.cz , l.lunak@kde.org -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Tue, May 11, 2010 at 04:02:24PM +0200, Lubos Lunak wrote:
I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has.
Nonsense. The .changes (and thus rpm's %changelog) is intended for the end user that installs packages, not the developer. The information should be displayed in YaST/zypper, so the user can make an informed decision if he wants to install/update a package.
Nonsense :). Updates for factory are rejected if they do not have a .changes entry, so we are required to add things like 'remove obsolete build requirement' or 'compile fix' to the changelog that users could not care less about. This is even documented somewhere in the wiki.
So what? That's a local policy thing from Factory. Factory is not the build service. The policy is that packages that get out to customers and have different version/release must have different changelogs, so that a custumer can see what has changed. This policy does not forbid you from checking in changes into your projects that don't have a .changes entry. It's just that if they are submitted to Factory, you have to state what you have changed. Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Michael Schroeder wrote:
On Tue, May 11, 2010 at 04:02:24PM +0200, Lubos Lunak wrote:
I don't deny software projects their occassional user-level changelog.txt which has all irrelevant developer actions removed, but OBS is pretty much for developers anyway. And right now, .changes looks like a drop-in to counter for the suboptimal history tracking OBS has.
Nonsense. The .changes (and thus rpm's %changelog) is intended for the end user that installs packages, not the developer. The information should be displayed in YaST/zypper, so the user can make an informed decision if he wants to install/update a package.
Nonsense :). Updates for factory are rejected if they do not have a .changes entry, so we are required to add things like 'remove obsolete build requirement' or 'compile fix' to the changelog that users could not care less about. This is even documented somewhere in the wiki.
So what? That's a local policy thing from Factory. Factory is not the build service.
The policy is that packages that get out to customers and have different version/release must have different changelogs, so that a custumer can see what has changed.
That's not the case though as automatic rebuilds don't leave a changelog entry. cu Ludwig -- (o_ Ludwig Nussel //\ V_/_ http://www.suse.de/ SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nuernberg) -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Wed, May 12, 2010 at 08:33:50AM +0200, Ludwig Nussel wrote:
Michael Schroeder wrote:
So what? That's a local policy thing from Factory. Factory is not the build service.
The policy is that packages that get out to customers and have different version/release must have different changelogs, so that a custumer can see what has changed.
That's not the case though as automatic rebuilds don't leave a changelog entry.
Yes, that's true. Seems to be an exception ;-) My guess is that it's assumed that a rebuild will not cause any functional changes. Cheers, Michael. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Montag 10 Mai 2010 schrieb Adrian Schröter:
Huh ?
I suppose this get also written out to the file ?
We do not want this. This would mean we loose informations in the changes files.
We cut .changes when applying to the rpm %changes to avoid that the rpm database gross. But we definitily do not want to loose .changes log entries.
please revert that Can you please only comment to patches (especially if asking to rever them) after you had coffee?
This change is about a vim template. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 2010-05-10 07:12:10 +0200, Adrian Schröter wrote:
I suppose this get also written out to the file ?
We do not want this. This would mean we loose informations in the changes files.
We cut .changes when applying to the rpm %changes to avoid that the rpm database gross. But we definitily do not want to loose .changes log entries.
you dont loose changes from the changelog. you just shorten the amount of data that is added to the osc sr/ci message from the changes file. I asked for the feature after I saw "osc rq show 39554". I doubt anyone needs the whole changes entry duplicated into the submitrequest.
please revert that
no. please keep the feature and make a release ASAP. darix -- openSUSE - SUSE Linux is my linux openSUSE is good for you www.opensuse.org -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Am Montag, 17. Mai 2010, 13:14:06 schrieb Marcus Rueckert:
On 2010-05-10 07:12:10 +0200, Adrian Schröter wrote:
I suppose this get also written out to the file ?
We do not want this. This would mean we loose informations in the changes files.
We cut .changes when applying to the rpm %changes to avoid that the rpm database gross. But we definitily do not want to loose .changes log entries.
you dont loose changes from the changelog. you just shorten the amount of data that is added to the osc sr/ci message from the changes file.
I asked for the feature after I saw "osc rq show 39554". I doubt anyone needs the whole changes entry duplicated into the submitrequest.
please revert that
no. please keep the feature and make a release ASAP.
Yes, yes, you could have clarified just my assumption in first sentence ;) -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (7)
-
Adrian Schröter -
Jan Engelhardt -
Lubos Lunak -
Ludwig Nussel -
Marcus Rueckert -
Michael Schroeder -
Stephan Kulow