[opensuse-buildservice] enable proxy support in the backend
Hi, I just updated my patch which enables basic proxy support in the backend. Are there any objections against committing it to git master? Marcus
On Freitag, 28. Mai 2010 23:36:39 Marcus Hüwe wrote:
Hi,
I just updated my patch which enables basic proxy support in the backend. Are there any objections against committing it to git master?
Please change it in a way that $proxy can be just commented out by default in BSConfig.pm. Otherwise all updaters will run into problems, because BSConfig.pm get not touched on update usually. bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Sat, May 29, 2010 at 09:34:37AM +0200, Adrian Schröter wrote:
On Freitag, 28. Mai 2010 23:36:39 Marcus Hüwe wrote:
Hi,
I just updated my patch which enables basic proxy support in the backend. Are there any objections against committing it to git master?
Please change it in a way that $proxy can be just commented out by default in BSConfig.pm.
Otherwise all updaters will run into problems, because BSConfig.pm get not touched on update usually.
Doesn't that already work with the patch? (Anyway, no objection from my side other than it doesn't allow me to configure different proxies for different remote sites. But maybe that's not needed in real life.) Cheers, Micha. -- Michael Schroeder mls@suse.de SUSE LINUX Products GmbH, GF Markus Rex, HRB 16746 AG Nuernberg main(_){while(_=~getchar())putchar(~_-1/(~(_|32)/13*2-11)*13);} -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Hi Marcus, Thank you very much, This patch saves my life. Best Regards, Leaf -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Mon, May 31, 2010 at 11:28:10AM +0200, Michael Schroeder wrote:
(Anyway, no objection from my side other than it doesn't allow me to configure different proxies for different remote sites. But maybe that's not needed in real life.)
Marcus, please commit it. M. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
Sorry for the late response... On 2010-05-31 11:28:10 +0200, Michael Schroeder wrote:
On Sat, May 29, 2010 at 09:34:37AM +0200, Adrian Schröter wrote:
On Freitag, 28. Mai 2010 23:36:39 Marcus Hüwe wrote:
Hi,
I just updated my patch which enables basic proxy support in the backend. Are there any objections against committing it to git master?
Please change it in a way that $proxy can be just commented out by default in BSConfig.pm.
Otherwise all updaters will run into problems, because BSConfig.pm get not touched on update usually.
Doesn't that already work with the patch?
It should work for updaters, too. If "proxy" isn't defined in BSConfig.pm it'll "default" to undef (which should be correct). Anyway I just committed it.
(Anyway, no objection from my side other than it doesn't allow me to configure different proxies for different remote sites. But maybe that's not needed in real life.)
Hmm yes that might make sense. Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Donnerstag, 3. Juni 2010 20:47:11 Marcus Hüwe wrote:
Sorry for the late response...
On 2010-05-31 11:28:10 +0200, Michael Schroeder wrote:
On Sat, May 29, 2010 at 09:34:37AM +0200, Adrian Schröter wrote:
On Freitag, 28. Mai 2010 23:36:39 Marcus Hüwe wrote:
Hi,
I just updated my patch which enables basic proxy support in the backend. Are there any objections against committing it to git master?
Please change it in a way that $proxy can be just commented out by default in BSConfig.pm.
Otherwise all updaters will run into problems, because BSConfig.pm get not touched on update usually.
Doesn't that already work with the patch?
It should work for updaters, too. If "proxy" isn't defined in BSConfig.pm it'll "default" to undef (which should be correct). Anyway I just committed it.
No, it would error out, because the proxy object does not exist. It is fixed now. (there were also some typos, so this code could never have worked). bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 2010-06-07 09:40:03 +0200, Adrian Schröter wrote:
On Donnerstag, 3. Juni 2010 20:47:11 Marcus Hüwe wrote:
Sorry for the late response...
On 2010-05-31 11:28:10 +0200, Michael Schroeder wrote:
On Sat, May 29, 2010 at 09:34:37AM +0200, Adrian Schröter wrote:
On Freitag, 28. Mai 2010 23:36:39 Marcus Hüwe wrote:
Hi,
I just updated my patch which enables basic proxy support in the backend. Are there any objections against committing it to git master?
Please change it in a way that $proxy can be just commented out by default in BSConfig.pm.
Otherwise all updaters will run into problems, because BSConfig.pm get not touched on update usually.
Doesn't that already work with the patch?
It should work for updaters, too. If "proxy" isn't defined in BSConfig.pm it'll "default" to undef (which should be correct). Anyway I just committed it.
No, it would error out, because the proxy object does not exist. Hmm consider the following example:
# Foo.pm: package Foo; use strict; use warnings; 1; # some other perl script which uses Foo: #!/usr/bin/perl -w use strict; use warnings; use Data::Dumper; my $x = $Foo::xxx; print Dumper($x); # avoid typo warning... $x = $Foo::xxx; In this case $Foo::xxx evaluates to "undef".
It is fixed now. (there were also some typos, so this code could never have worked).
Thanks for spotting the typos! Marcus -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On 07/06/10 08:40, Adrian Schröter wrote:
On Donnerstag, 3. Juni 2010 20:47:11 Marcus Hüwe wrote: [snip]
Anyway I just committed it.
No, it would error out, because the proxy object does not exist. It is fixed now. (there were also some typos, so this code could never have worked).
Hmm, did this proxy code get into OBS 2.0? I've got a local OBS Appliance behind a corporate proxy that I just 'zypper update'd to: obs-common-2.0-2.1.i586 obs-server-2.0.0-5.2.i586 obs-worker-2.0.0-5.2.noarch obs-api-2.0.0-5.2.i586 And if I configure a proxy in BSConfig.pm like: our $proxy = "http://proxy.example.com:8080"; The scheduler is still having trouble accessing api.opensuse.org. From /srv/obs/log/scheduler_i586.log: response from watcher for https://api.opensuse.org/public setting up watcher for https://api.opensuse.org/public, start=12813181 2010-06-16 13:17:53: waiting for an event... response from watcher for https://api.opensuse.org/public 502 remote error: Bad Gateway retrying in 60 seconds 2010-06-16 13:18:58: waiting for an event... retrying watcher for https://api.opensuse.org/public setting up watcher for https://api.opensuse.org/public, start=12813181 2010-06-16 13:19:58: waiting for an event... response from watcher for https://api.opensuse.org/public 504 remote error: Gateway Time-Out retrying in 60 seconds 2010-06-16 13:22:59: waiting for an event... Ah, however, it seems I was premature to think the build wasn't working due to this. My local OBS has just built a package using a remote repository! So, I guess the scheduler is still occasionally trying to contact api.opensuse.org without a proxy in particular cases? Cheers, John. -- John Beranek To generalise is to be an idiot. http://redux.org.uk/ -- William Blake -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Wednesday 16 June 2010 14:31:28 John Beranek wrote:
On 07/06/10 08:40, Adrian Schröter wrote:
On Donnerstag, 3. Juni 2010 20:47:11 Marcus Hüwe wrote: [snip]
Anyway I just committed it.
No, it would error out, because the proxy object does not exist. It is fixed now. (there were also some typos, so this code could never have worked).
Hmm, did this proxy code get into OBS 2.0? I've got a local OBS Appliance behind a corporate proxy that I just 'zypper update'd to:
obs-common-2.0-2.1.i586 obs-server-2.0.0-5.2.i586 obs-worker-2.0.0-5.2.noarch obs-api-2.0.0-5.2.i586
And if I configure a proxy in BSConfig.pm like:
our $proxy = "http://proxy.example.com:8080";
The scheduler is still having trouble accessing api.opensuse.org. From /srv/obs/log/scheduler_i586.log:
response from watcher for https://api.opensuse.org/public setting up watcher for https://api.opensuse.org/public, start=12813181 2010-06-16 13:17:53: waiting for an event... response from watcher for https://api.opensuse.org/public 502 remote error: Bad Gateway retrying in 60 seconds 2010-06-16 13:18:58: waiting for an event... retrying watcher for https://api.opensuse.org/public setting up watcher for https://api.opensuse.org/public, start=12813181 2010-06-16 13:19:58: waiting for an event... response from watcher for https://api.opensuse.org/public 504 remote error: Gateway Time-Out retrying in 60 seconds 2010-06-16 13:22:59: waiting for an event...
Ah, however, it seems I was premature to think the build wasn't working due to this. My local OBS has just built a package using a remote repository!
So, I guess the scheduler is still occasionally trying to contact api.opensuse.org without a proxy in particular cases?
It tries to keep a connection open permanently to be able to get notified on changes on api.opensuse.org (new sources, new binaries). api.o.o has to close the connection unfortunatly or we would run out of ports due to broken connections. So these timeouts are "okay", nothing is lost and the scheduler is reconnecting again. bye adrian -- Adrian Schroeter SUSE Linux Products GmbH email: adrian@suse.de -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (5)
-
Adrian Schröter -
John Beranek -
Leaf John -
Marcus Hüwe -
Michael Schroeder