[opensuse-buildservice] build-compare: it appears to ignore specfile metadata changes
I've been having trouble with build-compare. It *appears* to be ignoring changes to the specfile, when the changes are of the Conflicts or Provides nature (possibly others). The source files (other than the specfile) are not changing. Is this expected? Can someone confirm this? -- Jon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
On Tuesday 31 August 2010 00:46:14 Jon Nelson wrote:
I've been having trouble with build-compare. It *appears* to be ignoring changes to the specfile, when the changes are of the Conflicts or Provides nature (possibly others). The source files (other than the specfile) are not changing. Is this expected? Can someone confirm this?
If you add a changes entry, it will record that one for sure ;) The following code in rpm-check.sh of build-compare should handle changed conflicts and provides: check_provides() { # provides destroy this because at least the self-provide includes the # -buildnumber :-( QF="[%{PROVIDENAME} %{PROVIDEFLAGS} %{PROVIDEVERSION}\\n]\\n" QF="$QF [%{REQUIRENAME} %{REQUIREFLAGS} %{REQUIREVERSION}\\n]\\n" QF="$QF [%{CONFLICTNAME} %{CONFLICTFLAGS} %{CONFLICTVERSION}\\n]\\n" QF="$QF [%{OBSOLETENAME} %{OBSOLETEFLAGS} %{OBSOLETEVERSION}\\n]\\n" check_header "$1" | sed -e "s,-$2$,-@RELEASE@," } check_provides $oldrpm $release1 > $file1 check_provides $newrpm $release2 > $file2 if ! diff -au $file1 $file2; then rm $file1 $file2 exit 1 fi Please give me some instructions on what exactly fails so that I can reproduce it, Andreas -- Andreas Jaeger, Program Manager openSUSE, aj@{novell.com,opensuse.org} Twitter: jaegerandi | Identica: jaegerandi SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) Maxfeldstr. 5, 90409 Nürnberg, Germany GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
Am Dienstag 31 August 2010 schrieb Andreas Jaeger:
On Tuesday 31 August 2010 00:46:14 Jon Nelson wrote:
I've been having trouble with build-compare. It *appears* to be ignoring changes to the specfile, when the changes are of the Conflicts or Provides nature (possibly others). The source files (other than the specfile) are not changing. Is this expected? Can someone confirm this?
If you add a changes entry, it will record that one for sure ;)
Any change to the sources will change the disturl and this one for sure is not ignored. Greetings, Stephan -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org
participants (3)
-
Andreas Jaeger
-
Jon Nelson
-
Stephan Kulow