Hello, on Montag, 27. Juli 2009, doiggl@velocitynet.com.au wrote:
From the rpmlint report which items are the really easy ones to fix. Can anyone provide any hints on how these should be coded in.
You can find some information about rpmlint warnings on http://en.opensuse.org/Packaging/RpmLint In many cases, reading the rpmlint messages should give you the information you need.
Which are the really important ones to fix ?.
Basically all of them ;-)
ramlog.src: W: %install-no-mkdir-buildroot Your install section removes the buildroot but does not create them afterwards in a secure way, which allows attackers to trivially play tricks with symlinks on you. use mkdir %buildroot (no -p option!) or don't clean the buildroot in %install, because that's anyway already done for you by rpm.
Remove those lines from your spec ## [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT and it should work.
ramlog.src:17: W: hardcoded-packager-tag Jan The Packager tag is hardcoded in your spec file. It should be removed, so as to use rebuilder's own defaults.
Remove this line: Packager: Jan Andrejkovic (Note: Maybe you'll get a new warning about missing packager tag then - ignore it ;-)
ramlog.src:15: W: hardcoded-path-in-buildroot-tag /var/tmp/%{name}-buildroot A path is hardcoded in your Buildroot tag. It should be replaced by %{_tmppath}/%{name}-%{version}-build.
Self-explaining - change the BuildRoot: setting as described.
ramlog.noarch: W: incoherent-subsys /etc/init.d/ramlog $prog The filename of your lock file in /var/lock/subsys/ is incoherent with your actual init script name. For example, if your script name is httpd, you have to use 'httpd' as the filename in your subsys directory. It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually.
Basically self-explaining - and might be a false positive. Check that your initscript really uses /var/lock/subsys/ramlog as lock file. If this is the case, this is a false positive.
ramlog.noarch: W: init-script-without-%stop_on_removal-preun /etc/init.d/ramlog The init script should have a %preun script that calls %stop_on_removal.
Self-explaining: Add a new section to your spec: %preun %stop_on_removal
ramlog.noarch: W: missing-dependency-to-cron for cron script /etc/cron.daily/ramlog This package installs a file in /etc/cron.*/ but doesn't require cron to be installed. as cron is not part of the essential packages, your package should explicitely require cron to make sure that your cron job is executed. If it is an optional feature of your package, recommend or suggest cron.
Add "cron" to Requires, Recommends or Suggests - depending on how hard your script depends on the daily cronjob.
ramlog.src: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty.
Self-explaining - add a %build section.
ramlog.noarch: W: no-version-in-last-changelog ramlog.src: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it.
Basically self-explaining, but could be a false positive since your changelog contains %changelog * Sun Jun 08 2008 Jan Andrejkovic <jandrejkovic@gmail.com> - version 1.1.0 released: Regards, Christian Boltz -- Next I can reboot and install witouth the need to burn a DVD. Remember that then [the local installation source] should be on a partition you are not going to format, because it is very hard to read data from a partition you just formatted. ;-) [houghi in opensuse] -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org