20 Sep
2010
20 Sep
'10
08:31
Hi, Thanks for review. I'll remove do_remoteservice and remote_run_source_services, and push into. Since git_pull service is another package different from osc, and there is no repository on gitorious for such service plugins like download_url and verify_services, shall we create one for them though they just contain a shell script? ---------------- Best Regards, Brook Hong >-----Original Message----- >From: ext Marcus Hüwe [mailto:suse-tux@gmx.de] >Sent: Monday, September 20, 2010 3:51 PM >To: opensuse-buildservice@opensuse.org >Subject: Re: [opensuse-buildservice] Merge request to add support for >git_pull source service. > >Hi, > >On 2010-09-20 05:49:15 +0200, brook.hong@nokia.com wrote: >> I have created a git_pull source service to download latest code from >git repository to obs server, and tar them if updated. >> >> With git_pull service, when you create a package whose code is hosted >in git repository, for example, http://gitorious.org/libzip/libzip. >> >> You need not create/upload a tar or patch file each time you make a >code change. >> >> What you just need to do is ? >> >> After you creating a package on obs, run -- >> 1. osc add http://git.gitorious.org/libzip/libzip.git >> 2. osc ci >> After you making a code change and a successful git push >> 3. osc remoteservice <obs_project> libzip >> >> >> Code change for this feature -- >> 1. osc client support for git_pull >> http://gitorious.org/opensuse/brookhongs- >osc/commit/f344ff882572db6b7b9e245170d6c80b8cc15b23?diffmode=sidebyside >I just had a quick glance at your patch but it looks good so far. >Some small remark: >- please remove the "do_remoteservice" method from commandline.py > (the same functionality is provided by "osc service remoterun") > and thus "remote_run_source_services" in core.py isn't needed too > > >Marcus >-- >To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org >For additional commands, e-mail: opensuse-buildservice+help@opensuse.org -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org