Here is my take on the notifications. Let's start with some types that we will likely have: 1) request accepted 2) request declined 3) request revoked 4) request superseded 5) review accepted 6) review declined 7) review added 8) comment added On Thursday 05 December 2013 07:04:19 Stephan Kulow wrote:
Am 04.12.2013 20:29, schrieb Dimstar / Dominique Leuenberger:
I wonder - who should get mail too?
- target maintainer
Wants 1,2,3,4
- source maintainer
Wants 1,2,5,6,7,8
- current reviewers
Wants 5,6,7,8. Reviewers don't care what happens with requests afterwards (hence no 1,2,3,4)
- accepted reviewers
Wants 5,6,7,8. The same as current reviewers IMO (like coolo implied already)
- open reviews
How is that different to "current reviewers" ? I think that's
- people previously commenting
Want 1,2,3,4,8. Commenter only are most likely not interested in reviews.
- any other candidates?
Hmm. that sounds in any case like a place for disaster.. I myself would prefer 'too many' of those mails as opposed to missing some.
Of the list above, I'd say 'accepted reviewers' is likely the least interested in it..
The others sound rather logical..
Well, if Sascha accepted a review and you look at it too and notice that Sascha overlooked something, wouldn't you want Sascha to know? :)
I agree here, though Sascha already has far too much mails too. It depends how the commenting feature will fit in. So I wonder how notifications will be configurable, i.e. either OBS-wide or per-project? It would be perfect to have some global config (also easy to start with) but allow to override with per-project specific things. This would allow to mute stuff in devel:$boring, whereas I always want stuff for openSUSE:Factory. Others may have different preferences. -- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)