Hello
From the rpmlint report which items are the really easy ones to fix. Can anyone provide any hints on how these should be coded in. Which are the really important ones to fix ?. Thanks Glenn
Log: https://build.opensuse.org/package/live_build_log?arch=x86_64&package=ramlog&project=home%3Adoiggl&repository=openSUSE_Factory RPMLINT report: =============== ramlog.src: W: %install-no-mkdir-buildroot Your install section removes the buildroot but does not create them afterwards in a secure way, which allows attackers to trivially play tricks with symlinks on you. use mkdir %buildroot (no -p option!) or don't clean the buildroot in %install, because that's anyway already done for you by rpm. ramlog.src:17: W: hardcoded-packager-tag Jan The Packager tag is hardcoded in your spec file. It should be removed, so as to use rebuilder's own defaults. ramlog.src:15: W: hardcoded-path-in-buildroot-tag /var/tmp/%{name}-buildroot A path is hardcoded in your Buildroot tag. It should be replaced by %{_tmppath}/%{name}-%{version}-build. ramlog.noarch: W: incoherent-subsys /etc/init.d/ramlog $prog The filename of your lock file in /var/lock/subsys/ is incoherent with your actual init script name. For example, if your script name is httpd, you have to use 'httpd' as the filename in your subsys directory. It is also possible that rpmlint gets this wrong, especially if the init script contains nontrivial shell variables and/or assignments. These cases usually manifest themselves when rpmlint reports that the subsys name starts a with '$'; in these cases a warning instead of an error is reported and you should check the script manually. ramlog.noarch: W: init-script-without-%stop_on_removal-preun /etc/init.d/ramlog The init script should have a %preun script that calls %stop_on_removal. ramlog.noarch: W: missing-dependency-to-cron for cron script /etc/cron.daily/ramlog This package installs a file in /etc/cron.*/ but doesn't require cron to be installed. as cron is not part of the essential packages, your package should explicitely require cron to make sure that your cron job is executed. If it is an optional feature of your package, recommend or suggest cron. ramlog.src: W: no-%build-section The spec file does not contain a %build section. Even if some packages don't directly need it, section markers may be overridden in rpm's configuration to provide additional "under the hood" functionality, such as injection of automatic -debuginfo subpackages. Add the section, even if empty. ramlog.noarch: W: no-version-in-last-changelog ramlog.src: W: no-version-in-last-changelog The last changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it. 2 packages and 0 specfiles checked; 0 errors, 9 warnings. ... creating baselibs ... saving built packages /usr/src/packages/RPMS/noarch/ramlog-1.1.0-15.1.noarch.rpm /usr/src/packages/SRPMS/ramlog-1.1.0-15.1.src.rpm ... comparing built packages with the former built /usr/lib/build/rpm-check.sh compare /.build.oldpackages/ramlog-1.1.0-14.1.src.rpm /usr/src/packages/SRPMS/ramlog-1.1.0-15.1.src.rpm ramlog.spec differs ( ASCII English text) --- old/ramlog.spec 2009-07-26 02:15:33.000000000 +0000 +++ new/ramlog.spec 2009-07-26 02:15:33.000000000 +0000 @@ -34,7 +34,7 @@ %setup -q -c %{name} %install -[ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT +## [ "$RPM_BUILD_ROOT" != "/" ] && rm -rf $RPM_BUILD_ROOT mkdir -p $RPM_BUILD_ROOT mkdir -p -m 755 $RPM_BUILD_ROOT/etc/init.d mkdir -p -m 755 $RPM_BUILD_ROOT/usr/share/man/man8/ build20 finished "build ramlog.spec" at Sun Jul 26 02:15:33 UTC 2009. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org