On Friday 2013-11-08 16:55, Tomáš Chvátal wrote:
Dne Pá 8. listopadu 2013 16:47:29, Jan Engelhardt napsal(a):
Sorry, I do not consider the use of that being "clean". It's another instance of overdoing it with macros, as it is with %__cp.
Such (%__cp) is -at most- only useful if you run with a non-GNU toolchain (meaning you go __cp = gcp), and that is not very likely happening anytime soon in openSUSE.
Did you read what the tool does? It replaces the %__cp with cp or should in the end, same with install/rm... I just think the install macro should be unified for which purpose this stands. So it actually does what you want.
It cleans up half and uglifies the other, like adding {} around every possible instance. And sometimes, it just does plain wrong things, like replacing PreReq by Requires(pre). Code talks, so here is """ The following changes since commit 3399f4e7fff8b319f1f5451b7979775689757d32: Use spdx identifier for licenses (2011-11-30 13:35:09 +0100) are available in the git repository at: git://git.inai.de/spec-cleaner master for you to fetch changes up to 57ed24ebe499b866fdb9726fda7e5e8e122a9430: spec-cleaner: uppercase URL (2013-11-08 17:34:38 +0100) ---------------------------------------------------------------- Jan Engelhardt (2): spec-cleaner: avoid any form of %make(_)install spec-cleaner: uppercase URL spec-cleaner | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) """ I still favor the result of spec-beautifier. -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org To contact the owner, e-mail: opensuse-buildservice+owner@opensuse.org