On Thursday 05 December 2013 08:58:41 Dominique Leuenberger a.k.a. Dimstar wrote:
Quoting Andreas Jaeger <aj@suse.com>:
On 12/05/2013 09:24 AM, Stephan Kulow wrote:
On 03.12.2013 21:24, Stephan Kulow wrote:
The first step will be to send mails for review - which does not work
I deployed that now and sent out some emails - before disabling it again.
So factory reviewers should have got some email - please review their content and let's find ways to improve them.
Can I reply to the review email with "approve" or comment on it?
What would be the outcome if multiple reviewers approve / decline, with conflicting messages?
If we WOULD do that, I guess the mails should be forcibly PGP signed and the key added as property to the user account (that could be interesting for 'connect' anyway.. )
so the mailer could validate that the approve / decline is indeed coming from one of the expected reviewers.
For comments I could see big potential.. could be very efficient to initiate dialogs on packages.
Nah, overkill for now. ATM, the review team only casts one vote (which is done by one reviewer proxying the whole team). If the review team had a dispute so far, we did discuss on the review@opensuse.org list and changed the review state afterwards if necessary. I dunno if we would want to transfer this to the OBS completely. Other cases: review team accepts but by-project / by-package maintainer declines. That usually means a source project maintainer thought the submission was wrong and the package isn't ready yet. Nothing to discuss. The other way around is easier, review team has the say. Nothing to discuss either. Yet another case is if we invited someone else to present his opinion (i.e. a 3rd-party review added). In that case I'd say it's still the review team to decide what to do. Of course after carefully weighing all opinions :-) Lastly, if factory-auto or legal-auto decline, the review guys either won't discuss it or file a bug against the respective script :-D -- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)