On Thursday 05 December 2013 09:56:17 Stephan Kulow wrote:
On 05.12.2013 09:45, Dominique Leuenberger a.k.a. Dimstar wrote:
Quoting Stephan Kulow <coolo@suse.de>:
Am 04.12.2013 20:29, schrieb Dimstar / Dominique Leuenberger:
Of the list above, I'd say 'accepted reviewers' is likely the least interested in it..
The others sound rather logical..
Well, if Sascha accepted a review and you look at it too and notice that Sascha overlooked something, wouldn't you want Sascha to know? :)
Only if the review team has a chance to 'change' it's opinion about a review. Currently, when I click 'accept' and then realize this was wrong, I can't decline it anymore (you remember, we had such cases).
So nudging sascha about it is surely nice.. but it's much more important that you as factory-maintainer knows about the 'dispute' so you won't check it in.
But Sascha won't know about it, so it might be fine if what Sascha overlooked is obviously wrong to everyone and it was purely an oversight. But what if Sascha "overlooked" something on purpose? Shouldn't we have a real discussion then?
At least it should be visible somehow. Therefore Sascha (usually) comments about iffy things when he accepts something. He even already used the commenting system for that.
But as far as I know you now, I'm expecting you to change the system in the next 15 minutes so that a reviewer can change his opinion :)
That's a valid expectation ;)
Greetings, Stephan
-- With kind regards, Sascha Peilicke SUSE Linux GmbH, Maxfeldstr. 5, D-90409 Nuernberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer HRB 16746 (AG Nürnberg)