On Wed, Oct 14, 2009 at 9:34 AM, Adrian Schröter <adrian@suse.de> wrote:
Am Mittwoch, 14. Oktober 2009 16:28:19 schrieb Michael Schroeder:
On Wed, Oct 14, 2009 at 04:21:11PM +0200, Marcus Hüwe wrote:
what about adding http range request support [1] to the backend? After I comitted r8169 ("get only the last N bytes of a logfile") last week darix suggested to use the http "Range" header instead of the "start" and "end" query parameters. The advantage of using the range header is that it is already part of the protocol and the range header isn't limited to the "getlogfile()" function (we can use it whenever a file is replied).
Dunno, I don't see so many use cases. For the log file, I'd rather have "give me the last 1000 lines" instead of bytes.
Yes, me too.
However, in general this is really great and important stuff. We should also use it for logfile in the web client by default IMHO. Usually only last ~ 100 lines are interessting and I really hate to download > 10 MB of logfile just for seeing the broken file list errors ;)
From an http perspective there is no such thing as "lines" - only bytes. Using the range header instead of several parameters is, IMO, a more elegant solution and puts the request at the proper layer. I'd rather see Range headers used than yet-another range-like-thing-that-isn't-ranges. In this case, I see it as a correction. ;-)
-- Jon -- To unsubscribe, e-mail: opensuse-buildservice+unsubscribe@opensuse.org For additional commands, e-mail: opensuse-buildservice+help@opensuse.org