[Bug 1017268] New: fstrim.timer vs. btrfsmaintenance
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 Bug ID: 1017268 Summary: fstrim.timer vs. btrfsmaintenance Classification: openSUSE Product: openSUSE Distribution Version: Leap 42.2 Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Basesystem Assignee: bnc-team-screening@forge.provo.novell.com Reporter: suse@bugs.jan.ritzerfeld.org QA Contact: qa-bugs@suse.de Found By: --- Blocker: --- After a fresh installation of Leap 42.2, the fstrim.timer is enabled and BTRFS_TRIM_PERIOD="weekly" is set to "weekly". That does not look right as the latter should be "Off by default so it does not collide with fstrim.timer". Upstream sets it to "none", however, https://build.opensuse.org/request/show/420441 did revert this change because "We don't use fstrim.timer so enable trim by default here.". But I think we do. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 http://bugzilla.opensuse.org/show_bug.cgi?id=1017268#c1 Ignacio Taranto <itaranto7@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |itaranto7@gmail.com --- Comment #1 from Ignacio Taranto <itaranto7@gmail.com> --- I can confirm that a default installation on an Samsung SSD has fstrim.timer enabled and the line BTRFS_TRIM_PERIOD="weekly" from /etc/sysconfig/btrfsmanteinance uncommented -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 Bernhard Wiedemann <bwiedemann@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwiedemann@suse.com Assignee|bnc-team-screening@forge.pr |dsterba@suse.com |ovo.novell.com | -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 http://bugzilla.opensuse.org/show_bug.cgi?id=1017268#c2 --- Comment #2 from Jan Ritzerfeld <suse@bugs.jan.ritzerfeld.org> --- Ping? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 http://bugzilla.opensuse.org/show_bug.cgi?id=1017268#c4 Jan Ritzerfeld <suse@bugs.jan.ritzerfeld.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Leap 42.2 |Leap 42.3 --- Comment #4 from Jan Ritzerfeld <suse@bugs.jan.ritzerfeld.org> --- Still valid for Leap 42.3. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 http://bugzilla.opensuse.org/show_bug.cgi?id=1017268#c5 Bernhard Wiedemann <bwiedemann@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbrabec@suse.com --- Comment #5 from Bernhard Wiedemann <bwiedemann@suse.com> --- CCing sbrabec as maintainer of util-linux-systemd -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=1017268 http://bugzilla.opensuse.org/show_bug.cgi?id=1017268#c6 --- Comment #6 from Stanislav Brabec <sbrabec@suse.com> --- Yes, fstrim.timer is enabled for all file systems intentionally. After the latest update, de-duplication works correctly and it provides trimming once a week for all file systems and devices that support it. fstrim currently does not have an exclude feature for --all This is apparently fixed in Leap 15 (my default is BTRFS_TRIM_PERIOD="none"). But it will need some script to perform the fix on upgrade, as standard fillup keeps previous values. Something like that: %post # BTRFS_TRIM_PERIOD defaults to weekly up to 42.3. If caused duplicated TRIM. # If fstrim.timer is enabled, set it to none. if test -l /etc/systemd/system/multi-user.target.wants/fstrim.timer ; then sed -i 's/^BTRFS_TRIM_PERIOD="weekly"/BTRFS_TRIM_PERIOD="none"/' /etc/sysconfig/btrfsmaintenance 2>/dev/null || : fi -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com