[Bug 697748] New: phpMyAdmin should not change /etc/php5/conf.d/suhosin.ini in %post
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c0 Summary: phpMyAdmin should not change /etc/php5/conf.d/suhosin.ini in %post Classification: openSUSE Product: openSUSE 11.4 Version: Final Platform: x86-64 OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: Network AssignedTo: lang@b1-systems.de ReportedBy: suse-beta@cboltz.de QAContact: qa@suse.de Found By: Beta-Customer Blocker: --- phpMyAdmin in server:php:applications contains a %post script that changes various values in /etc/php5/conf.d/suhosin.ini. This is a bad idea because: - it is done silently - an admin will have a hard time to find out who has changed suhosin.ini - it might conflict with some changes to suhosin.ini the admin has done (and might even override them - for example, I now have two different suhosin.post.max_vars in suhosin.ini on one of my servers) - it might cause problems with other vHosts (suhosin.ini contains server-wide config) The better way is: Change the suhosin values only for phpMyAdmin. There is already a /etc/apache2/conf.d/phpMyAdmin.conf in the phpMyAdmin package. Just add some php_admin_value settings inside the <Directory /srv/www/htdocs/phpMyAdmin> block. If I get the %post script right, the following should work in phpMyAdmin.conf: php_admin_value suhosin.post.max_array_index_length 256 php_admin_value suhosin.post.max_totalname_length 8192 php_admin_value suhosin.post.max_vars 2048 php_admin_value suhosin.request.max_array_index_length 256 php_admin_value suhosin.request.max_totalname_length 8192 php_admin_value suhosin.request.max_vars 2048 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c Ralf Lang <lang@b1-systems.de> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|lang@b1-systems.de |chris@computersalat.de -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c1 Ralf Lang <lang@b1-systems.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lang@b1-systems.de --- Comment #1 from Ralf Lang <lang@b1-systems.de> 2011-06-22 08:21:05 UTC --- I think chris should be involved here as he introduced this patch. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c2 Christian Wittmer <chris@computersalat.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO CC| |chris@computersalat.de InfoProvider| |suse-beta@cboltz.de --- Comment #2 from Christian Wittmer <chris@computersalat.de> 2011-06-22 09:13:46 UTC --- Hi Christian, would you please try updated version from server:php:applications and give feedback. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c3 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |NEW InfoProvider|suse-beta@cboltz.de | --- Comment #3 from Christian Boltz <suse-beta@cboltz.de> 2011-06-23 01:16:28 CEST --- Most important test first: phpMyAdmin is still working ;-) I changed one of the suhosin values in /etc/php5/conf.d/suhosin.ini and checked phpinfo() - it shows the value from php_admin_value as "local" value. Therefore I assume all php_admin_value lines work - at least I don't see an obvious error. I also checked the rpm %post script - looks much better now :-) However I just noticed a small (different) bug - you should reload apache in %post to activate the /etc/apache/conf.d/phpMyAdmin.conf (probably similar to the code used in %postun) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c4 Christian Wittmer <chris@computersalat.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #4 from Christian Wittmer <chris@computersalat.de> 2011-06-24 15:29:48 UTC --- fixed :) and for (different) bug: no, cause %config(noreplace) is used. hence apache restart is not needed in %post section on update. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c5 --- Comment #5 from Bernhard Wiedemann <bwiedemann@novell.com> 2011-06-24 18:00:27 CEST --- This is an autogenerated message for OBS integration: This bug (697748) was mentioned in https://build.opensuse.org/request/show/74468 Factory / phpMyAdmin -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c6 Christian Boltz <suse-beta@cboltz.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED | --- Comment #6 from Christian Boltz <suse-beta@cboltz.de> 2011-06-24 20:44:20 CEST --- (In reply to comment #4)
no, cause %config(noreplace) is used. hence apache restart is not needed in %post section on update.
I doubt - what happens when the package is installed the first time? ;-) (I assume the apache restart in %postun won't help in this case...) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=697748 https://bugzilla.novell.com/show_bug.cgi?id=697748#c7 Christian Wittmer <chris@computersalat.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution| |FIXED --- Comment #7 from Christian Wittmer <chris@computersalat.de> 2011-07-11 22:12:11 UTC --- hmm, you're right. fixed -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com