[Bug 471701] New: Deleting .svn directories with find triggers %install-no-mkdir-buildroot
https://bugzilla.novell.com/show_bug.cgi?id=471701 Summary: Deleting .svn directories with find triggers %install-no-mkdir-buildroot Classification: openSUSE Product: openSUSE.org Version: unspecified Platform: Other OS/Version: Other Status: NEW Severity: Normal Priority: P5 - None Component: BuildService AssignedTo: bnc-team-screening@forge.provo.novell.com ReportedBy: bitdealer@gmail.com QAContact: adrian@novell.com Found By: --- I'm deleting ".svn" directories from %{buildroot} with find %{buildroot}%{_datadir}/%{name} -name .svn -type d -depth -exec rm -rf {} \; but doing so generates the following warning: kde4-style-bespin.src: W: %install-no-mkdir-buildroot Your install section removes the buildroot but does not create them afterwards in a secure way, which allows attackers to trivially play tricks with symlinks on you. use mkdir %buildroot (no -p option!) or don't clean the buildroot in %install, because that's anyway already done for you by rpm. which is wrong in that case IMO. The package in question is kde4-style-bespin in KDE:KDE4:Community Url to package: https://build.opensuse.org/package/show?package=kde4-style-bespin&project=KDE%3AKDE4%3ACommunity -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=471701 User crrodriguez@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=471701#c1 Cristian Rodríguez <crrodriguez@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |crrodriguez@novell.com --- Comment #1 from Cristian Rodríguez <crrodriguez@novell.com> 2009-02-07 13:18:51 MST --- you should create the tarball in question with a files you obtained by using svn export and not svn checkout.. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=471701 User bitdealer@gmail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=471701#c2 --- Comment #2 from Stephan Kleine <bitdealer@gmail.com> 2009-02-09 01:11:24 MST --- Sure, then I wouldn't have any .svn entries in the first place. But then I also weren't able to run svn update but had to do a full export every time - which is too much overhead most times IMHO. Regardless of what is used, the original problem, that the check thinks I would delete the buildroot although I`m not doing this, remains the same. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=471701 Cyril Hrubis <chrubis@novell.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bnc-team-screening@forge.pr |adrian@novell.com |ovo.novell.com | -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=471701 User crrodriguez@novell.com added comment https://bugzilla.novell.com/show_bug.cgi?id=471701#c3 --- Comment #3 from Cristian Rodríguez <crrodriguez@novell.com> 2009-03-05 11:50:20 MST --- you have to remove the .svn directories in %prep %prep %setup (....) find . -name .svn -type d -depth -exec rm -rf {} + -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=471701 User bitdealer@gmail.com added comment https://bugzilla.novell.com/show_bug.cgi?id=471701#c4 --- Comment #4 from Stephan Kleine <bitdealer@gmail.com> 2009-03-08 16:17:42 MST --- Right, that would work as well. OTOH it would be more overhead if the source archive is very big and only just a few .svn directories end up in %buildroot (not that it would probably really matter that much with modern pcs). Still it is just working around the broken check since it thinks I would delete the %buildroot which is not the case. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com