[Bug 767438] New: tgtd init script does not properly do start, stop and status
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c0 Summary: tgtd init script does not properly do start, stop and status Classification: openSUSE Product: openSUSE 12.2 Version: Beta 1 Platform: Other OS/Version: openSUSE 12.2 Status: NEW Severity: Major Priority: P5 - None Component: Other AssignedTo: hare@suse.com ReportedBy: jdsn@suse.com QAContact: qa-bugs@suse.de CC: bwiedemann@suse.com Found By: Development Blocker: --- The init script of tgtd seems to be very broken: 1. start: it hangs or takes a long time to start 2. status: does not show the real status, as no PID file was created 3. stop: does not stop the process (seems like 'tgtadm --op delete --mode system' hangs) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c1 Hannes Reinecke <hare@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|hare@suse.com |lduncan@suse.com --- Comment #1 from Hannes Reinecke <hare@suse.com> 2012-07-30 09:00:01 UTC --- Lee, can you have a look? Thanks. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c2 Lee Duncan <lduncan@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Lee Duncan <lduncan@suse.com> 2012-07-30 17:11:27 PDT --- I have openSUSE 12.2 from a recent build, and here's what I see: 1. When I first ran "/etc/init.d/tgtd start", it hung. I found that systemd was hung on a process called systemd-tty-ask-password-agent, and that there seems to be some question around this command. After trial and error, I found that when I created the file "/var/run/systemd/ask-password/answer" (with the string "yes\n" in it, if that matters), the hang ended. Now "/etc/init.d/tgtd start" returns immediately on each invocation. This looks similar to bug 675406, which may mean that tgtd will have to be updated to work with systemd. I may file a separate bug on this issue, once I learn more. 2. Then I run "/etc/init.d/tgt status", and it prints normal (active, running) output. I do not think this is a problem, assuming #1 is fixed. 3. This does indeed seem to hang on "tgtadm --op delete --mode system". I will have to look into this, as these command-line options are not documented in the man page for tgtadm. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c3 --- Comment #3 from Lee Duncan <lduncan@suse.com> 2012-08-09 15:09:36 PDT --- As for issue#1, it looks like tgtd needs to be modified upstream to work with systemd. I'll work on that first. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c4 --- Comment #4 from Lee Duncan <lduncan@suse.com> 2012-08-23 12:17:35 PDT --- As noted in bug 675406, password agents are discussed here: http://www.freedesktop.org/wiki/Software/systemd/PasswordAgents -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c5 --- Comment #5 from Lee Duncan <lduncan@suse.com> 2012-08-27 16:42:31 PDT --- My Comment# 3 is not correct. After looking through the sources for tgtd, I can see no place where it asks interactively for a password. My first test of this, from Comment# 2, was using Build 0452, from June 20, 2012. That displayed the problem which you had as issue# 1. But I just tested the latest, Build 0091, from Aug 1, 2012, and that does not display the hang when starting "tgtd" any longer. I suspect that it may be one of the services that tgtd depends on which might have been hanging the first time, but since I can't reproduce it now, I can only speculate. If there is a hang again, that means that _something_ is asking for a password. The way that systemd works, if some process needs a password, it let's the systemd password agent subsystem handle it. If that happens, you should be able to see a message on the console saying which process is asking for a "secret". Because issue#1 no longer seems to be an issue, the same is true for issue#2: I did not have any problems getting status. But issue#3 still seems to be a problem, i.e. the tgtd stop script hangs when there are no targets. I will continue to look into this. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c6 --- Comment #6 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-08-28 07:40:16 CEST --- rctgtd status is still a problem when running with sysvinit. You can emulate this behaviour under systemd by calling rctgtd status foobar the init script contains checkproc -p $PIDFILE $DAEMON but I had to change it to checkproc $DAEMON to make it show "running" when tgtd was started -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c7 --- Comment #7 from Lee Duncan <lduncan@suse.com> 2012-10-02 15:13:31 PDT --- Looks like the real problem with stop and status are that PIDFILE should be "/var/run/ietd.pid", instead of "/var/run/iscsi_trgt.pid". -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c8 Lee Duncan <lduncan@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |per@computer.org --- Comment #8 from Lee Duncan <lduncan@suse.com> 2012-10-02 15:15:03 PDT --- *** Bug 781422 has been marked as a duplicate of this bug. *** http://bugzilla.novell.com/show_bug.cgi?id=781422 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c9 --- Comment #9 from Lee Duncan <lduncan@suse.com> 2012-10-02 15:51:34 PDT --- I am testing the following fixes: - PIDFILE should be "/var/run/ietd.pid" - moved config file ietd.conf to /etc/iet - added required config files initiators.allow, initiators.deny, and targets.allow - added ietadm.8 man page A test RPM will be available, if needed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c10 --- Comment #10 from Lee Duncan <lduncan@suse.com> 2012-10-02 16:10:43 PDT --- Submitted to openSUSE build service as Request: #136824. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c11 --- Comment #11 from Lee Duncan <lduncan@suse.com> 2012-10-04 18:18:39 PDT --- Comment# 7, Comment# 8, Comment# 9 and Comment# 10 were meant for another bug. Still working on this one ... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c12 --- Comment #12 from Lee Duncan <lduncan@suse.com> 2012-10-05 18:27:41 PDT --- Okay, I _believe_ I have nailed down the cause to problem 1 in the Description:
1. start: it hangs or takes a long time to start
Originally, I thought the problem was systemd-tty-ask-password-agent, but this is not the case. The problem is the line in the /etc/init.d/tgtd service file that says: "# pidfile: /var/run/tgtd.pid". It looks like this was removed in openSUSE 12.2 already as of 7/14/2012. I will check if the PIDFILE needs to be moved from the init script to fix problem 2 from the Description. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c13 --- Comment #13 from Lee Duncan <lduncan@suse.com> 2012-10-11 15:00:36 PDT --- I now have a solution to submit: - removed the PIDFILE all together from the init file, as it is not used, and - adds a patch from tgt mainline that fixes the hang problem (patch hash 0b88336c4b188f48e6bd2e8c94e0467dc805cc38 from git://github.com/fujita/tgt.git) -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c14 --- Comment #14 from Lee Duncan <lduncan@suse.com> 2012-10-11 15:08:33 PDT --- Submitted as Maintenance Request #137916. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c15 --- Comment #15 from Lee Duncan <lduncan@suse.com> 2012-10-15 15:20:29 PDT --- After making requested updated to "changes" file, resubmitted as Maintenance Request# 138250 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c16 Marcus Meissner <meissner@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |meissner@suse.com --- Comment #16 from Marcus Meissner <meissner@suse.com> 2012-10-25 14:33:28 UTC --- is this in Factory already? I do not see it in Base:System -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c17 --- Comment #17 from Lee Duncan <lduncan@suse.com> 2012-10-25 18:33:03 PDT --- (In reply to comment #16)
is this in Factory already? I do not see it in Base:System
No, it was not in Base:System, but I just submitted it (request id# 139360). -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c18 --- Comment #18 from Bernhard Wiedemann <bwiedemann@suse.com> 2012-10-26 16:00:08 CEST --- This is an autogenerated message for OBS integration: This bug (767438) was mentioned in https://build.opensuse.org/request/show/139442 Factory / tgt -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c19 --- Comment #19 from Lee Duncan <lduncan@suse.com> 2012-10-30 17:24:03 PDT --- Submitted stalled fix for openSUSE 12.2 as well ... -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c20 Lee Duncan <lduncan@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #20 from Lee Duncan <lduncan@suse.com> 2012-11-01 11:22:21 PDT --- Closing as resolved/fixed. -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
https://bugzilla.novell.com/show_bug.cgi?id=767438 https://bugzilla.novell.com/show_bug.cgi?id=767438#c21 --- Comment #21 from Swamp Workflow Management <swamp@suse.de> 2012-11-12 17:11:50 UTC --- openSUSE-RU-2012:1470-1: An update that has one recommended fix can now be installed. Category: recommended (low) Bug References: 767438 CVE References: Sources used: openSUSE 12.2 (src): tgt-1.0.28-2.7.1 -- Configure bugmail: https://bugzilla.novell.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com