[Bug 980570] New: gfxboot should be more flexible selecting a suitable video mode for itself
http://bugzilla.suse.com/show_bug.cgi?id=980570 Bug ID: 980570 Summary: gfxboot should be more flexible selecting a suitable video mode for itself Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Minor Priority: P5 - None Component: Basesystem Assignee: snwint@suse.com Reporter: snwint@suse.com QA Contact: qa-bugs@suse.de Found By: Community User Blocker: --- See https://github.com/openSUSE/gfxboot/issues/7. It doesn't start on Chromebooks as it doesn't find/can't set a video mode. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c1
--- Comment #1 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c2
Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c3
Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c4
Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c5
--- Comment #5 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c6
--- Comment #6 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c7
--- Comment #7 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c8
--- Comment #8 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c9
Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c10
--- Comment #10 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c11
--- Comment #11 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c12
--- Comment #12 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c13
--- Comment #13 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c14
--- Comment #14 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c15
--- Comment #15 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c16
--- Comment #16 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c17
--- Comment #17 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c18
--- Comment #18 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c19
--- Comment #19 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c20
--- Comment #20 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c21
Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c22
Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c23
--- Comment #23 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c24
--- Comment #24 from Timo Jyrinki
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c25
Patrick Rudolph
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c26
--- Comment #26 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c27
--- Comment #27 from Patrick Rudolph
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c28
--- Comment #28 from Patrick Rudolph
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c29
--- Comment #29 from Steffen Winterfeldt
SeaVGABios advertises 24bpp as the panel does support 24bpp, even though the VBE format should be 32bpp. I'll send a fix to SeaBIOS.
Uhm, is there a way to detect this situation? Like, add at least the color mask bits up to 32?
Is the attribute VBE_WINDOW_ATTRIBUTE_RELOCATABLE required ?
Good point. It isn't. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c30
--- Comment #30 from Patrick Rudolph
SeaVGABios advertises 24bpp as the panel does support 24bpp, even though the VBE format should be 32bpp. I'll send a fix to SeaBIOS.
Uhm, is there a way to detect this situation? Like, add at least the color mask bits up to 32? Yes that should be working, but all VBE clients expect the bpp to match the accumulated color bit mask.
I've sent a fix to SeaBIOS.
Is the attribute VBE_WINDOW_ATTRIBUTE_RELOCATABLE required ?
Good point. It isn't.
Looking at the code is seems that relocation is required as the "window" has a maximum pagesize of 64K, but I'm not familar with those addressing modes. In VBE2.0 there's a linear framebuffer that does not need relocations at all and it's the only mode supported by coreboot's SeaVGABios implementation. Would it be possible to add VBE2 and linear framebuffer support to gfxboot ? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c31
--- Comment #31 from Steffen Winterfeldt
Looking at the code is seems that relocation is required
You're right; after reading up the vbe specs again, 'relocation' means mapping different regions into the window. So yes, it's required and the code is correct.
Would it be possible to add VBE2 and linear framebuffer support to gfxboot?
Yes, I've done this in the branch mentioned in comment 23. The patch basically simulates the 64k window thing by moving 64k segment selectors across the framebuffer. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c32
--- Comment #32 from Patrick Rudolph
From Timo's reports it seems it gets the framebuffer address right: the code in
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c33
--- Comment #33 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c34
--- Comment #34 from Patrick Rudolph
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c35
--- Comment #35 from Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c36
--- Comment #36 from Patrick Rudolph
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c37
Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c38
Steffen Winterfeldt
http://bugzilla.suse.com/show_bug.cgi?id=980570
http://bugzilla.suse.com/show_bug.cgi?id=980570#c39
--- Comment #39 from Patrick Rudolph
participants (1)
-
bugzilla_noreply@novell.com